| Message ID | 1433266351-22587-3-git-send-email-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Antoine Tenart <antoine.tenart@free-electrons.com> writes: > The pxa3xx nand driver requires at least one clock to probe correctly. > A second one, named 'ecc' can be specified if needed. Add the > corresponding documentation. Is it mandatory, really ? The code does : info->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(info->clk)) { dev_err(&pdev->dev, "failed to get nand clock\n"); return PTR_ERR(info->clk); } info->clk can very well be NULL, can't it ? Cheers. -- Robert
diff --git a/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt b/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt index 4f833e3c4f51..ad30a02f1346 100644 --- a/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt +++ b/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt @@ -8,6 +8,8 @@ Required properties: - reg: The register base for the controller - interrupts: The interrupt to map - #address-cells: Set to <1> if the node includes partitions + - clocks: A phandle to the clocks + - clock-names: 'nfc' and 'ecc'. The 'nfc' clock is mandatory. Optional properties: @@ -32,6 +34,8 @@ Example: compatible = "marvell,pxa3xx-nand"; reg = <0x43100000 90>; interrupts = <45>; + clocks = <&gateclk 11>; + clock-names = "nfc"; #address-cells = <1>; marvell,nand-enable-arbiter;
The pxa3xx nand driver requires at least one clock to probe correctly. A second one, named 'ecc' can be specified if needed. Add the corresponding documentation. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt | 4 ++++ 1 file changed, 4 insertions(+)