| Message ID | 1433696621-4763-2-git-send-email-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Anand, > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig index 1b7253b..2bbdf80 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > +CONFIG_NEW_LEDS=y > +CONFIG_LEDS_CLASS=m > +CONFIG_LEDS_PWM=m > +CONFIG_LEDS_TRIGGERS=y > +CONFIG_LEDS_TRIGGER_TIMER=m > +CONFIG_LEDS_TRIGGER_HEARTBEAT=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_MAX77802=y Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
On 08.06.2015 02:03, Anand Moon wrote: > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. I am a little confused. This is v2. I found version 3, a little different: http://www.spinics.net/lists/linux-samsung-soc/msg44406.html (which Where is the changelog? Which one is newer? Should we drop the v3? While at it, can you add information WHY do you want to enable LEDS? Best regards, Krzysztof
Hi On 9 June 2015 at 05:26, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 08.06.2015 02:03, Anand Moon wrote: >> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for >> Odroid-XU3 board. > > I am a little confused. > > This is v2. > > I found version 3, a little different: > http://www.spinics.net/lists/linux-samsung-soc/msg44406.html > (which > > Where is the changelog? Which one is newer? Should we drop the v3? > While at it, can you add information WHY do you want to enable LEDS? > > Best regards, > Krzysztof > Look like I an doom to make mistake. With the introduction of this http://www.spinics.net/lists/linux-samsung-soc/msg44481.html We need to enable CONFIG_LEDS_PWM to make it working. So please drop the v3 patch. -Anand Moon
W dniu 08.06.2015 o 02:03, Anand Moon pisze: > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> Dear Anand, There was some confusion for this patch (mixed v3 and v2) so overall it slipped through fingers. Can you please: 1. Rebase and resend. 2. Enable them as built-ins, not modules. For exynos_defconfig everything is built-in which makes easier to test on various boards. 3. Enable LEDS_GPIO. I don't know why it disappeared... Best regards, Krzysztof > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 1b7253b..2bbdf80 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > +CONFIG_NEW_LEDS=y > +CONFIG_LEDS_CLASS=m > +CONFIG_LEDS_PWM=m > +CONFIG_LEDS_TRIGGERS=y > +CONFIG_LEDS_TRIGGER_TIMER=m > +CONFIG_LEDS_TRIGGER_HEARTBEAT=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_MAX77802=y >
HI Krzysztof, On 2 September 2015 at 19:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > W dniu 08.06.2015 o 02:03, Anand Moon pisze: >> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for >> Odroid-XU3 board. >> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > Dear Anand, > > There was some confusion for this patch (mixed v3 and v2) so overall it > slipped through fingers. > > Can you please: > 1. Rebase and resend. > 2. Enable them as built-ins, not modules. For exynos_defconfig > everything is built-in which makes easier to test on various boards. > 3. Enable LEDS_GPIO. I don't know why it disappeared... > > Best regards, > Krzysztof > > >> --- >> arch/arm/configs/exynos_defconfig | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig >> index 1b7253b..2bbdf80 100644 >> --- a/arch/arm/configs/exynos_defconfig >> +++ b/arch/arm/configs/exynos_defconfig >> @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y >> CONFIG_MMC_DW=y >> CONFIG_MMC_DW_IDMAC=y >> CONFIG_MMC_DW_EXYNOS=y >> +CONFIG_NEW_LEDS=y >> +CONFIG_LEDS_CLASS=m >> +CONFIG_LEDS_PWM=m >> +CONFIG_LEDS_TRIGGERS=y >> +CONFIG_LEDS_TRIGGER_TIMER=m >> +CONFIG_LEDS_TRIGGER_HEARTBEAT=m >> CONFIG_RTC_CLASS=y >> CONFIG_RTC_DRV_MAX77686=y >> CONFIG_RTC_DRV_MAX77802=y >> > Thanks for you input I will resend this patch. -Anand Moon
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 1b7253b..2bbdf80 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=m +CONFIG_LEDS_PWM=m +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_TIMER=m +CONFIG_LEDS_TRIGGER_HEARTBEAT=m CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y CONFIG_RTC_DRV_MAX77802=y
Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for Odroid-XU3 board. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/configs/exynos_defconfig | 6 ++++++ 1 file changed, 6 insertions(+)