| Message ID | 1434277445-5243-2-git-send-email-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14.06.2015 19:24, Anand Moon wrote: > This changes enables TMU IP block on the Exynos5422 Odroid-XU3 > device. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > --- > Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next > Changes from v5: Use LDO7 regulator instead of LD010. > > The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. > > I think the schematics are missing some of details but it can be deducted that: > 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 > pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). > 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of > S2MPS11 PMIC. > 3. I confirmed with the Exynos5422 datasheet that these > VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). > > So the LDO7 it is... but before using it there is a caveat. The LDO7 > is also connected to VDD of MIPI, HDMI and few more. So when you use > this regulator in TMU it may be turned off by TMU driver (e.g. during > unbind). In such case these other blocks also should be tested and > checked whether they take this regulator and enable it. Why did you took my email and pasted it here? http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/343702.html It is written now in first person so it pretends that you wrote this. You are actually doing this for second time - taking my reply and putting into commit message or changelog. Why? And where is proper changelog? Krzysztof > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index a2f9941..b6570fc 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -474,6 +474,31 @@ > status = "okay"; > }; > > +&tmu_cpu0 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_cpu1 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_cpu2 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_cpu3 { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > +&tmu_gpu { > + vtmu-supply = <&ldo7_reg>; > + status = "okay"; > +}; > + > &rtc { > status = "okay"; > clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; >
On 14.06.2015 19:24, Anand Moon wrote: > This changes enables TMU IP block on the Exynos5422 Odroid-XU3 > device. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > Tested-by: Markus Reichl <m.reichl@fivetechno.de> This does not look right. You put this "Tested-by" since beginning of this patchset (v1) but first it was LDO10. Then you proposed LDO18 and now you use LDO7 from my suggestion. Which of this was tested by Markus because I cannot find his emails with it on LKML? Krzysztof > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > --- > Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next > Changes from v5: Use LDO7 regulator instead of LD010. > > The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. > > I think the schematics are missing some of details but it can be deducted that: > 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 > pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). > 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of > S2MPS11 PMIC. > 3. I confirmed with the Exynos5422 datasheet that these > VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). > > So the LDO7 it is... but before using it there is a caveat. The LDO7 > is also connected to VDD of MIPI, HDMI and few more. So when you use > this regulator in TMU it may be turned off by TMU driver (e.g. during > unbind). In such case these other blocks also should be tested and > checked whether they take this regulator and enable it. > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+)
hi Krzysztof On 15 June 2015 at 05:21, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 14.06.2015 19:24, Anand Moon wrote: >> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >> device. >> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >> Tested-by: Markus Reichl <m.reichl@fivetechno.de> >> Acked-by: Lukasz Majewski <l.majewski@samsung.com> >> --- >> Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next >> Changes from v5: Use LDO7 regulator instead of LD010. >> >> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. >> >> I think the schematics are missing some of details but it can be deducted that: >> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 >> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). >> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of >> S2MPS11 PMIC. >> 3. I confirmed with the Exynos5422 datasheet that these >> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). >> >> So the LDO7 it is... but before using it there is a caveat. The LDO7 >> is also connected to VDD of MIPI, HDMI and few more. So when you use >> this regulator in TMU it may be turned off by TMU driver (e.g. during >> unbind). In such case these other blocks also should be tested and >> checked whether they take this regulator and enable it. > > Why did you took my email and pasted it here? > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/343702.html > > It is written now in first person so it pretends that you wrote this. > You are actually doing this for second time - taking my > reply and putting into commit message or changelog. Why? > > And where is proper changelog? > Sorry: My intention was never to take credit on what your guidance and your pointers. I value ever input of your and try not to repeat the mistakes I am repeating. I will send updated version soon. -Anand Moon > Krzysztof > >> --- >> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> index a2f9941..b6570fc 100644 >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi >> @@ -474,6 +474,31 @@ >> status = "okay"; >> }; >> >> +&tmu_cpu0 { >> + vtmu-supply = <&ldo7_reg>; >> + status = "okay"; >> +}; >> + >> +&tmu_cpu1 { >> + vtmu-supply = <&ldo7_reg>; >> + status = "okay"; >> +}; >> + >> +&tmu_cpu2 { >> + vtmu-supply = <&ldo7_reg>; >> + status = "okay"; >> +}; >> + >> +&tmu_cpu3 { >> + vtmu-supply = <&ldo7_reg>; >> + status = "okay"; >> +}; >> + >> +&tmu_gpu { >> + vtmu-supply = <&ldo7_reg>; >> + status = "okay"; >> +}; >> + >> &rtc { >> status = "okay"; >> clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; >> >
hi Krzysztof On 15 June 2015 at 05:41, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 14.06.2015 19:24, Anand Moon wrote: >> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >> device. >> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >> Tested-by: Markus Reichl <m.reichl@fivetechno.de> > > This does not look right. > You put this "Tested-by" since beginning of this patchset (v1) but first > it was LDO10. Then you proposed LDO18 and now you use LDO7 from my > suggestion. Which of this was tested by Markus because I cannot find his > emails with it on LKML? Markus Reichl tested the earlier version with LDO10. Commit logs got carry forward by mistake. -Anand Moon > > Krzysztof > >> Acked-by: Lukasz Majewski <l.majewski@samsung.com> >> --- >> Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next >> Changes from v5: Use LDO7 regulator instead of LD010. >> >> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. >> >> I think the schematics are missing some of details but it can be deducted that: >> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 >> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). >> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of >> S2MPS11 PMIC. >> 3. I confirmed with the Exynos5422 datasheet that these >> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). >> >> So the LDO7 it is... but before using it there is a caveat. The LDO7 >> is also connected to VDD of MIPI, HDMI and few more. So when you use >> this regulator in TMU it may be turned off by TMU driver (e.g. during >> unbind). In such case these other blocks also should be tested and >> checked whether they take this regulator and enable it. >> --- >> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >
On 15.06.2015 11:13, Anand Moon wrote: > hi Krzysztof > > On 15 June 2015 at 05:21, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: >> On 14.06.2015 19:24, Anand Moon wrote: >>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >>> device. >>> >>> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >>> Tested-by: Markus Reichl <m.reichl@fivetechno.de> >>> Acked-by: Lukasz Majewski <l.majewski@samsung.com> >>> --- >>> Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next >>> Changes from v5: Use LDO7 regulator instead of LD010. >>> >>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. >>> >>> I think the schematics are missing some of details but it can be deducted that: >>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 >>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). >>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of >>> S2MPS11 PMIC. >>> 3. I confirmed with the Exynos5422 datasheet that these >>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). >>> >>> So the LDO7 it is... but before using it there is a caveat. The LDO7 >>> is also connected to VDD of MIPI, HDMI and few more. So when you use >>> this regulator in TMU it may be turned off by TMU driver (e.g. during >>> unbind). In such case these other blocks also should be tested and >>> checked whether they take this regulator and enable it. >> >> Why did you took my email and pasted it here? >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/343702.html >> >> It is written now in first person so it pretends that you wrote this. >> You are actually doing this for second time - taking my >> reply and putting into commit message or changelog. Why? >> >> And where is proper changelog? >> > > Sorry: My intention was never to take credit on what your guidance and > your pointers. > I value ever input of your and try not to repeat the mistakes I am repeating. > I will send updated version soon. If you want to quote me, then it's fine. But please indicate that this is a quote. Thanks for resending. Later I'll give the patchset a try on my XU3-Lite. Best regards, Krzysztof
Hi Anand, Krzysztof Am 15.06.2015 um 04:23 schrieb Anand Moon: > hi Krzysztof > > On 15 June 2015 at 05:41, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: >> On 14.06.2015 19:24, Anand Moon wrote: >>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >>> device. >>> >>> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >>> Tested-by: Markus Reichl <m.reichl@fivetechno.de> >> >> This does not look right. >> You put this "Tested-by" since beginning of this patchset (v1) but first >> it was LDO10. Then you proposed LDO18 and now you use LDO7 from my >> suggestion. Which of this was tested by Markus because I cannot find his >> emails with it on LKML? > > Markus Reichl tested the earlier version with LDO10. This is right. > Commit logs got carry forward by mistake. > > -Anand Moon > >> >> Krzysztof >> >>> Acked-by: Lukasz Majewski <l.majewski@samsung.com> >>> --- >>> Changes rebase on git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung branch for-next >>> Changes from v5: Use LDO7 regulator instead of LD010. >>> >>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU. >>> >>> I think the schematics are missing some of details but it can be deducted that: >>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5 >>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]). >>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of >>> S2MPS11 PMIC. >>> 3. I confirmed with the Exynos5422 datasheet that these >>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES). >>> >>> So the LDO7 it is... but before using it there is a caveat. The LDO7 >>> is also connected to VDD of MIPI, HDMI and few more. So when you use >>> this regulator in TMU it may be turned off by TMU driver (e.g. during >>> unbind). In such case these other blocks also should be tested and >>> checked whether they take this regulator and enable it. >>> --- >>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 25 ++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >> > >
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index a2f9941..b6570fc 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -474,6 +474,31 @@ status = "okay"; }; +&tmu_cpu0 { + vtmu-supply = <&ldo7_reg>; + status = "okay"; +}; + +&tmu_cpu1 { + vtmu-supply = <&ldo7_reg>; + status = "okay"; +}; + +&tmu_cpu2 { + vtmu-supply = <&ldo7_reg>; + status = "okay"; +}; + +&tmu_cpu3 { + vtmu-supply = <&ldo7_reg>; + status = "okay"; +}; + +&tmu_gpu { + vtmu-supply = <&ldo7_reg>; + status = "okay"; +}; + &rtc { status = "okay"; clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;