From patchwork Sun Jun 14 20:19:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 6605391 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A8A3FC0020 for ; Sun, 14 Jun 2015 20:23:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C5A412041E for ; Sun, 14 Jun 2015 20:23:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9C7A20443 for ; Sun, 14 Jun 2015 20:23:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4EOJ-0006Zo-3c; Sun, 14 Jun 2015 20:20:27 +0000 Received: from bh-25.webhostbox.net ([208.91.199.152]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z4EO7-0005QT-C3 for linux-arm-kernel@lists.infradead.org; Sun, 14 Jun 2015 20:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=ICHHJByAlmsqhGALrqQMzJRVa7exbR0LUUuTJw0V6MA=; b=Atiiitv/c//NQrRhILqoMrfM1h8p0nb9Bi5FY8dRde7pDT9t+HzaZexb4IF2Fx79eT3NTLYPf4TC1N30rbuY00WMOLHk/uVyaffBDWErCKoUUauQCtP2vpIya6dnoEKRWfd1G5+nsLmfAqKZZ0c1FKQaAJbyjKDAbFNfsuBs/u4=; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:43025 helo=localhost) by bh-25.webhostbox.net with esmtpa (Exim 4.85) (envelope-from ) id 1Z4ENj-001H0K-Kn; Sun, 14 Jun 2015 20:19:51 +0000 From: Guenter Roeck To: Russell King Subject: [PATCH v2 2/2] ARM: debug: Fix unsupported operand in Kconfig.debug Date: Sun, 14 Jun 2015 13:19:46 -0700 Message-Id: <1434313186-22150-2-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1434313186-22150-1-git-send-email-linux@roeck-us.net> References: <1434313186-22150-1-git-send-email-linux@roeck-us.net> X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150614_132015_548293_1A6E3AB9 X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.1 (/) Cc: Guenter Roeck , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP arm builds show the following warning. arch/arm/Kconfig.debug:1576:warning: ignoring unsupported character '>' This is due to config DEBUG_UART_8250_WORD bool "Use 32-bit accesses for 8250 UART" depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250 depends on DEBUG_UART_8250_SHIFT >= 2 The unsupported operand causes DEBUG_UART_8250_WORD to be disabled if DEBUG_UART_8250_SHIFT is larger than 2, which is not what is intended. Fixes: 0b4cccbec606 ("ARM: debug: add support for word accesses to debug/8250.S") Cc: Russell King Signed-off-by: Guenter Roeck --- v2: Instead of configuring DEBUG_UART_8250_WORD only if DEBUG_UART_8250_SHIFT == 2, set it if DEBUG_UART_8250_SHIFT is neither 0 nor 1. arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 6608121c6ea5..23a8b4901cb9 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -1574,7 +1574,7 @@ config DEBUG_UART_8250_SHIFT config DEBUG_UART_8250_WORD bool "Use 32-bit accesses for 8250 UART" depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250 - depends on DEBUG_UART_8250_SHIFT >= 2 + depends on DEBUG_UART_8250_SHIFT != 0 && DEBUG_UART_8250_SHIFT != 1 default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART0 || \ DEBUG_SOCFPGA_UART1 || ARCH_KEYSTONE || \ DEBUG_ALPINE_UART0 || \