From patchwork Wed Jun 17 17:33:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 6627381 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DBDAC9F1C1 for ; Wed, 17 Jun 2015 17:39:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E54EC2085A for ; Wed, 17 Jun 2015 17:39:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE7E720856 for ; Wed, 17 Jun 2015 17:39:00 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z5HGh-0001Bz-Lm; Wed, 17 Jun 2015 17:36:55 +0000 Received: from mail-bn1bon0113.outbound.protection.outlook.com ([157.56.111.113] helo=na01-bn1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z5HGO-0000lj-OZ for linux-arm-kernel@lists.infradead.org; Wed, 17 Jun 2015 17:36:38 +0000 Received: from BY2PR03CA008.namprd03.prod.outlook.com (10.255.93.25) by BL2PR03MB244.namprd03.prod.outlook.com (10.255.231.26) with Microsoft SMTP Server (TLS) id 15.1.195.6; Wed, 17 Jun 2015 17:36:13 +0000 Received: from BN1AFFO11FD015.protection.gbl (10.255.93.4) by BY2PR03CA008.outlook.office365.com (10.255.93.25) with Microsoft SMTP Server (TLS) id 15.1.190.14 via Frontend Transport; Wed, 17 Jun 2015 17:36:12 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; lists.infradead.org; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD015.mail.protection.outlook.com (10.58.52.75) with Microsoft SMTP Server (TLS) id 15.1.190.9 via Frontend Transport; Wed, 17 Jun 2015 17:36:11 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id t5HHZpv2016757; Wed, 17 Jun 2015 10:36:05 -0700 From: Dong Aisheng To: Subject: [PATCH 2/5] dts: imx53: fix sd card gpio polarity specified in device tree Date: Thu, 18 Jun 2015 01:33:35 +0800 Message-ID: <1434562418-24090-3-git-send-email-aisheng.dong@freescale.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1434562418-24090-1-git-send-email-aisheng.dong@freescale.com> References: <1434562418-24090-1-git-send-email-aisheng.dong@freescale.com> X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD015; 1:xnvkjxz4sFKJIGAl97iCCQKXj8zOn95WOfAm5Gu103T4/GPWz1uciJXvV0pUbWcEwDJj2brPcpqX0ZaStZlES7Rvi4KpkD5aIIg1yZpEL3n9B39oiuwUylNI1hu4jIpkS2iFKKmKa7qrrbkrmhK/8PAM1eq5T0lwsklJGH/38ck2AaSUDukCm+4PfQYICb89geYUBozpwc5xEJ7PbEop6O5ngFzzqzt8uobBfIByyLX/UlQ46UY7D4x0VtXkxrz+9FqlMIXZO1NkrtRxAB7kybSCzm/+INklYdtyXW4DP6AKo9zAUp7yK8JCuDzw73GueJ0VBhchesdxMB6SFles87ZALBv6ztr+MvfNH1RhMDw= X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(339900001)(189002)(199003)(92566002)(575784001)(86362001)(2351001)(33646002)(105606002)(106466001)(104016003)(87936001)(229853001)(36756003)(110136002)(5001960100002)(77096005)(2950100001)(81156007)(48376002)(76176999)(50986999)(47776003)(189998001)(50466002)(85426001)(50226001)(19580395003)(6806004)(62966003)(77156002)(19580405001)(46102003); DIR:OUT; SFP:1102; SCL:1; SRVR:BL2PR03MB244; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB244; 2:hFbbHpeZUuJFkzQOThwlGqxQnB9JYyMkXHXfC3jR8dRlpTRulonOW/oPj5UMmXcl; 3:e0hos7O7Yieku4Gn2ilX78CDjuyMMS4/8E3ToNbtdMBKbkmldND0gumqhjQREVXJhLq3cV0VZOkzDmyK86iEmnVs/gq7ef/UuBfjnxBbbgTe9KcIZFHvGcPwkhn7UnAjrzsszC9ayi04tH0Q7/wL7CntkExGkfX1NUV2h5YSlADf/cPPKl/l1OehX46SZG5VGmezYctecJb++pzpxOvdA+YasY60mOCufm8YLYdM8TU=; 20:AahEWuyMrZHUBJPjDDE7CcReCwSUSxeZw6PgsO9foms9LOiRbpJ9y2A96PaoEfPKNQWzNEUjHanchlPhSBxRqUyUnvP4iYdgvBLsm4RB9QVrks06Nj54a86DyRgqkRcRwXJIOaGTtdxCscux6YyqlB5SzcL1NpqG+ktljJNi3KvNqcTQCXp15qpv4bgxHOLZs6BbsKV5XneJ55r6nHoPSUw3o6HNIuoeXG5v6Du8FCq9CHli1tltZytrUVfMcMzld6jbOzLADL+FjQk5DcE2izl44Hbjitth2ENu44MQKWwdhDoQ4mH88PPfvQCEO+q2VfMVoJYSxNVAOJkz3XbPDPjiSB8Qiw40A5RcUEnsKLE=; 4:lmVn7KiS0WTIZfw8H1qtG1pZPE0T4g+nM/va9lPgJhULjf0TzKX/g2CH+P5hCrFg72FxzP3qrsdNJJ/mopuBrJAUld4yQdxhkRYUd/rOcOufGFBqfkxQYmZ4PF8jD56twX1S+5Zgfin4NCVfrm4iSx9K0BPIBfMX2PG72bPigCT54WEgPKxMBgq1y0lOl4Cf7qGO09E3chNnF/LF3iku+AeFH7ssJm5zFhqC6SJ0XA5dRMCvNiYVRALNBG4wP/1eCOegkJQmRoRuSFXlz+5Aesem99MIMNaTlzwYGRU60QQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB244; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BL2PR03MB244; BCL:0; PCL:0; RULEID:; SRVR:BL2PR03MB244; X-Forefront-PRVS: 0610D16BBE X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB244; 23:YCP49eqeL7I39+IrFmp1dSW9k3P1cKDgsaHyD4sj6LFQeUvMp0w2bWnuTkbFZ8AV3YPuaqd8lZzVBMHFgwoVGL1R0L/MDLWzQOGHgybUx+Wdr4+D3F0od7IjSEAF1gtshczWCk5g1nPD3pYo5tmw4uvZT2+iBB1az9xorEXO4eYsp+KUCp711NlHrBaLs1GNACU48wRgEh0WHTQxuZkiqG4UEqUNLjca7isz0HbaEGg+AWlSNH7FGsWIslT+lkRKXpVlWOFbwgfvkqSVIPM/GsWa8/zWl8J79bwN0eGaNIL4U8W0nztBjad0kS8DMVuUvYse3YzeGqCzUhFmSYf6xYAzonUYOsfzriM2UATiGfl/M3ZVRlHShRDwEzW+lVSf/ihOb54v9TIP5BVmrqhEkB6QSjRm5ZwBX6kUWbsTeXKyJvdjdmTYlsRPcp+8Pxj75blOGenGjrptgO6gx4y+ZazuVuFqWX7d7IewfMeVEeoYa/J2Rw+PYqdy/157XjISKF2zAPtycwzoJ92RpA4X4LHa+EUQqmPGmgJHA4EUuCWtKtErZFV2KoCgK4LDVNVFW1jzmAshP0GABiUsXsTl5sACkvgjCTvYcb92uEO4t+o9dDVGl+RvLnix6jegQeeHYsTee/ew5fhC92vH0jIseU7WXrlsCI+CelBFayLLZlEV1bos++S5ToIiraki4j53zeXJanSlIWBe4kY8XnSWSCGJVmgd9Z1GGHlkozob9OER7kE10UWJ9NUeiWvu8HUm419bigYm6h8xsMR1htnUTnR5+Ey6Vf5EoIBQmYd0zu+rRlDCFZqVE2VIxiTUBMwauZrbAW1l2fmM66+443ioc4QOiUTr+nr89mOumQO3yL73koCDm+kF68CJjYj5nmZxzz+oxxJ2qM10ukT9PhFkjFFXe+Ui4lB5Sw/6qVvaBLI= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB244; 5:YrPPy6gIEY6ta4/EEY5JgV/M1ay26xVGgKODR+/6eZcihUEwr1QDbQd7PSLAKGnJ9LE/kAhgk29xL/9bak3Ej0AjvnP0oKcOLmMT+wOVr2x6SGOx0zBX6glOB6PZdiQ0yQVNHLH9FfalZevpzaLs9g==; 24:PYEXOVmKdoUqblMuuiJwDjWcE54uH5lnRKWmp2+msKa9Wm8RNxq7/fOgpnS1ozZ3ABP3TsybNSXB64ltfd1n4O8ohib3tQqqsdJJpEiJ7is=; 20:TrkXzwOakFBtbHlO81FK4o8EI30EZrAIqQ9zp0J5U0bLCGwW4B0uN/9G5FxwuJDbh/NKrhkvG03td5tREFCfaA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 17:36:11.7663 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB244 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150617_103637_097350_A728C1B2 X-CRM114-Status: UNSURE ( 6.35 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) Cc: fabio.estevam@freescale.com, marex@denx.de, ulf.hansson@linaro.org, s.trumtrar@pengutronix.de, smoch@web.de, linux-arm-kernel@lists.infradead.org, robertcnelson@gmail.com, s.hauer@pengutronix.de, chris@printf.net, rabeeh@solid-run.com, troy.kisky@boundarydevices.com, lisovy@gmail.com, hs@denx.de, gwenhael.goavec-merou@armadeus.com, p.zabel@pengutronix.de, rmk+kernel@arm.linux.org.uk, shawn.guo@linaro.org, b29396@freescale.com, tharvey@gateworks.com, LW@KARO-electronics.de, ipaton0@gmail.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP cd-gpios polarity should be changed to GPIO_ACTIVE_LOW and wp-gpios should be changed to GPIO_ACTIVE_HIGH. Otherwise, the SD may not work properly due to wrong polarity inversion specified in DT after switch to common parsing function mmc_of_parse(). Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx53-ard.dts | 4 ++-- arch/arm/boot/dts/imx53-m53evk.dts | 4 ++-- arch/arm/boot/dts/imx53-qsb-common.dtsi | 4 ++-- arch/arm/boot/dts/imx53-smd.dts | 4 ++-- arch/arm/boot/dts/imx53-tqma53.dtsi | 4 ++-- arch/arm/boot/dts/imx53-tx53.dtsi | 4 ++-- arch/arm/boot/dts/imx53-voipac-bsb.dts | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/imx53-ard.dts b/arch/arm/boot/dts/imx53-ard.dts index e9337ad..3bc1883 100644 --- a/arch/arm/boot/dts/imx53-ard.dts +++ b/arch/arm/boot/dts/imx53-ard.dts @@ -103,8 +103,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio1 1 0>; - wp-gpios = <&gpio1 9 0>; + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-m53evk.dts b/arch/arm/boot/dts/imx53-m53evk.dts index d0e0f57..53f4088 100644 --- a/arch/arm/boot/dts/imx53-m53evk.dts +++ b/arch/arm/boot/dts/imx53-m53evk.dts @@ -124,8 +124,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio1 1 0>; - wp-gpios = <&gpio1 9 0>; + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi index 181ae5e..1f55187 100644 --- a/arch/arm/boot/dts/imx53-qsb-common.dtsi +++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi @@ -147,8 +147,8 @@ &esdhc3 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc3>; - cd-gpios = <&gpio3 11 0>; - wp-gpios = <&gpio3 12 0>; + cd-gpios = <&gpio3 11 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio3 12 GPIO_ACTIVE_HIGH>; bus-width = <8>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-smd.dts b/arch/arm/boot/dts/imx53-smd.dts index 1d32557..fc89ce1 100644 --- a/arch/arm/boot/dts/imx53-smd.dts +++ b/arch/arm/boot/dts/imx53-smd.dts @@ -41,8 +41,8 @@ &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; - cd-gpios = <&gpio3 13 0>; - wp-gpios = <&gpio4 11 0>; + cd-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio4 11 GPIO_ACTIVE_HIGH>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx53-tqma53.dtsi b/arch/arm/boot/dts/imx53-tqma53.dtsi index 4f1f0e2..e03373a 100644 --- a/arch/arm/boot/dts/imx53-tqma53.dtsi +++ b/arch/arm/boot/dts/imx53-tqma53.dtsi @@ -41,8 +41,8 @@ pinctrl-0 = <&pinctrl_esdhc2>, <&pinctrl_esdhc2_cdwp>; vmmc-supply = <®_3p3v>; - wp-gpios = <&gpio1 2 0>; - cd-gpios = <&gpio1 4 0>; + wp-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; status = "disabled"; }; diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi index 704bd72..d3e50b2 100644 --- a/arch/arm/boot/dts/imx53-tx53.dtsi +++ b/arch/arm/boot/dts/imx53-tx53.dtsi @@ -183,7 +183,7 @@ }; &esdhc1 { - cd-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>; fsl,wp-controller; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>; @@ -191,7 +191,7 @@ }; &esdhc2 { - cd-gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; + cd-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>; fsl,wp-controller; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc2>; diff --git a/arch/arm/boot/dts/imx53-voipac-bsb.dts b/arch/arm/boot/dts/imx53-voipac-bsb.dts index c17d3ad..fc51b87 100644 --- a/arch/arm/boot/dts/imx53-voipac-bsb.dts +++ b/arch/arm/boot/dts/imx53-voipac-bsb.dts @@ -119,8 +119,8 @@ &esdhc2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc2>; - cd-gpios = <&gpio3 25 0>; - wp-gpios = <&gpio2 19 0>; + cd-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>; vmmc-supply = <®_3p3v>; status = "okay"; };