| Message ID | 1434631121-32014-2-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Thomas, On 18/06/2015 14:38, Thomas Petazzoni wrote: > This regulator was lacking the reference to the GPIO that controls it, > and the regulator-min-microvolt and regulator-max-microvolt > properties. Thanks to this commit, the pwr-sata0 regulator now looks > more like the other pwr-sata{1,2,3} regulators in the same Device > Tree, with of course the exception of a different GPIO reference. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > --- > arch/arm/boot/dts/armada-388-gp.dts | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts > index 78514ab..5164b9a 100644 > --- a/arch/arm/boot/dts/armada-388-gp.dts > +++ b/arch/arm/boot/dts/armada-388-gp.dts > @@ -301,9 +301,11 @@ > reg_sata0: pwr-sata0 { > compatible = "regulator-fixed"; > regulator-name = "pwr_en_sata0"; > + regulator-min-microvolt = <12000000>; > + regulator-max-microvolt = <12000000>; > enable-active-high; > regulator-always-on; > - > + gpio = <&expander0 2 GPIO_ACTIVE_HIGH>; > }; > > reg_5v_sata0: v5-sata0 { >
Hi Thomas, On 29/06/2015 14:46, Gregory CLEMENT wrote: > Hi Thomas, > > On 18/06/2015 14:38, Thomas Petazzoni wrote: >> This regulator was lacking the reference to the GPIO that controls it, >> and the regulator-min-microvolt and regulator-max-microvolt >> properties. Thanks to this commit, the pwr-sata0 regulator now looks >> more like the other pwr-sata{1,2,3} regulators in the same Device >> Tree, with of course the exception of a different GPIO reference. >> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> applied on mvebu/dt Thanks, Gregory > > > Thanks, > > Gregory > >> --- >> arch/arm/boot/dts/armada-388-gp.dts | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts >> index 78514ab..5164b9a 100644 >> --- a/arch/arm/boot/dts/armada-388-gp.dts >> +++ b/arch/arm/boot/dts/armada-388-gp.dts >> @@ -301,9 +301,11 @@ >> reg_sata0: pwr-sata0 { >> compatible = "regulator-fixed"; >> regulator-name = "pwr_en_sata0"; >> + regulator-min-microvolt = <12000000>; >> + regulator-max-microvolt = <12000000>; >> enable-active-high; >> regulator-always-on; >> - >> + gpio = <&expander0 2 GPIO_ACTIVE_HIGH>; >> }; >> >> reg_5v_sata0: v5-sata0 { >> > >
diff --git a/arch/arm/boot/dts/armada-388-gp.dts b/arch/arm/boot/dts/armada-388-gp.dts index 78514ab..5164b9a 100644 --- a/arch/arm/boot/dts/armada-388-gp.dts +++ b/arch/arm/boot/dts/armada-388-gp.dts @@ -301,9 +301,11 @@ reg_sata0: pwr-sata0 { compatible = "regulator-fixed"; regulator-name = "pwr_en_sata0"; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; enable-active-high; regulator-always-on; - + gpio = <&expander0 2 GPIO_ACTIVE_HIGH>; }; reg_5v_sata0: v5-sata0 {
This regulator was lacking the reference to the GPIO that controls it, and the regulator-min-microvolt and regulator-max-microvolt properties. Thanks to this commit, the pwr-sata0 regulator now looks more like the other pwr-sata{1,2,3} regulators in the same Device Tree, with of course the exception of a different GPIO reference. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/arm/boot/dts/armada-388-gp.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)