From patchwork Tue Jun 30 14:14:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Richter X-Patchwork-Id: 6696501 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 49C409F39B for ; Tue, 30 Jun 2015 14:17:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4741C20617 for ; Tue, 30 Jun 2015 14:17:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FAC620495 for ; Tue, 30 Jun 2015 14:17:11 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z9wJI-0002PH-Af; Tue, 30 Jun 2015 14:14:52 +0000 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Z9wJ7-0002ER-Ql for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2015 14:14:42 +0000 Received: by wiwl6 with SMTP id l6so133741757wiw.0 for ; Tue, 30 Jun 2015 07:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Hv7msivAe1Q+xNKGa5ZHflkoPUZC85GedbY8hNJN3o0=; b=P0rSLtHuFyw0z6mO87j6Y9NON0OEMXFvnWpiq6yrI0DeXYIlV3W/SaJXDN0eYrKGFM npId9gJsSLfl9i6jk5P35sl2xxTnOEsdKZedXDMM50Paol8ddW1cuUQdwSdIMUxwxFhN 9YF3KAE57360dyNSYZyqbJr5yUQZwb5ebDdrnQLzjANMRjKccypo3Ki59XxXXLajCHxf 4RhbNnePn2OXcN9nYRPAwiRjgogQevt4lflWsKJsdf4i2w+stQ4NY7p7MT9IGSW7uE9e 9FTfLJ23LYF7OTXuIs5auDEis/NEcjEZavZ4sGNiy2hinlmC/BLoT+XynukrY5a/xxQd BaOw== X-Received: by 10.195.17.199 with SMTP id gg7mr41829903wjd.121.1435673659681; Tue, 30 Jun 2015 07:14:19 -0700 (PDT) Received: from rric.localhost (f053084022.adsl.alicedsl.de. [78.53.84.22]) by mx.google.com with ESMTPSA id ym2sm69250192wjc.44.2015.06.30.07.14.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jun 2015 07:14:18 -0700 (PDT) From: Robert Richter To: Marc Zygnier , Thomas Gleixner , Jason Cooper Subject: [PATCH 1/4] irqchip, gicv3-its: Read typer register outside the loop Date: Tue, 30 Jun 2015 16:14:00 +0200 Message-Id: <1435673643-31676-2-git-send-email-rric@kernel.org> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1435673643-31676-1-git-send-email-rric@kernel.org> References: <1435673643-31676-1-git-send-email-rric@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150630_071442_008205_6848AF4A X-CRM114-Status: GOOD ( 12.81 ) X-Spam-Score: -2.4 (--) Cc: Robert Richter , Tirumalesh Chalamarla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Robert Richter No need to read the typer register in the loop. Values do not change. Signed-off-by: Robert Richter --- drivers/irqchip/irq-gic-v3-its.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 1b7e155869f6..c5ce21277920 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -803,6 +803,8 @@ static int its_alloc_tables(struct its_node *its) int psz = SZ_64K; u64 shr = GITS_BASER_InnerShareable; u64 cache = GITS_BASER_WaWb; + u64 typer = readq_relaxed(its->base + GITS_TYPER); + u32 ids = GITS_TYPER_DEVBITS(typer); for (i = 0; i < GITS_BASER_NR_REGS; i++) { u64 val = readq_relaxed(its->base + GITS_BASER + i * 8); @@ -825,9 +827,6 @@ static int its_alloc_tables(struct its_node *its) * For other tables, only allocate a single page. */ if (type == GITS_BASER_TYPE_DEVICE) { - u64 typer = readq_relaxed(its->base + GITS_TYPER); - u32 ids = GITS_TYPER_DEVBITS(typer); - /* * 'order' was initialized earlier to the default page * granule of the the ITS. We can't have an allocation