diff mbox

ARM: dts: vf-colibri: define stdout-path property

Message ID 1435910799-11706-1-git-send-email-stefan@agner.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Agner July 3, 2015, 8:06 a.m. UTC
Define Vybrid's UART0, connected to the Colibri pinout UART_A, as
standard output.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo July 13, 2015, 3:10 p.m. UTC | #1
On Fri, Jul 03, 2015 at 10:06:39AM +0200, Stefan Agner wrote:
> Define Vybrid's UART0, connected to the Colibri pinout UART_A, as
> standard output.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 2cbe663..cb199ae 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -10,6 +10,7 @@
>  / {
>  	chosen {
>  		bootargs = "console=ttyLP0,115200";
> +		stdout-path = "serial0:115200n8";

With this change, can bootargs just be dropped?

Shawn

>  	};
>  
>  	clk16m: clk16m {
> -- 
> 2.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
Stefan Agner July 15, 2015, 2:05 p.m. UTC | #2
On 2015-07-13 17:10, Shawn Guo wrote:
> On Fri, Jul 03, 2015 at 10:06:39AM +0200, Stefan Agner wrote:
>> Define Vybrid's UART0, connected to the Colibri pinout UART_A, as
>> standard output.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>>  arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
>> index 2cbe663..cb199ae 100644
>> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
>> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
>> @@ -10,6 +10,7 @@
>>  / {
>>  	chosen {
>>  		bootargs = "console=ttyLP0,115200";
>> +		stdout-path = "serial0:115200n8";
> 
> With this change, can bootargs just be dropped?

I guess it would break a (fairly old) kernel which does not support
stdout-path yet?

However, the newer Vybrid DT's anyway do not work on old kernels due to
the interrupt hierarchy changes...

Will send a v2 without default bootargs.

--
Stefan
Shawn Guo July 17, 2015, 2:55 a.m. UTC | #3
On Wed, Jul 15, 2015 at 04:05:50PM +0200, Stefan Agner wrote:
> On 2015-07-13 17:10, Shawn Guo wrote:
> > On Fri, Jul 03, 2015 at 10:06:39AM +0200, Stefan Agner wrote:
> >> Define Vybrid's UART0, connected to the Colibri pinout UART_A, as
> >> standard output.
> >>
> >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> >> ---
> >>  arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> >> index 2cbe663..cb199ae 100644
> >> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> >> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> >> @@ -10,6 +10,7 @@
> >>  / {
> >>  	chosen {
> >>  		bootargs = "console=ttyLP0,115200";
> >> +		stdout-path = "serial0:115200n8";
> > 
> > With this change, can bootargs just be dropped?
> 
> I guess it would break a (fairly old) kernel which does not support
> stdout-path yet?

The DT ABI requires that the new kernel doesn't break anything
with old DTB, but doesn't require the compatibility between new DTB
and old kernel.

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
index 2cbe663..cb199ae 100644
--- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
+++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
@@ -10,6 +10,7 @@ 
 / {
 	chosen {
 		bootargs = "console=ttyLP0,115200";
+		stdout-path = "serial0:115200n8";
 	};
 
 	clk16m: clk16m {