| Message ID | 1436428847-8886-5-git-send-email-jiang.liu@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 9 Jul 2015, Jiang Liu wrote: > Use accessor for_pci_msi_entry() to access MSI device list, so we could > easily move msi_list from struct pci_dev into struct device later. > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> Acked-by: Sebastian Ott <sebott@linux.vnet.ibm.com> Regards, Sebastian > --- > arch/s390/pci/pci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c > index 598f023cf8a6..34f162753403 100644 > --- a/arch/s390/pci/pci.c > +++ b/arch/s390/pci/pci.c > @@ -414,7 +414,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) > > /* Request MSI interrupts */ > hwirq = 0; > - list_for_each_entry(msi, &pdev->msi_list, list) { > + for_each_pci_msi_entry(msi, pdev) { > rc = -EIO; > irq = irq_alloc_desc(0); /* Alloc irq on node 0 */ > if (irq < 0) > @@ -440,7 +440,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) > return (msi_vecs == nvec) ? 0 : msi_vecs; > > out_msi: > - list_for_each_entry(msi, &pdev->msi_list, list) { > + for_each_pci_msi_entry(msi, pdev) { > if (hwirq-- == 0) > break; > irq_set_msi_desc(msi->irq, NULL); > @@ -470,7 +470,7 @@ void arch_teardown_msi_irqs(struct pci_dev *pdev) > return; > > /* Release MSI interrupts */ > - list_for_each_entry(msi, &pdev->msi_list, list) { > + for_each_pci_msi_entry(msi, pdev) { > if (msi->msi_attrib.is_msix) > __pci_msix_desc_mask_irq(msi, 1); > else > -- > 1.7.10.4 > >
diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index 598f023cf8a6..34f162753403 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -414,7 +414,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) /* Request MSI interrupts */ hwirq = 0; - list_for_each_entry(msi, &pdev->msi_list, list) { + for_each_pci_msi_entry(msi, pdev) { rc = -EIO; irq = irq_alloc_desc(0); /* Alloc irq on node 0 */ if (irq < 0) @@ -440,7 +440,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) return (msi_vecs == nvec) ? 0 : msi_vecs; out_msi: - list_for_each_entry(msi, &pdev->msi_list, list) { + for_each_pci_msi_entry(msi, pdev) { if (hwirq-- == 0) break; irq_set_msi_desc(msi->irq, NULL); @@ -470,7 +470,7 @@ void arch_teardown_msi_irqs(struct pci_dev *pdev) return; /* Release MSI interrupts */ - list_for_each_entry(msi, &pdev->msi_list, list) { + for_each_pci_msi_entry(msi, pdev) { if (msi->msi_attrib.is_msix) __pci_msix_desc_mask_irq(msi, 1); else
Use accessor for_pci_msi_entry() to access MSI device list, so we could easily move msi_list from struct pci_dev into struct device later. Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> --- arch/s390/pci/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)