| Message ID | 1438152754-11970-2-git-send-email-jamesjj.liao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao: > The dpi_ck clock can be removed because it not actually used > in topckgen and subsystems. > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> From our past discussions this change looks about right, and should still become _part of 4.2_, to not have the CLK_TOP_DPI become part of the devicetree CLK_TOP_DPI. Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/clk/mediatek/clk-mt8173.c | 1 - > include/dt-bindings/clock/mt8173-clk.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mt8173.c > b/drivers/clk/mediatek/clk-mt8173.c index 4b9e04c..4486f8f 100644 > --- a/drivers/clk/mediatek/clk-mt8173.c > +++ b/drivers/clk/mediatek/clk-mt8173.c > @@ -26,7 +26,6 @@ static DEFINE_SPINLOCK(mt8173_clk_lock); > > static const struct mtk_fixed_factor root_clk_alias[] __initconst = { > FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1), > - FACTOR(CLK_TOP_DPI, "dpi_ck", "clk_null", 1, 1), > FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1), > FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1), > }; > diff --git a/include/dt-bindings/clock/mt8173-clk.h > b/include/dt-bindings/clock/mt8173-clk.h index 4ad76ed..7230c38 100644 > --- a/include/dt-bindings/clock/mt8173-clk.h > +++ b/include/dt-bindings/clock/mt8173-clk.h > @@ -18,7 +18,6 @@ > /* TOPCKGEN */ > > #define CLK_TOP_CLKPH_MCK_O 1 > -#define CLK_TOP_DPI 2 > #define CLK_TOP_USB_SYSPLL_125M 3 > #define CLK_TOP_HDMITX_DIG_CTS 4 > #define CLK_TOP_ARMCA7PLL_754M 5
Hi Stephen, Could you help to apply this patch into 4.2? Best regards, James On Wed, 2015-07-29 at 09:05 +0200, Heiko Stübner wrote: > Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao: > > The dpi_ck clock can be removed because it not actually used > > in topckgen and subsystems. > > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > From our past discussions this change looks about right, and should still > become _part of 4.2_, to not have the CLK_TOP_DPI become part of the > devicetree CLK_TOP_DPI. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > --- > > drivers/clk/mediatek/clk-mt8173.c | 1 - > > include/dt-bindings/clock/mt8173-clk.h | 1 - > > 2 files changed, 2 deletions(-) > > > > diff --git a/drivers/clk/mediatek/clk-mt8173.c > > b/drivers/clk/mediatek/clk-mt8173.c index 4b9e04c..4486f8f 100644 > > --- a/drivers/clk/mediatek/clk-mt8173.c > > +++ b/drivers/clk/mediatek/clk-mt8173.c > > @@ -26,7 +26,6 @@ static DEFINE_SPINLOCK(mt8173_clk_lock); > > > > static const struct mtk_fixed_factor root_clk_alias[] __initconst = { > > FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1), > > - FACTOR(CLK_TOP_DPI, "dpi_ck", "clk_null", 1, 1), > > FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1), > > FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1), > > }; > > diff --git a/include/dt-bindings/clock/mt8173-clk.h > > b/include/dt-bindings/clock/mt8173-clk.h index 4ad76ed..7230c38 100644 > > --- a/include/dt-bindings/clock/mt8173-clk.h > > +++ b/include/dt-bindings/clock/mt8173-clk.h > > @@ -18,7 +18,6 @@ > > /* TOPCKGEN */ > > > > #define CLK_TOP_CLKPH_MCK_O 1 > > -#define CLK_TOP_DPI 2 > > #define CLK_TOP_USB_SYSPLL_125M 3 > > #define CLK_TOP_HDMITX_DIG_CTS 4 > > #define CLK_TOP_ARMCA7PLL_754M 5 >
On 07/29, James Liao wrote: > Hi Stephen, > > Could you help to apply this patch into 4.2? > > > Best regards, > > James > > On Wed, 2015-07-29 at 09:05 +0200, Heiko Stübner wrote: > > Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao: > > > The dpi_ck clock can be removed because it not actually used > > > in topckgen and subsystems. > > > > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > > > From our past discussions this change looks about right, and should still > > become _part of 4.2_, to not have the CLK_TOP_DPI become part of the > > devicetree CLK_TOP_DPI. Did you mean ABI? > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > Is it being used in DT right now and causing regressions on v4.2-rcX? Sorry, I'm trying to understand why this patch matters for the 4.2 release.
Am Donnerstag, 30. Juli 2015, 10:36:43 schrieb Stephen Boyd: > On 07/29, James Liao wrote: > > Hi Stephen, > > > > Could you help to apply this patch into 4.2? > > > > > > Best regards, > > > > James > > > > On Wed, 2015-07-29 at 09:05 +0200, Heiko Stübner wrote: > > > Am Mittwoch, 29. Juli 2015, 14:52:25 schrieb James Liao: > > > > The dpi_ck clock can be removed because it not actually used > > > > in topckgen and subsystems. > > > > > > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > > > > > From our past discussions this change looks about right, and should > > > still > > > become _part of 4.2_, to not have the CLK_TOP_DPI become part of the > > > devicetree CLK_TOP_DPI. > > Did you mean ABI? yep, sorry > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > Is it being used in DT right now and causing regressions on > v4.2-rcX? Sorry, I'm trying to understand why this patch matters > for the 4.2 release. it's not been used in an actual devicetree file, but as far as I understand it, the dt-binding headers themself are also part of the ABI. And it is new in 4.2, so has not been part of an official release yet. The reason for the removal from what I understand is that the removed clock is not documented at all (it's source, what it does), which got it the "clk_null" parent in the first place. Heiko
On 07/30/2015 11:04 AM, Heiko Stübner wrote: > Am Donnerstag, 30. Juli 2015, 10:36:43 schrieb Stephen Boyd: > >> Is it being used in DT right now and causing regressions on >> v4.2-rcX? Sorry, I'm trying to understand why this patch matters >> for the 4.2 release. > it's not been used in an actual devicetree file, but as far as I understand it, > the dt-binding headers themself are also part of the ABI. > > And it is new in 4.2, so has not been part of an official release yet. > > The reason for the removal from what I understand is that the removed clock is > not documented at all (it's source, what it does), which got it the "clk_null" > parent in the first place. > > Right, so my understanding of the DT ABI thing is that newer kernels should keep working with older DTs. If there isn't any DT using the binding, then we don't have a problem because the only thing that could happen would be a newer DT working with an older kernel, which doesn't make any sense from a backwards incompatible standpoint. If you feel strongly that some sort of DT ABI rule would be broken and you want to make sure that doesn't happen I guess we can queue this up to be sent off to Linus, but if you aren't worried (and I'm obviously not worried) then I'd prefer we just queue it up for 4.3.
Am Donnerstag, 30. Juli 2015, 12:42:44 schrieb Stephen Boyd: > On 07/30/2015 11:04 AM, Heiko Stübner wrote: > > Am Donnerstag, 30. Juli 2015, 10:36:43 schrieb Stephen Boyd: > >> Is it being used in DT right now and causing regressions on > >> v4.2-rcX? Sorry, I'm trying to understand why this patch matters > >> for the 4.2 release. > > > > it's not been used in an actual devicetree file, but as far as I > > understand it, the dt-binding headers themself are also part of the ABI. > > > > And it is new in 4.2, so has not been part of an official release yet. > > > > The reason for the removal from what I understand is that the removed > > clock is not documented at all (it's source, what it does), which got it > > the "clk_null" parent in the first place. > > Right, so my understanding of the DT ABI thing is that newer kernels > should keep working with older DTs. If there isn't any DT using the > binding, then we don't have a problem because the only thing that could > happen would be a newer DT working with an older kernel, which doesn't > make any sense from a backwards incompatible standpoint. > > If you feel strongly that some sort of DT ABI rule would be broken and > you want to make sure that doesn't happen I guess we can queue this up > to be sent off to Linus, but if you aren't worried (and I'm obviously > not worried) then I'd prefer we just queue it up for 4.3. I don't feel strongly, it was only based on what I remember about all the dt- ABI talk :-) . Aka if you're ok with it simply going into 4.3 that should be ok too from my pov.
diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c index 4b9e04c..4486f8f 100644 --- a/drivers/clk/mediatek/clk-mt8173.c +++ b/drivers/clk/mediatek/clk-mt8173.c @@ -26,7 +26,6 @@ static DEFINE_SPINLOCK(mt8173_clk_lock); static const struct mtk_fixed_factor root_clk_alias[] __initconst = { FACTOR(CLK_TOP_CLKPH_MCK_O, "clkph_mck_o", "clk_null", 1, 1), - FACTOR(CLK_TOP_DPI, "dpi_ck", "clk_null", 1, 1), FACTOR(CLK_TOP_USB_SYSPLL_125M, "usb_syspll_125m", "clk_null", 1, 1), FACTOR(CLK_TOP_HDMITX_DIG_CTS, "hdmitx_dig_cts", "clk_null", 1, 1), }; diff --git a/include/dt-bindings/clock/mt8173-clk.h b/include/dt-bindings/clock/mt8173-clk.h index 4ad76ed..7230c38 100644 --- a/include/dt-bindings/clock/mt8173-clk.h +++ b/include/dt-bindings/clock/mt8173-clk.h @@ -18,7 +18,6 @@ /* TOPCKGEN */ #define CLK_TOP_CLKPH_MCK_O 1 -#define CLK_TOP_DPI 2 #define CLK_TOP_USB_SYSPLL_125M 3 #define CLK_TOP_HDMITX_DIG_CTS 4 #define CLK_TOP_ARMCA7PLL_754M 5
The dpi_ck clock can be removed because it not actually used in topckgen and subsystems. Signed-off-by: James Liao <jamesjj.liao@mediatek.com> --- drivers/clk/mediatek/clk-mt8173.c | 1 - include/dt-bindings/clock/mt8173-clk.h | 1 - 2 files changed, 2 deletions(-)