diff mbox

[v2,3/6] ARM: dts: apq8064-ifc6410: add notify led support.

Message ID 1439903409-20233-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Srinivas Kandagatla Aug. 18, 2015, 1:10 p.m. UTC 
This patch adds notify led support on IFC6410, whose trigger can be
configured from userspace.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Stephen Boyd Aug. 25, 2015, 9:36 p.m. UTC | #1 
On 08/18/2015 06:10 AM, Srinivas Kandagatla wrote:
> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> index b1f9ddb..08daafe 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> @@ -221,6 +221,18 @@
>   			status = "okay";
>   		};
>   
> +		leds {
> +			compatible = "gpio-leds";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&notify_led>;
> +
> +			led@1 {
> +				label = "apq8064:green:user1";
> +				gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>;
> +				default-state = "on";
> +			};
> +		};

Wrong place. Should be in root, not soc node.
Srinivas Kandagatla Sept. 3, 2015, 3:49 p.m. UTC | #2 
On 25/08/15 22:36, Stephen Boyd wrote:
> On 08/18/2015 06:10 AM, Srinivas Kandagatla wrote:
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> index b1f9ddb..08daafe 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> @@ -221,6 +221,18 @@
>>               status = "okay";
>>           };
>> +        leds {
>> +            compatible = "gpio-leds";
>> +            pinctrl-names = "default";
>> +            pinctrl-0 = <&notify_led>;
>> +
>> +            led@1 {
>> +                label = "apq8064:green:user1";
>> +                gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>;
>> +                default-state = "on";
>> +            };
>> +        };
>
> Wrong place. Should be in root, not soc node.
yep, Will move it to the root.
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
index b1f9ddb..08daafe 100644
--- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
@@ -221,6 +221,18 @@ 
 			status = "okay";
 		};
 
+		leds {
+			compatible = "gpio-leds";
+			pinctrl-names = "default";
+			pinctrl-0 = <&notify_led>;
+
+			led@1 {
+				label = "apq8064:green:user1";
+				gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>;
+				default-state = "on";
+			};
+		};
+
 		qcom,ssbi@500000 {
 			pmic@0 {
 				gpio@150 {
@@ -232,6 +244,15 @@ 
 							power-source = <PM8921_GPIO_S4>;
 						};
 					};
+
+					notify_led: nled {
+						pios {
+							pins = "gpio18";
+							function = "normal";
+							bias-disable;
+							power-source = <PM8921_GPIO_S4>;
+						};
+					};
 				};
 			};
 		};