| Message ID | 1440524009-5359-3-git-send-email-Suravee.Suthikulpanit@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wednesday, August 26, 2015 12:33:27 AM Suravee Suthikulpanit wrote: > The original name of acpi_check_dma() function does not clearly tell what > exactly it is checking. Also, returning two boolean values (one to indicate > device is DMA capability, and the other to inidicate device coherency > attribute) can be confusing. > > So, in order to simplify the function, this patch renames acpi_check_dma() > to acpi_check_dma_coherency() to clearly indicate the purpose of this > function, and only returns an integer where -1 means DMA not supported, > 1 means coherent DMA, and 0 means non-coherent DMA. > > Also, this patch moves the function into drivers/acpi/scan.c since > it is easier to follow the logic in the acpi_init_coherency() in the > same file here. > > Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> > CC: Bjorn Helgaas <bhelgaas@google.com> > CC: Catalin Marinas <catalin.marinas@arm.com> > CC: Rob Herring <robh+dt@kernel.org> > CC: Will Deacon <will.deacon@arm.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> > --- > drivers/acpi/acpi_platform.c | 7 ++++++- > drivers/acpi/glue.c | 5 +++-- > drivers/acpi/scan.c | 39 +++++++++++++++++++++++++++++++++++++++ > drivers/base/property.c | 8 ++++++-- > include/acpi/acpi_bus.h | 36 ++---------------------------------- > include/linux/acpi.h | 4 ++-- > 6 files changed, 58 insertions(+), 41 deletions(-) > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > index 06a67d5..2261e85 100644 > --- a/drivers/acpi/acpi_platform.c > +++ b/drivers/acpi/acpi_platform.c > @@ -103,7 +103,12 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) > pdevinfo.res = resources; > pdevinfo.num_res = count; > pdevinfo.fwnode = acpi_fwnode_handle(adev); > - pdevinfo.dma_mask = acpi_check_dma(adev, NULL) ? DMA_BIT_MASK(32) : 0; > + > + if (-1 != acpi_check_dma_coherency(adev)) > + pdevinfo.dma_mask = DMA_BIT_MASK(32); > + else > + pdevinfo.dma_mask = 0; > + > pdev = platform_device_register_full(&pdevinfo); > if (IS_ERR(pdev)) > dev_err(&adev->dev, "platform device creation failed: %ld\n", > diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c > index b9657af..55cf916 100644 > --- a/drivers/acpi/glue.c > +++ b/drivers/acpi/glue.c > @@ -168,7 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) > struct list_head *physnode_list; > unsigned int node_id; > int retval = -EINVAL; > - bool coherent; > + int coherent; enum, anyone? With clearly defined values? > > if (has_acpi_companion(dev)) { > if (acpi_dev) { > @@ -225,7 +225,8 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) > if (!has_acpi_companion(dev)) > ACPI_COMPANION_SET(dev, acpi_dev); > > - if (acpi_check_dma(acpi_dev, &coherent)) > + coherent = acpi_check_dma_coherency(acpi_dev); > + if (coherent != -1) Like here I'm not sure why -1 is special? > arch_setup_dma_ops(dev, 0, 0, NULL, coherent); > > acpi_physnode_link_name(physical_node_name, node_id); Thanks, Rafael
Hi Rafael, On 8/26/15 06:48, Rafael J. Wysocki wrote: >[...] > On Wednesday, August 26, 2015 12:33:27 AM Suravee Suthikulpanit wrote: >> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c >> index b9657af..55cf916 100644 >> --- a/drivers/acpi/glue.c >> +++ b/drivers/acpi/glue.c >> @@ -168,7 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) >> struct list_head *physnode_list; >> unsigned int node_id; >> int retval = -EINVAL; >> - bool coherent; >> + int coherent; > > enum, anyone? With clearly defined values? Originally I had defined enum acpi_dma_coherency { ACPI_DMA_NON_COHERENT, ACPI_DMA_COHERENT, APCI_DMA_NOT_SUPPORTED = -1, }; Although, this would need to be defined in the include/linux/acpi.h, and will be used also for #ifndef CONFIG_ACPI code to return errors. I was not sure if this would be too much. If this is preferred, I'll add this back in. >> >> if (has_acpi_companion(dev)) { >> if (acpi_dev) { >> @@ -225,7 +225,8 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) >> if (!has_acpi_companion(dev)) >> ACPI_COMPANION_SET(dev, acpi_dev); >> >> - if (acpi_check_dma(acpi_dev, &coherent)) >> + coherent = acpi_check_dma_coherency(acpi_dev); >> + if (coherent != -1) > > Like here I'm not sure why -1 is special? It's just another value to communicate that DMA is not supported. :) Thanks, Suravee > >> arch_setup_dma_ops(dev, 0, 0, NULL, coherent); >> >> acpi_physnode_link_name(physical_node_name, node_id); > > Thanks, > Rafael >
On Wednesday, August 26, 2015 09:00:23 AM Suravee Suthikulpanit wrote: > Hi Rafael, > > On 8/26/15 06:48, Rafael J. Wysocki wrote: > > >[...] > > On Wednesday, August 26, 2015 12:33:27 AM Suravee Suthikulpanit wrote: > >> diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c > >> index b9657af..55cf916 100644 > >> --- a/drivers/acpi/glue.c > >> +++ b/drivers/acpi/glue.c > >> @@ -168,7 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) > >> struct list_head *physnode_list; > >> unsigned int node_id; > >> int retval = -EINVAL; > >> - bool coherent; > >> + int coherent; > > > > enum, anyone? With clearly defined values? > > Originally I had defined > > enum acpi_dma_coherency { > ACPI_DMA_NON_COHERENT, > ACPI_DMA_COHERENT, > APCI_DMA_NOT_SUPPORTED = -1, > }; > > Although, this would need to be defined in the include/linux/acpi.h, and > will be used also for #ifndef CONFIG_ACPI code to return errors. I was > not sure if this would be too much. If this is preferred, I'll add this > back in. > > >> > >> if (has_acpi_companion(dev)) { > >> if (acpi_dev) { > >> @@ -225,7 +225,8 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) > >> if (!has_acpi_companion(dev)) > >> ACPI_COMPANION_SET(dev, acpi_dev); > >> > >> - if (acpi_check_dma(acpi_dev, &coherent)) > >> + coherent = acpi_check_dma_coherency(acpi_dev); > >> + if (coherent != -1) > > > > Like here I'm not sure why -1 is special? > > It's just another value to communicate that DMA is not supported. :) OK So maybe use 0/1 for the coherence thing and a proper error code (-ENOTSUPP seems to be a good candidate) for the "no DMA" case? Then, if you rename the local variable to something like "ret", it will be slightly less confusing. And instead of checking against a specific negative value, you can simply use "if (stuff < 0)" or "if (stuff >= 0)" to check whether or not it is supported at all. Thanks, Rafael
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index 06a67d5..2261e85 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c @@ -103,7 +103,12 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) pdevinfo.res = resources; pdevinfo.num_res = count; pdevinfo.fwnode = acpi_fwnode_handle(adev); - pdevinfo.dma_mask = acpi_check_dma(adev, NULL) ? DMA_BIT_MASK(32) : 0; + + if (-1 != acpi_check_dma_coherency(adev)) + pdevinfo.dma_mask = DMA_BIT_MASK(32); + else + pdevinfo.dma_mask = 0; + pdev = platform_device_register_full(&pdevinfo); if (IS_ERR(pdev)) dev_err(&adev->dev, "platform device creation failed: %ld\n", diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index b9657af..55cf916 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c @@ -168,7 +168,7 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) struct list_head *physnode_list; unsigned int node_id; int retval = -EINVAL; - bool coherent; + int coherent; if (has_acpi_companion(dev)) { if (acpi_dev) { @@ -225,7 +225,8 @@ int acpi_bind_one(struct device *dev, struct acpi_device *acpi_dev) if (!has_acpi_companion(dev)) ACPI_COMPANION_SET(dev, acpi_dev); - if (acpi_check_dma(acpi_dev, &coherent)) + coherent = acpi_check_dma_coherency(acpi_dev); + if (coherent != -1) arch_setup_dma_ops(dev, 0, 0, NULL, coherent); acpi_physnode_link_name(physical_node_name, node_id); diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index ec25635..299a825 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -2182,6 +2182,45 @@ void acpi_free_pnp_ids(struct acpi_device_pnp *pnp) kfree(pnp->unique_id); } +/** + * acpi_check_dma_coherency - Check DMA coherency for the specified device. + * @adev: The pointer to acpi device to check coherency attribute + * + * Return -1 if DMA is not supported. Otherwise, return 1 if the + * device support coherent DMA, or 0 for non-coherent DMA. + */ +int acpi_check_dma_coherency(struct acpi_device *adev) +{ + int ret = -1; + + if (!adev) + return ret; + + /** + * Currently, we only support _CCA=1 (i.e. coherent_dma=1) + * This should be equivalent to specifying dma-coherent for + * a device in OF. + * + * For the case when _CCA=0 (i.e. coherent_dma=0 && cca_seen=1), + * we have two choices: + * 1. Do not support and disable DMA. + * 2. Support but rely on arch-specific cache maintenance for + * non-coherenje DMA operations. + * Currently, we implement case 2 above. + * + * For the case when _CCA is missing (i.e. cca_seen=0) and + * platform specifies ACPI_CCA_REQUIRED, we do not support DMA, + * and fallback to arch-specific default handling. + * + * See acpi_init_coherency() for more info. + */ + if (!adev->flags.cca_seen && IS_ENABLED(CONFIG_ACPI_CCA_REQUIRED)) + return ret; + + return adev->flags.coherent_dma; +} +EXPORT_SYMBOL_GPL(acpi_check_dma_coherency); + static void acpi_init_coherency(struct acpi_device *adev) { unsigned long long cca = 0; diff --git a/drivers/base/property.c b/drivers/base/property.c index f3f6d16..643b0fb 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -527,8 +527,12 @@ bool device_dma_is_coherent(struct device *dev) if (IS_ENABLED(CONFIG_OF) && dev->of_node) coherent = of_dma_is_coherent(dev->of_node); - else - acpi_check_dma(ACPI_COMPANION(dev), &coherent); + else { + int ac = acpi_check_dma_coherency(ACPI_COMPANION(dev)); + + if (ac != -1) + coherent = ac; + } return coherent; } diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 7ecb8e4..baf43ea 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -382,40 +382,6 @@ struct acpi_device { void (*remove)(struct acpi_device *); }; -static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent) -{ - bool ret = false; - - if (!adev) - return ret; - - /** - * Currently, we only support _CCA=1 (i.e. coherent_dma=1) - * This should be equivalent to specifyig dma-coherent for - * a device in OF. - * - * For the case when _CCA=0 (i.e. coherent_dma=0 && cca_seen=1), - * There are two cases: - * case 1. Do not support and disable DMA. - * case 2. Support but rely on arch-specific cache maintenance for - * non-coherence DMA operations. - * Currently, we implement case 2 above. - * - * For the case when _CCA is missing (i.e. cca_seen=0) and - * platform specifies ACPI_CCA_REQUIRED, we do not support DMA, - * and fallback to arch-specific default handling. - * - * See acpi_init_coherency() for more info. - */ - if (adev->flags.coherent_dma || - (adev->flags.cca_seen && IS_ENABLED(CONFIG_ARM64))) { - ret = true; - if (coherent) - *coherent = adev->flags.coherent_dma; - } - return ret; -} - static inline bool is_acpi_node(struct fwnode_handle *fwnode) { return fwnode && fwnode->type == FWNODE_ACPI; @@ -640,6 +606,8 @@ static inline bool acpi_device_can_poweroff(struct acpi_device *adev) return adev->power.states[ACPI_STATE_D3_COLD].flags.valid; } +int acpi_check_dma_coherency(struct acpi_device *adev); + #else /* CONFIG_ACPI */ static inline int register_acpi_bus_type(void *bus) { return 0; } diff --git a/include/linux/acpi.h b/include/linux/acpi.h index d2445fa..530d2fa 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -562,9 +562,9 @@ static inline int acpi_device_modalias(struct device *dev, return -ENODEV; } -static inline bool acpi_check_dma(struct acpi_device *adev, bool *coherent) +static inline int acpi_check_dma_coherency(struct acpi_device *adev) { - return false; + return -1; } #define ACPI_PTR(_ptr) (NULL)
The original name of acpi_check_dma() function does not clearly tell what exactly it is checking. Also, returning two boolean values (one to indicate device is DMA capability, and the other to inidicate device coherency attribute) can be confusing. So, in order to simplify the function, this patch renames acpi_check_dma() to acpi_check_dma_coherency() to clearly indicate the purpose of this function, and only returns an integer where -1 means DMA not supported, 1 means coherent DMA, and 0 means non-coherent DMA. Also, this patch moves the function into drivers/acpi/scan.c since it is easier to follow the logic in the acpi_init_coherency() in the same file here. Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> CC: Bjorn Helgaas <bhelgaas@google.com> CC: Catalin Marinas <catalin.marinas@arm.com> CC: Rob Herring <robh+dt@kernel.org> CC: Will Deacon <will.deacon@arm.com> CC: Rafael J. Wysocki <rjw@rjwysocki.net> --- drivers/acpi/acpi_platform.c | 7 ++++++- drivers/acpi/glue.c | 5 +++-- drivers/acpi/scan.c | 39 +++++++++++++++++++++++++++++++++++++++ drivers/base/property.c | 8 ++++++-- include/acpi/acpi_bus.h | 36 ++---------------------------------- include/linux/acpi.h | 4 ++-- 6 files changed, 58 insertions(+), 41 deletions(-)