| Message ID | 1440740808-15004-3-git-send-email-zhengxing@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Am Freitag, 28. August 2015, 13:46:47 schrieb Xing Zheng: > Many parts of pinctrl rk3036 are similar to rk2928's. > > Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> > --- > > Changes in v1: None > > drivers/pinctrl/pinctrl-rockchip.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) please also add the new "rockchip,rk3036-pinctrl" compatible to Documentation/devicetree/pinctrl/rockchip,pinctrl.txt I've checked the values against the rk3036 TRM and everything seems to fit, so with the missing compatible added to the binding you can add my Reviewed-by: Heiko Stuebner <heiko@sntech.de> Heiko
On Thu, Aug 27, 2015 at 10:46 PM, Xing Zheng <zhengxing@rock-chips.com> wrote: > Many parts of pinctrl rk3036 are similar to rk2928's. > > Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> Patch applied with Heiko's ACK, and THANKS to Rockchip and Xing for working in the open community with this nowadays, way to go! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index cc2843a..d06631d 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -2042,6 +2042,21 @@ static struct rockchip_pin_ctrl rk2928_pin_ctrl = { .pull_calc_reg = rk2928_calc_pull_reg_and_bit, }; +static struct rockchip_pin_bank rk3036_pin_banks[] = { + PIN_BANK(0, 32, "gpio0"), + PIN_BANK(1, 32, "gpio1"), + PIN_BANK(2, 32, "gpio2"), +}; + +static struct rockchip_pin_ctrl rk3036_pin_ctrl = { + .pin_banks = rk3036_pin_banks, + .nr_banks = ARRAY_SIZE(rk3036_pin_banks), + .label = "RK3036-GPIO", + .type = RK2928, + .grf_mux_offset = 0xa8, + .pull_calc_reg = rk2928_calc_pull_reg_and_bit, +}; + static struct rockchip_pin_bank rk3066a_pin_banks[] = { PIN_BANK(0, 32, "gpio0"), PIN_BANK(1, 32, "gpio1"), @@ -2160,6 +2175,8 @@ static struct rockchip_pin_ctrl rk3368_pin_ctrl = { static const struct of_device_id rockchip_pinctrl_dt_match[] = { { .compatible = "rockchip,rk2928-pinctrl", .data = (void *)&rk2928_pin_ctrl }, + { .compatible = "rockchip,rk3036-pinctrl", + .data = (void *)&rk3036_pin_ctrl }, { .compatible = "rockchip,rk3066a-pinctrl", .data = (void *)&rk3066a_pin_ctrl }, { .compatible = "rockchip,rk3066b-pinctrl",
Many parts of pinctrl rk3036 are similar to rk2928's. Signed-off-by: Xing Zheng <zhengxing@rock-chips.com> --- Changes in v1: None drivers/pinctrl/pinctrl-rockchip.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)