| Message ID | 1442968663-31843-8-git-send-email-ard.biesheuvel@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ard, On 23/09/15 01:37, Ard Biesheuvel wrote: > This relaxes the kernel Image placement requirements, so that it > may be placed at any 2 MB aligned offset in physical memory. > > This is accomplished by ignoring PHYS_OFFSET when installing > memblocks, and accounting for the apparent virtual offset of > the kernel Image (in addition to the 64 MB that it is moved > below PAGE_OFFSET). As a result, virtual address references > below PAGE_OFFSET are correctly mapped onto physical references > into the kernel Image regardless of where it sits in memory. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> [SNIP] > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 4a1c9d0769f2..675757c01eff 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -21,6 +21,7 @@ > #include <linux/kernel.h> > #include <linux/errno.h> > #include <linux/init.h> > +#include <linux/initrd.h> > #include <linux/libfdt.h> > #include <linux/mman.h> > #include <linux/nodemask.h> > @@ -432,11 +433,34 @@ static void __init bootstrap_linear_mapping(unsigned long va_offset) > static void __init map_mem(void) > { > struct memblock_region *reg; > + u64 new_memstart_addr; > + u64 new_va_offset; > > - bootstrap_linear_mapping(KIMAGE_OFFSET); > + /* > + * Select a suitable value for the base of physical memory. > + * This should be equal to or below the lowest usable physical > + * memory address, and aligned to PUD/PMD size so that we can map > + * it efficiently. > + */ > + new_memstart_addr = round_down(memblock_start_of_DRAM(), SZ_1G); > + > + /* > + * Calculate the offset between the kernel text mapping that exists > + * outside of the linear mapping, and its mapping in the linear region. > + */ > + new_va_offset = memstart_addr - new_memstart_addr; > + > + bootstrap_linear_mapping(new_va_offset); > + > + kernel_va_offset = new_va_offset; > + > + /* Recalculate virtual addresses of initrd region */ > + if (initrd_start) { > + initrd_start += new_va_offset; > + initrd_end += new_va_offset; > + } This breaks the build for me, with messages like: > arch/arm64/mm/built-in.o: In function `map_mem': > ... arch/arm64/mm/mmu.c:458: undefined reference to `initrd_start' Wrapping the if with: > if (IS_ENABLED(CONFIG_BLK_DEV_INITRD)) Solves the problem for me. Thanks, James > > - kernel_va_offset = KIMAGE_OFFSET; > - memstart_addr -= KIMAGE_OFFSET; > + memstart_addr = new_memstart_addr; > > /* map all the memory banks */ > for_each_memblock(memory, reg) { >
On 14 October 2015 at 12:30, James Morse <james.morse@arm.com> wrote: > Hi Ard, > > On 23/09/15 01:37, Ard Biesheuvel wrote: >> This relaxes the kernel Image placement requirements, so that it >> may be placed at any 2 MB aligned offset in physical memory. >> >> This is accomplished by ignoring PHYS_OFFSET when installing >> memblocks, and accounting for the apparent virtual offset of >> the kernel Image (in addition to the 64 MB that it is moved >> below PAGE_OFFSET). As a result, virtual address references >> below PAGE_OFFSET are correctly mapped onto physical references >> into the kernel Image regardless of where it sits in memory. >> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > [SNIP] > >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index 4a1c9d0769f2..675757c01eff 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -21,6 +21,7 @@ >> #include <linux/kernel.h> >> #include <linux/errno.h> >> #include <linux/init.h> >> +#include <linux/initrd.h> >> #include <linux/libfdt.h> >> #include <linux/mman.h> >> #include <linux/nodemask.h> >> @@ -432,11 +433,34 @@ static void __init bootstrap_linear_mapping(unsigned long va_offset) >> static void __init map_mem(void) >> { >> struct memblock_region *reg; >> + u64 new_memstart_addr; >> + u64 new_va_offset; >> >> - bootstrap_linear_mapping(KIMAGE_OFFSET); >> + /* >> + * Select a suitable value for the base of physical memory. >> + * This should be equal to or below the lowest usable physical >> + * memory address, and aligned to PUD/PMD size so that we can map >> + * it efficiently. >> + */ >> + new_memstart_addr = round_down(memblock_start_of_DRAM(), SZ_1G); >> + >> + /* >> + * Calculate the offset between the kernel text mapping that exists >> + * outside of the linear mapping, and its mapping in the linear region. >> + */ >> + new_va_offset = memstart_addr - new_memstart_addr; >> + >> + bootstrap_linear_mapping(new_va_offset); >> + >> + kernel_va_offset = new_va_offset; >> + >> + /* Recalculate virtual addresses of initrd region */ >> + if (initrd_start) { >> + initrd_start += new_va_offset; >> + initrd_end += new_va_offset; >> + } > > This breaks the build for me, with messages like: >> arch/arm64/mm/built-in.o: In function `map_mem': >> ... arch/arm64/mm/mmu.c:458: undefined reference to `initrd_start' > > Wrapping the if with: >> if (IS_ENABLED(CONFIG_BLK_DEV_INITRD)) > > Solves the problem for me. > > Thank you James I will take this into account when I spin the next version (probably after 16k pages support is merged)
On Wed, Oct 14, 2015 at 02:25:58PM +0100, Ard Biesheuvel wrote: > I will take this into account when I spin the next version (probably > after 16k pages support is merged) I plan to merge 16K pages support in 4.4, waiting for the review to settle and I'll queue them. BTW, have you tested these patches with KVM? We were wondering if the stage 1 hyp mapping gets confused.
On 14 October 2015 at 17:34, Catalin Marinas <catalin.marinas@arm.com> wrote: > On Wed, Oct 14, 2015 at 02:25:58PM +0100, Ard Biesheuvel wrote: >> I will take this into account when I spin the next version (probably >> after 16k pages support is merged) > > I plan to merge 16K pages support in 4.4, waiting for the review to > settle and I'll queue them. > > BTW, have you tested these patches with KVM? We were wondering if the > stage 1 hyp mapping gets confused. > I honestly don't remember, so consider that a 'no'. I will look into it before reposting.
On 14/10/15 17:51, Ard Biesheuvel wrote: > On 14 October 2015 at 17:34, Catalin Marinas <catalin.marinas@arm.com> wrote: >> On Wed, Oct 14, 2015 at 02:25:58PM +0100, Ard Biesheuvel wrote: >>> I will take this into account when I spin the next version (probably >>> after 16k pages support is merged) >> >> I plan to merge 16K pages support in 4.4, waiting for the review to >> settle and I'll queue them. >> >> BTW, have you tested these patches with KVM? We were wondering if the >> stage 1 hyp mapping gets confused. >> > > I honestly don't remember, so consider that a 'no'. I will look into > it before reposting. I still had this set up: Guests with and without this series both boot fine on a host with this series. Thanks, James
diff --git a/Documentation/arm64/booting.txt b/Documentation/arm64/booting.txt index 7d9d3c2286b2..baf207acd6dd 100644 --- a/Documentation/arm64/booting.txt +++ b/Documentation/arm64/booting.txt @@ -112,14 +112,14 @@ Header notes: depending on selected features, and is effectively unbound. The Image must be placed text_offset bytes from a 2MB aligned base -address near the start of usable system RAM and called there. Memory -below that base address is currently unusable by Linux, and therefore it -is strongly recommended that this location is the start of system RAM. -The region between the 2 MB aligned base address and the start of the -image has no special significance to the kernel, and may be used for -other purposes. +address anywhere in usable system RAM and called there. The region +between the 2 MB aligned base address and the start of the image has no +special significance to the kernel, and may be used for other purposes. At least image_size bytes from the start of the image must be free for use by the kernel. +NOTE: versions prior to v4.4 cannot make use of memory below the +physical offset of the Image so it is recommended that the Image be +placed as close as possible to the start of system RAM. Any memory described to the kernel (even that below the start of the image) which is not marked as reserved from the kernel (e.g., with a diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h index bdea5b4c7be9..598661b268cc 100644 --- a/arch/arm64/include/asm/memory.h +++ b/arch/arm64/include/asm/memory.h @@ -121,12 +121,10 @@ extern phys_addr_t memstart_addr; extern u64 kernel_va_offset; /* - * The maximum physical address that the linear direct mapping - * of system RAM can cover. (PAGE_OFFSET can be interpreted as - * a 2's complement signed quantity and negated to derive the - * maximum size of the linear mapping.) + * Allow all memory at the discovery stage. We will clip it later. */ -#define MAX_MEMBLOCK_ADDR ({ memstart_addr - PAGE_OFFSET - 1; }) +#define MIN_MEMBLOCK_ADDR 0 +#define MAX_MEMBLOCK_ADDR U64_MAX /* * PFNs are used to describe any physical page; this means diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index b9390eb1e29f..d3abc3555623 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -35,6 +35,7 @@ #include <linux/efi.h> #include <linux/swiotlb.h> +#include <asm/boot.h> #include <asm/fixmap.h> #include <asm/memory.h> #include <asm/mmu_context.h> @@ -157,9 +158,57 @@ static int __init early_mem(char *p) } early_param("mem", early_mem); +static void enforce_memory_limit(void) +{ + const phys_addr_t kbase = round_down(__pa(_text), MIN_KIMG_ALIGN); + u64 to_remove = memblock_phys_mem_size() - memory_limit; + phys_addr_t max_addr = 0; + struct memblock_region *r; + + if (memory_limit == (phys_addr_t)ULLONG_MAX) + return; + + /* + * The kernel may be high up in physical memory, so try to apply the + * limit below the kernel first, and only let the generic handling + * take over if it turns out we haven't clipped enough memory yet. + */ + for_each_memblock(memory, r) { + if (r->base + r->size > kbase) { + u64 rem = min(to_remove, kbase - r->base); + + max_addr = r->base + rem; + to_remove -= rem; + break; + } + if (to_remove <= r->size) { + max_addr = r->base + to_remove; + to_remove = 0; + break; + } + to_remove -= r->size; + } + + /* truncate both memory and reserved regions */ + memblock_remove_range(&memblock.memory, 0, max_addr); + memblock_remove_range(&memblock.reserved, 0, max_addr); + + if (to_remove) + memblock_enforce_memory_limit(memory_limit); +} + void __init arm64_memblock_init(void) { - memblock_enforce_memory_limit(memory_limit); + /* + * Remove the memory that we will not be able to cover + * with the linear mapping. + */ + const s64 linear_region_size = -(s64)PAGE_OFFSET; + + memblock_remove(round_down(memblock_start_of_DRAM(), SZ_1G) + + linear_region_size, ULLONG_MAX); + + enforce_memory_limit(); /* * Register the kernel text, kernel data, initrd, and initial diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 4a1c9d0769f2..675757c01eff 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -21,6 +21,7 @@ #include <linux/kernel.h> #include <linux/errno.h> #include <linux/init.h> +#include <linux/initrd.h> #include <linux/libfdt.h> #include <linux/mman.h> #include <linux/nodemask.h> @@ -432,11 +433,34 @@ static void __init bootstrap_linear_mapping(unsigned long va_offset) static void __init map_mem(void) { struct memblock_region *reg; + u64 new_memstart_addr; + u64 new_va_offset; - bootstrap_linear_mapping(KIMAGE_OFFSET); + /* + * Select a suitable value for the base of physical memory. + * This should be equal to or below the lowest usable physical + * memory address, and aligned to PUD/PMD size so that we can map + * it efficiently. + */ + new_memstart_addr = round_down(memblock_start_of_DRAM(), SZ_1G); + + /* + * Calculate the offset between the kernel text mapping that exists + * outside of the linear mapping, and its mapping in the linear region. + */ + new_va_offset = memstart_addr - new_memstart_addr; + + bootstrap_linear_mapping(new_va_offset); + + kernel_va_offset = new_va_offset; + + /* Recalculate virtual addresses of initrd region */ + if (initrd_start) { + initrd_start += new_va_offset; + initrd_end += new_va_offset; + } - kernel_va_offset = KIMAGE_OFFSET; - memstart_addr -= KIMAGE_OFFSET; + memstart_addr = new_memstart_addr; /* map all the memory banks */ for_each_memblock(memory, reg) {
This relaxes the kernel Image placement requirements, so that it may be placed at any 2 MB aligned offset in physical memory. This is accomplished by ignoring PHYS_OFFSET when installing memblocks, and accounting for the apparent virtual offset of the kernel Image (in addition to the 64 MB that it is moved below PAGE_OFFSET). As a result, virtual address references below PAGE_OFFSET are correctly mapped onto physical references into the kernel Image regardless of where it sits in memory. Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Documentation/arm64/booting.txt | 12 ++--- arch/arm64/include/asm/memory.h | 8 ++- arch/arm64/mm/init.c | 51 +++++++++++++++++++- arch/arm64/mm/mmu.c | 30 ++++++++++-- 4 files changed, 86 insertions(+), 15 deletions(-)