| Message ID | 1443477401-17238-1-git-send-email-aalonso@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 28, 2015 at 04:56:35PM -0500, Adrian Alonso wrote: > Remove incorrect can2-3v3 fixed regulator, imx7d-sdb doesn't > have a dedicated can2 fixed regulator instead it shares PERI_3V3 > fixed regulator (RT8070ZS) which is enabled by default (hardwired) > from pmic pfuze3000 NVCC_3V3 power rail. @Frank, can you please confirm it? > > Signed-off-by: Adrian Alonso <aalonso@freescale.com> Please stop sending patch to shawn.guo@linaro.org, and shawnguo@kernel.org is good enough. > --- > Changes for V7: New patch in series I do not understand why the patch has to be included in this series. Shawn > > arch/arm/boot/dts/imx7d-sdb.dts | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts > index 8059458..83f0053 100644 > --- a/arch/arm/boot/dts/imx7d-sdb.dts > +++ b/arch/arm/boot/dts/imx7d-sdb.dts > @@ -78,16 +78,7 @@ > enable-active-high; > }; > > - reg_can2_3v3: regulator@2 { > - compatible = "regulator-fixed"; > - reg = <2>; > - regulator-name = "can2-3v3"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > - gpio = <&gpio1 7 GPIO_ACTIVE_LOW>; > - }; > - > - reg_vref_1v8: regulator@3 { > + reg_vref_1v8: regulator@2 { > compatible = "regulator-fixed"; > reg = <3>; > regulator-name = "vref-1v8"; > -- > 2.1.4 >
On Tue, Sep 29, 2015 at 8:56 PM, Shawn Guo <shawnguo@kernel.org> wrote: > On Mon, Sep 28, 2015 at 04:56:35PM -0500, Adrian Alonso wrote: >> Remove incorrect can2-3v3 fixed regulator, imx7d-sdb doesn't >> have a dedicated can2 fixed regulator instead it shares PERI_3V3 >> fixed regulator (RT8070ZS) which is enabled by default (hardwired) >> from pmic pfuze3000 NVCC_3V3 power rail. > > @Frank, can you please confirm it? @Aisheng, Can you confirm it? best regards Frank Li > >> >> Signed-off-by: Adrian Alonso <aalonso@freescale.com> > > Please stop sending patch to shawn.guo@linaro.org, and > shawnguo@kernel.org is good enough. > >> --- >> Changes for V7: New patch in series > > I do not understand why the patch has to be included in this series. > > Shawn > >> >> arch/arm/boot/dts/imx7d-sdb.dts | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts >> index 8059458..83f0053 100644 >> --- a/arch/arm/boot/dts/imx7d-sdb.dts >> +++ b/arch/arm/boot/dts/imx7d-sdb.dts >> @@ -78,16 +78,7 @@ >> enable-active-high; >> }; >> >> - reg_can2_3v3: regulator@2 { >> - compatible = "regulator-fixed"; >> - reg = <2>; >> - regulator-name = "can2-3v3"; >> - regulator-min-microvolt = <3300000>; >> - regulator-max-microvolt = <3300000>; >> - gpio = <&gpio1 7 GPIO_ACTIVE_LOW>; >> - }; >> - >> - reg_vref_1v8: regulator@3 { >> + reg_vref_1v8: regulator@2 { >> compatible = "regulator-fixed"; >> reg = <3>; >> regulator-name = "vref-1v8"; >> -- >> 2.1.4 >>
On Tue, Sep 29, 2015 at 5:56 AM, Adrian Alonso <aalonso@freescale.com> wrote: > Remove incorrect can2-3v3 fixed regulator, imx7d-sdb doesn't > have a dedicated can2 fixed regulator instead it shares PERI_3V3 > fixed regulator (RT8070ZS) which is enabled by default (hardwired) > from pmic pfuze3000 NVCC_3V3 power rail. > > Signed-off-by: Adrian Alonso <aalonso@freescale.com> > --- > Changes for V7: New patch in series > It is a correct regulator here, but i have to admit that it's a bit confusing. Here the regulator is an abstract regulator which is actually used to control CAN transceiver STBY signals, it is introduced by below patch: commit b7c4114b07bbacfe0aee1d04ad1ade9e42309620 Author: Fabio Estevam <fabio.estevam@freescale.com> Date: Mon Jun 10 23:12:57 2013 -0300 can: flexcan: Use a regulator to control the CAN transceiver Instead of using a GPIO to turn on/off the CAN transceiver, it is better to use a regulator as some systems may use a PMIC to power the CAN transceiver. Acked-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> From the commit messages, it should be likely to control the transceiver external suppy, not control signals, but it does do that unproper work currently. Besides the unproperly handling control signals, this solution also can't handle multiple CAN transceiver control signals ways. I was trying to write a common transceiver driver to handling this issue. But get interrupted by a few other FSL official works, will resume soon. I would suggest keep the regulator first until the new solution got in. Regards Dong Aisheng > arch/arm/boot/dts/imx7d-sdb.dts | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts > index 8059458..83f0053 100644 > --- a/arch/arm/boot/dts/imx7d-sdb.dts > +++ b/arch/arm/boot/dts/imx7d-sdb.dts > @@ -78,16 +78,7 @@ > enable-active-high; > }; > > - reg_can2_3v3: regulator@2 { > - compatible = "regulator-fixed"; > - reg = <2>; > - regulator-name = "can2-3v3"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > - gpio = <&gpio1 7 GPIO_ACTIVE_LOW>; > - }; > - > - reg_vref_1v8: regulator@3 { > + reg_vref_1v8: regulator@2 { > compatible = "regulator-fixed"; > reg = <3>; > regulator-name = "vref-1v8"; > -- > 2.1.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 10/13/2015 02:04 PM, Dong Aisheng wrote: > On Tue, Sep 29, 2015 at 5:56 AM, Adrian Alonso <aalonso@freescale.com> wrote: >> Remove incorrect can2-3v3 fixed regulator, imx7d-sdb doesn't >> have a dedicated can2 fixed regulator instead it shares PERI_3V3 >> fixed regulator (RT8070ZS) which is enabled by default (hardwired) >> from pmic pfuze3000 NVCC_3V3 power rail. >> >> Signed-off-by: Adrian Alonso <aalonso@freescale.com> >> --- >> Changes for V7: New patch in series >> > > It is a correct regulator here, but i have to admit that it's a bit confusing. > Here the regulator is an abstract regulator which is actually used to > control CAN > transceiver STBY signals, it is introduced by below patch: > commit b7c4114b07bbacfe0aee1d04ad1ade9e42309620 > Author: Fabio Estevam <fabio.estevam@freescale.com> > Date: Mon Jun 10 23:12:57 2013 -0300 > > can: flexcan: Use a regulator to control the CAN transceiver > > Instead of using a GPIO to turn on/off the CAN transceiver, it is better to > use a regulator as some systems may use a PMIC to power the CAN transceiver. > > Acked-by: Shawn Guo <shawn.guo@linaro.org> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > > From the commit messages, it should be likely to control the > transceiver external suppy, > not control signals, but it does do that unproper work currently. > > Besides the unproperly handling control signals, this solution also can't handle > multiple CAN transceiver control signals ways. You can chain several transceivers together if you need to control more than one GPIO line. > I was trying to write a common transceiver driver to handling this issue. > But get interrupted by a few other FSL official works, will resume soon. Have a look at drivers/phy. > I would suggest keep the regulator first until the new solution got in. Marc
diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts index 8059458..83f0053 100644 --- a/arch/arm/boot/dts/imx7d-sdb.dts +++ b/arch/arm/boot/dts/imx7d-sdb.dts @@ -78,16 +78,7 @@ enable-active-high; }; - reg_can2_3v3: regulator@2 { - compatible = "regulator-fixed"; - reg = <2>; - regulator-name = "can2-3v3"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - gpio = <&gpio1 7 GPIO_ACTIVE_LOW>; - }; - - reg_vref_1v8: regulator@3 { + reg_vref_1v8: regulator@2 { compatible = "regulator-fixed"; reg = <3>; regulator-name = "vref-1v8";
Remove incorrect can2-3v3 fixed regulator, imx7d-sdb doesn't have a dedicated can2 fixed regulator instead it shares PERI_3V3 fixed regulator (RT8070ZS) which is enabled by default (hardwired) from pmic pfuze3000 NVCC_3V3 power rail. Signed-off-by: Adrian Alonso <aalonso@freescale.com> --- Changes for V7: New patch in series arch/arm/boot/dts/imx7d-sdb.dts | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)