From patchwork Wed Oct 7 15:26:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 7346231 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B6B089F302 for ; Wed, 7 Oct 2015 15:29:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF4E7205F5 for ; Wed, 7 Oct 2015 15:29:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09900205F2 for ; Wed, 7 Oct 2015 15:29:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZjqdA-0004qL-4X; Wed, 07 Oct 2015 15:27:48 +0000 Received: from mail-pa0-f49.google.com ([209.85.220.49]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zjqcm-0004al-7b for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2015 15:27:24 +0000 Received: by pacfv12 with SMTP id fv12so24905644pac.2 for ; Wed, 07 Oct 2015 08:27:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=exk85wxx+xwGQnDAd/pcH59fmQKWux/7KmBST+CKAhw=; b=GSuZBFrhrtKtOh5yeejfsDWylIoJxlm8PO/LvTiqvkfpXvyZ7V6VCcbay5lqh7v3nY 5gHzN6UnoTEtU/xccfcXCtnZH/8U7eQ0GAcGBKNphWT9FrpTR0B9/P1EvlN2JhY0ZYtb GzBWH4HpsQsL67ljdcxCxN1wycBil/ZQzAUh8qIL9M14I0SW15Myb3G3rs2HhUkJG373 itRe509KCpODnPBCHT/+B4G3nOMvX6+YD5UNlfKfnsLCM9JzZnjFICGjzGyT82g5FXsL KEv32arGQQ5Ve2fioC/UE0XJS7vlOnVN5wBVuXlqkMQN8nGgFhlbi2dmr3MyXCBH7Sqt CjKg== X-Gm-Message-State: ALoCoQnE69J1GsaJHzsQw5n5ogiGWOqvDQLIuHVIO31tAuAPX6V0JXMFwuL32m0tg9t2yN09K6Da X-Received: by 10.66.120.237 with SMTP id lf13mr1713707pab.25.1444231623539; Wed, 07 Oct 2015 08:27:03 -0700 (PDT) Received: from t430.cg.shawcable.net ([184.64.168.246]) by smtp.gmail.com with ESMTPSA id ja4sm40170570pbb.19.2015.10.07.08.27.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Oct 2015 08:27:03 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 3/6] coresight: adding comments to remove ambiguity Date: Wed, 7 Oct 2015 09:26:40 -0600 Message-Id: <1444231603-26676-4-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1444231603-26676-1-git-send-email-mathieu.poirier@linaro.org> References: <1444231603-26676-1-git-send-email-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151007_082724_309958_0458ECCA X-CRM114-Status: GOOD ( 12.52 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add comment to function coresight_enable_path() to make sure there is no misunderstanding about what the code does. Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 894531d315b8..e25492137d8b 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -240,6 +240,11 @@ static int coresight_enable_path(struct list_head *path) int ret = 0; struct coresight_device *cd; + /* + * At this point we have a full @path, from source to sink. The + * sink is the first entry and the source the last one. Go through + * all the components and enable them one by one. + */ list_for_each_entry(cd, path, path_link) { if (cd == list_first_entry(path, struct coresight_device, path_link)) {