diff mbox

[RFC] ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

Message ID 1445251715-9725-1-git-send-email-alim.akhtar@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alim Akhtar Oct. 19, 2015, 10:48 a.m. UTC
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
be used with defconfig.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
Every time I build exynos_defconfig, I need to manually change RAM_SIZE
to match my ramdisk image size. I am not sure what is the best ramdisk size
might be, but bumping it to 64K might be a reasonable one.

 arch/arm/configs/exynos_defconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Javier Martinez Canillas Oct. 19, 2015, 11:48 a.m. UTC | #1
Hello Alim,

On 10/19/2015 12:48 PM, Alim Akhtar wrote:
> CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
> smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
> be used with defconfig.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---

I agree that 8KiB is too small and that should be bumped, I'm also
not sure what the best size would be but 64KiB sounds reasonable
to me. So for this patch:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

> Every time I build exynos_defconfig, I need to manually change RAM_SIZE
> to match my ramdisk image size. I am not sure what is the best ramdisk size
> might be, but bumping it to 64K might be a reasonable one.
>

In case you are interested, I got some stats by doing grep on the ARM
defconfigs using this [0]. Of course the sizes depends on the platform
but just to have an idea about what sizes are more popular than others.

SIZE	COUNT
1024	17
8192	43
10240	1
16384	20
20000	25
32768	36
65536	15

[0]: http://hastebin.com/buqukimede.bash

Best regards,
Russell King - ARM Linux Oct. 19, 2015, 11:51 a.m. UTC | #2
On Mon, Oct 19, 2015 at 01:48:13PM +0200, Javier Martinez Canillas wrote:
> Hello Alim,
> 
> On 10/19/2015 12:48 PM, Alim Akhtar wrote:
> > CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
> > smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
> > be used with defconfig.
> > 
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> 
> I agree that 8KiB is too small and that should be bumped, I'm also
> not sure what the best size would be but 64KiB sounds reasonable
> to me. So for this patch:

It's _not_ 8KiB or 64KiB.

config BLK_DEV_RAM_SIZE
        int "Default RAM disk size (kbytes)"

It's 8MiB or 64MiB - the value you place here is in units of 1024 bytes.
Alim Akhtar Oct. 19, 2015, 11:53 a.m. UTC | #3
Hi Russell,

On 10/19/2015 05:21 PM, Russell King - ARM Linux wrote:
> On Mon, Oct 19, 2015 at 01:48:13PM +0200, Javier Martinez Canillas wrote:
>> Hello Alim,
>>
>> On 10/19/2015 12:48 PM, Alim Akhtar wrote:
>>> CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
>>> smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
>>> be used with defconfig.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> ---
>>
>> I agree that 8KiB is too small and that should be bumped, I'm also
>> not sure what the best size would be but 64KiB sounds reasonable
>> to me. So for this patch:
>
> It's _not_ 8KiB or 64KiB.
>
> config BLK_DEV_RAM_SIZE
>          int "Default RAM disk size (kbytes)"
>
> It's 8MiB or 64MiB - the value you place here is in units of 1024 bytes.
>
Thanks for correcting, will correct it.
Alim Akhtar Oct. 19, 2015, 11:55 a.m. UTC | #4
Hi Javier,

On 10/19/2015 05:18 PM, Javier Martinez Canillas wrote:
> Hello Alim,
>
> On 10/19/2015 12:48 PM, Alim Akhtar wrote:
>> CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
>> smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
>> be used with defconfig.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>
> I agree that 8KiB is too small and that should be bumped, I'm also
> not sure what the best size would be but 64KiB sounds reasonable
> to me. So for this patch:
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Thanks
>> Every time I build exynos_defconfig, I need to manually change RAM_SIZE
>> to match my ramdisk image size. I am not sure what is the best ramdisk size
>> might be, but bumping it to 64K might be a reasonable one.
>>
>
> In case you are interested, I got some stats by doing grep on the ARM
> defconfigs using this [0]. Of course the sizes depends on the platform
> but just to have an idea about what sizes are more popular than others.
>
> SIZE	COUNT
> 1024	17
> 8192	43
> 10240	1
> 16384	20
> 20000	25
> 32768	36
> 65536	15
>
This is informative.
> [0]: http://hastebin.com/buqukimede.bash
>
> Best regards,
>
Javier Martinez Canillas Oct. 19, 2015, 12:06 p.m. UTC | #5
Hello Russell,

On 10/19/2015 01:51 PM, Russell King - ARM Linux wrote:
> On Mon, Oct 19, 2015 at 01:48:13PM +0200, Javier Martinez Canillas wrote:
>> Hello Alim,
>>
>> On 10/19/2015 12:48 PM, Alim Akhtar wrote:
>>> CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
>>> smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
>>> be used with defconfig.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> ---
>>
>> I agree that 8KiB is too small and that should be bumped, I'm also
>> not sure what the best size would be but 64KiB sounds reasonable
>> to me. So for this patch:
> 
> It's _not_ 8KiB or 64KiB.
> 
> config BLK_DEV_RAM_SIZE
>         int "Default RAM disk size (kbytes)"
> 
> It's 8MiB or 64MiB - the value you place here is in units of 1024 bytes.
> 

Err, right. I got confused by the patch's commit message, sorry about
that and thanks for the clarification.

Best regards,
Arnd Bergmann Oct. 19, 2015, 1:22 p.m. UTC | #6
On Monday 19 October 2015 16:18:35 Alim Akhtar wrote:
> Spam Status: CRM114    
> CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
> smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
> be used with defconfig.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> Every time I build exynos_defconfig, I need to manually change RAM_SIZE
> to match my ramdisk image size. I am not sure what is the best ramdisk size
> might be, but bumping it to 64K might be a reasonable one.

Is there still a reason to use ramdisks these days? If 8MB is not
enough to have a useful initrd, that might mean that everyone else
uses initramfs and you should just do the same thing?

Then we can also remove this option here.

	Arnd
Alim Akhtar Oct. 21, 2015, 4:56 a.m. UTC | #7
Hi Arnd

On 10/19/2015 06:52 PM, Arnd Bergmann wrote:
> On Monday 19 October 2015 16:18:35 Alim Akhtar wrote:
>> Spam Status: CRM114
>> CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the
>> smaller side, lets bump it up to 64K so that a bigger RAM_DISK can
>> be used with defconfig.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> Every time I build exynos_defconfig, I need to manually change RAM_SIZE
>> to match my ramdisk image size. I am not sure what is the best ramdisk size
>> might be, but bumping it to 64K might be a reasonable one.
>
> Is there still a reason to use ramdisks these days? If 8MB is not
> enough to have a useful initrd, that might mean that everyone else
> uses initramfs and you should just do the same thing?
>
There is not specific reason to still use ramdisks, but I feel till we 
remove this config, lets modify it to be used by few like me.
I am ok with either way.
Thanks
> Then we can also remove this option here.
>
> 	Arnd
>
diff mbox

Patch

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 3349713e6c63..e692aaa2cb8c 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -52,7 +52,7 @@  CONFIG_CMA_SIZE_MBYTES=64
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_RAM=y
-CONFIG_BLK_DEV_RAM_SIZE=8192
+CONFIG_BLK_DEV_RAM_SIZE=65536
 CONFIG_SCSI=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y