diff mbox

[1/5] ARM: Keystone: Enable PINCTRL for Keystone ARCH

Message ID 1445377809-12516-1-git-send-email-fcooper@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Franklin Cooper Oct. 20, 2015, 9:50 p.m. UTC
From: Franklin Cooper <fcooper@ti.com>

Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
pinmuxing which requires PINCTRL to be enabled. Therefore, enable
PINCTRL for all Keystone 2 devices.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 arch/arm/mach-keystone/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Santosh Shilimkar Oct. 21, 2015, 1:26 a.m. UTC | #1
On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
> From: Franklin Cooper <fcooper@ti.com>
>
> Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
> pinmuxing which requires PINCTRL to be enabled. Therefore, enable
> PINCTRL for all Keystone 2 devices.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   arch/arm/mach-keystone/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
I would be happy to add this one when I see pin
control data in DTS and its actually going to be
used in upstream kernel. Till then I don't want
to add this one.

Regards,
Santosh
Murali Karicheri Oct. 22, 2015, 2:18 p.m. UTC | #2
On 10/20/2015 09:26 PM, santosh shilimkar wrote:
> On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
>> From: Franklin Cooper <fcooper@ti.com>
>>
>> Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
>> pinmuxing which requires PINCTRL to be enabled. Therefore, enable
>> PINCTRL for all Keystone 2 devices.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>>   arch/arm/mach-keystone/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
> I would be happy to add this one when I see pin
> control data in DTS and its actually going to be
> used in upstream kernel. Till then I don't want
> to add this one.
>
Agree. It is too early to add the defconfig update and should be 
deferred to when the DTS update is made. What if the newer keystone 2 
SoC never end up in the tree?

Murali
> Regards,
> Santosh
>
Murali Karicheri Oct. 22, 2015, 2:20 p.m. UTC | #3
On 10/20/2015 05:50 PM, Franklin S Cooper Jr wrote:
> From: Franklin Cooper <fcooper@ti.com>
>
> Unlike other Keystone 2 devices, newer Keystone 2 SOCs may utilize
> pinmuxing which requires PINCTRL to be enabled. Therefore, enable
> PINCTRL for all Keystone 2 devices.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   arch/arm/mach-keystone/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
> index ea955f6db..7a432ee 100644
> --- a/arch/arm/mach-keystone/Kconfig
> +++ b/arch/arm/mach-keystone/Kconfig
> @@ -11,6 +11,7 @@ config ARCH_KEYSTONE
>   	select ZONE_DMA if ARM_LPAE
>   	select MIGHT_HAVE_PCI
>   	select PCI_DOMAINS if PCI
> +	select PINCTRL
>   	help
>   	  Support for boards based on the Texas Instruments Keystone family of
>   	  SoCs.
>
Have the Newer SoC base port is sent to the list? Please add these along 
with that series, not now.
diff mbox

Patch

diff --git a/arch/arm/mach-keystone/Kconfig b/arch/arm/mach-keystone/Kconfig
index ea955f6db..7a432ee 100644
--- a/arch/arm/mach-keystone/Kconfig
+++ b/arch/arm/mach-keystone/Kconfig
@@ -11,6 +11,7 @@  config ARCH_KEYSTONE
 	select ZONE_DMA if ARM_LPAE
 	select MIGHT_HAVE_PCI
 	select PCI_DOMAINS if PCI
+	select PINCTRL
 	help
 	  Support for boards based on the Texas Instruments Keystone family of
 	  SoCs.