| Message ID | 1445503652-777-3-git-send-email-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Donnerstag, den 22.10.2015, 10:47 +0200 schrieb Sascha Hauer: > devm_kzalloc must be called with the device that is actually probed, > not with cpu_dev which resources are not freed when probe fails. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/cpufreq/imx6q-cpufreq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c > index fabd144..7557d1e 100644 > --- a/drivers/cpufreq/imx6q-cpufreq.c > +++ b/drivers/cpufreq/imx6q-cpufreq.c > @@ -260,7 +260,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) > } > > /* Make imx6_soc_volt array's size same as arm opp number */ > - imx6_soc_volt = devm_kzalloc(cpu_dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL); > + imx6_soc_volt = devm_kzalloc(&pdev->dev, > + sizeof(*imx6_soc_volt) * num, GFP_KERNEL); > if (imx6_soc_volt == NULL) { > ret = -ENOMEM; > goto free_freq_table;
On 22-10-15, 10:47, Sascha Hauer wrote: > devm_kzalloc must be called with the device that is actually probed, > not with cpu_dev which resources are not freed when probe fails. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/cpufreq/imx6q-cpufreq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c > index fabd144..7557d1e 100644 > --- a/drivers/cpufreq/imx6q-cpufreq.c > +++ b/drivers/cpufreq/imx6q-cpufreq.c > @@ -260,7 +260,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) > } > > /* Make imx6_soc_volt array's size same as arm opp number */ > - imx6_soc_volt = devm_kzalloc(cpu_dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL); > + imx6_soc_volt = devm_kzalloc(&pdev->dev, > + sizeof(*imx6_soc_volt) * num, GFP_KERNEL); Please rewrite it as: imx6_soc_volt = devm_kzalloc(&pdev->dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL); checkpatch --strict will warn against this.
diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index fabd144..7557d1e 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -260,7 +260,8 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) } /* Make imx6_soc_volt array's size same as arm opp number */ - imx6_soc_volt = devm_kzalloc(cpu_dev, sizeof(*imx6_soc_volt) * num, GFP_KERNEL); + imx6_soc_volt = devm_kzalloc(&pdev->dev, + sizeof(*imx6_soc_volt) * num, GFP_KERNEL); if (imx6_soc_volt == NULL) { ret = -ENOMEM; goto free_freq_table;
devm_kzalloc must be called with the device that is actually probed, not with cpu_dev which resources are not freed when probe fails. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/cpufreq/imx6q-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)