From patchwork Fri Oct 23 16:50:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 7474001 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 60FC3BEEA4 for ; Fri, 23 Oct 2015 16:53:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 961F0209CA for ; Fri, 23 Oct 2015 16:53:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7524B209C9 for ; Fri, 23 Oct 2015 16:53:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZpfZT-0003TO-7e; Fri, 23 Oct 2015 16:52:03 +0000 Received: from mail-pa0-f48.google.com ([209.85.220.48]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZpfZQ-0003Js-BL for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2015 16:52:00 +0000 Received: by padhk11 with SMTP id hk11so123012200pad.1 for ; Fri, 23 Oct 2015 09:51:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aPwVjoRw8uKPezZEUnj4pFYM3UaIZh+BJhsoTUHB0fU=; b=jo9oPzo/yEcnbyHx/yKe3+VDyYJ1z3wg9u/Lqjh8SBJclPyo7nQUqlwxc/8AhHyHrX nPa81GXzhB1TmgHw1vk/TNRAmZANQwSG1doZdfDxC0woOtT3NGNlcme6OrlndOR+qvbp vQCyb/+tj3oHg3PMWtazJ1fxrqJfknXi8MZcqLF3iImbuckq45+tx8FWTrgpVj5ECpdS v42BANpohRPU+pZxUPQ+mt1ryQnhHaJjBejHnlLYjd2FQ3r+nVJ5UlLMBVlM1JH5+NhP 9yjsaF8GHfbEEWRbqEIfQ2NCRsKJQBmtw/KpZh3VEoF4D7Gr41CuSG6UnceEqO/WzanU CNrQ== X-Gm-Message-State: ALoCoQnoWEkji4GgBYtDPt6eIoBUNWAJXHPVoroVB+oc2IZmgYzv2sqvVCACjeAX3bnsGvIv/Rhh X-Received: by 10.68.228.200 with SMTP id sk8mr6220240pbc.115.1445619099300; Fri, 23 Oct 2015 09:51:39 -0700 (PDT) Received: from t430.cg.shawcable.net ([184.64.168.246]) by smtp.gmail.com with ESMTPSA id fk8sm19942197pab.33.2015.10.23.09.51.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Oct 2015 09:51:38 -0700 (PDT) From: Mathieu Poirier To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] coresight: checking for NULL string in coresight_name_match() Date: Fri, 23 Oct 2015 10:50:50 -0600 Message-Id: <1445619050-13036-1-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151023_095200_445353_B638F047 X-CRM114-Status: GOOD ( 12.04 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tyler.baker@linaro.org, linux-kernel@vger.kernel.org, khilman@kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Connection child names associated to ports can sometimes be NULL, which is the case when booting a system on QEMU or when the Coresight power domain isn't switched on. This patch is adding a check to make sure a NULL string isn't fed to strcmp(), something that avoid crashing the system. Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index e25492137d8b..93738dfbf631 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -548,7 +548,7 @@ static int coresight_name_match(struct device *dev, void *data) to_match = data; i_csdev = to_coresight_device(dev); - if (!strcmp(to_match, dev_name(&i_csdev->dev))) + if (to_match && !strcmp(to_match, dev_name(&i_csdev->dev))) return 1; return 0;