| Message ID | 1446118467-26453-4-git-send-email-nicola@corna.info (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 29/10/15 11:34, Nicola Corna wrote: > This patch adds a i2c_check_quirks helper function to check the quirk flags > of an i2c adapter, in a similar way to i2c_check_functionality. > > Signed-off-by: Nicola Corna <nicola@corna.info> I don't know about everyone else, but I'm finding this particular style of email thread very difficult to follow. Perhaps either: * Start a new thread for each new series version. * label the whole series with a rolling version number rather than doing it on a per patch basis. Would just make it easier to keep track when one reads the thread a while after it started! Jonathan > --- > include/linux/i2c.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 9697002..51028f3 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -617,6 +617,20 @@ static inline int i2c_check_functionality(struct i2c_adapter *adap, u32 func) > return (func & i2c_get_functionality(adap)) == func; > } > > +/** > + * i2c_check_quirks() - Function for checking the quirk flags in an i2c adapter > + * @adap: i2c adapter > + * @quirks: quirk flags > + * > + * Return: true if the adapter has all the specified quirk flags, false if not > + */ > +static inline bool i2c_check_quirks(struct i2c_adapter *adap, u64 quirks) > +{ > + if (!adap->quirks) > + return false; > + return (adap->quirks->flags & quirks) == quirks; > +} > + > /* Return the adapter number for a specific adapter */ > static inline int i2c_adapter_id(struct i2c_adapter *adap) > { >
> I don't know about everyone else, but I'm finding this particular style > of email thread very difficult to follow. Same here. > Perhaps either: > * Start a new thread for each new series version. +1 > * label the whole series with a rolling version number rather than doing it > on a per patch basis. +1 > > Would just make it easier to keep track when one reads the thread a while > after it started! +1 :)
On Thu, Oct 29, 2015 at 12:34:26PM +0100, Nicola Corna wrote: > This patch adds a i2c_check_quirks helper function to check the quirk flags > of an i2c adapter, in a similar way to i2c_check_functionality. > > Signed-off-by: Nicola Corna <nicola@corna.info> Applied to for-next, thanks!
diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 9697002..51028f3 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -617,6 +617,20 @@ static inline int i2c_check_functionality(struct i2c_adapter *adap, u32 func) return (func & i2c_get_functionality(adap)) == func; } +/** + * i2c_check_quirks() - Function for checking the quirk flags in an i2c adapter + * @adap: i2c adapter + * @quirks: quirk flags + * + * Return: true if the adapter has all the specified quirk flags, false if not + */ +static inline bool i2c_check_quirks(struct i2c_adapter *adap, u64 quirks) +{ + if (!adap->quirks) + return false; + return (adap->quirks->flags & quirks) == quirks; +} + /* Return the adapter number for a specific adapter */ static inline int i2c_adapter_id(struct i2c_adapter *adap) {
This patch adds a i2c_check_quirks helper function to check the quirk flags of an i2c adapter, in a similar way to i2c_check_functionality. Signed-off-by: Nicola Corna <nicola@corna.info> --- include/linux/i2c.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)