| Message ID | 1446458641-4447-2-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Alim, On 11/02/2015 11:04 AM, Alim Akhtar wrote: > This patch enables HS200 mode operation on exynos7 based > espresso board. > This also remove _broken-cd_ property as per mmc binding documentation > which say one of the properties between broken-cd and non-removable > should be used. And we already use _non-removable_ as emmc mounted > on board which is a non-removable device. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > index 8ce04a0ec928..7f19b99fc85b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > @@ -405,8 +405,8 @@ > &mmc_0 { > status = "okay"; > num-slots = <1>; > - broken-cd; > cap-mmc-highspeed; > + mmc-hs200-1_8v; > non-removable; > card-detect-delay = <200>; > clock-frequency = <800000000>; > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
Subject - name of the board at the end (not the name of the SoC): arm64: dts: Enable HS200 mode operation on exynos7-espresso 2015-11-02 19:04 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>: > This patch enables HS200 mode operation on exynos7 based > espresso board. > This also remove _broken-cd_ property as per mmc binding documentation s/remove/removes/ > which say one of the properties between broken-cd and non-removable s/say/says/ > should be used. And we already use _non-removable_ as emmc mounted > on board which is a non-removable device. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > index 8ce04a0ec928..7f19b99fc85b 100644 > --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts > @@ -405,8 +405,8 @@ > &mmc_0 { > status = "okay"; > num-slots = <1>; > - broken-cd; > cap-mmc-highspeed; > + mmc-hs200-1_8v; The "mmc-ddr-1_8v" should also be supported but I guess you did not add it on purpose? Best regards, Krzysztof
Hi Krzysztof, On 11/02/2015 05:28 PM, Krzysztof Kozlowski wrote: > Subject - name of the board at the end (not the name of the SoC): > arm64: dts: Enable HS200 mode operation on exynos7-espresso > > 2015-11-02 19:04 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>: >> This patch enables HS200 mode operation on exynos7 based >> espresso board. >> This also remove _broken-cd_ property as per mmc binding documentation > > s/remove/removes/ > >> which say one of the properties between broken-cd and non-removable > > s/say/says/ > >> should be used. And we already use _non-removable_ as emmc mounted >> on board which is a non-removable device. >> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> index 8ce04a0ec928..7f19b99fc85b 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> @@ -405,8 +405,8 @@ >> &mmc_0 { >> status = "okay"; >> num-slots = <1>; >> - broken-cd; >> cap-mmc-highspeed; >> + mmc-hs200-1_8v; > > The "mmc-ddr-1_8v" should also be supported but I guess you did not > add it on purpose? > Well, I have not tested it, that why didn't added. Will check if this works then will add. Thanks for your comments. > Best regards, > Krzysztof >
2015-11-02 21:08 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>: > Hi Krzysztof, > > > On 11/02/2015 05:28 PM, Krzysztof Kozlowski wrote: >> >> Subject - name of the board at the end (not the name of the SoC): >> arm64: dts: Enable HS200 mode operation on exynos7-espresso >> >> 2015-11-02 19:04 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>: >>> >>> This patch enables HS200 mode operation on exynos7 based >>> espresso board. >>> This also remove _broken-cd_ property as per mmc binding documentation >> >> >> s/remove/removes/ >> >>> which say one of the properties between broken-cd and non-removable >> >> >> s/say/says/ >> >>> should be used. And we already use _non-removable_ as emmc mounted >>> on board which is a non-removable device. >>> >>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >>> --- >>> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> index 8ce04a0ec928..7f19b99fc85b 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >>> @@ -405,8 +405,8 @@ >>> &mmc_0 { >>> status = "okay"; >>> num-slots = <1>; >>> - broken-cd; >>> cap-mmc-highspeed; >>> + mmc-hs200-1_8v; >> >> >> The "mmc-ddr-1_8v" should also be supported but I guess you did not >> add it on purpose? >> > Well, I have not tested it, that why didn't added. Will check if this works > then will add. > Thanks for your comments. Right, it would require testing... Just came to my mind. Anyway this is up to you. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts index 8ce04a0ec928..7f19b99fc85b 100644 --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts @@ -405,8 +405,8 @@ &mmc_0 { status = "okay"; num-slots = <1>; - broken-cd; cap-mmc-highspeed; + mmc-hs200-1_8v; non-removable; card-detect-delay = <200>; clock-frequency = <800000000>;
This patch enables HS200 mode operation on exynos7 based espresso board. This also remove _broken-cd_ property as per mmc binding documentation which say one of the properties between broken-cd and non-removable should be used. And we already use _non-removable_ as emmc mounted on board which is a non-removable device. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)