diff mbox

[v2] arm64: defconfig: Enable samsung MFD and related configs

Message ID 1446787654-18306-1-git-send-email-alim.akhtar@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Alim Akhtar Nov. 6, 2015, 5:27 a.m. UTC
Exynos7 based espresso board uses S2MPS15, a multifunction device.
This patch enables S2MPS1X regulator, pmic-clk and rtc drivers utilized by
the same.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
Changes since v1:
* updated the comment message to describe which platfrom uses it.
* enable COMMON_CLK_S2MPS11 which is needed to enable pmic-clk block.

 arch/arm64/configs/defconfig |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Nov. 6, 2015, 5:47 a.m. UTC | #1
2015-11-06 14:27 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>:
> Exynos7 based espresso board uses S2MPS15, a multifunction device.
> This patch enables S2MPS1X regulator, pmic-clk and rtc drivers utilized by
> the same.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> Changes since v1:
> * updated the comment message to describe which platfrom uses it.
> * enable COMMON_CLK_S2MPS11 which is needed to enable pmic-clk block.
>
>  arch/arm64/configs/defconfig |    4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Catalin,

Are you usually taking such arm64 defconfig changes or should they go
through arm-soc?

Best regards,
Krzysztof
Catalin Marinas Nov. 6, 2015, 4:37 p.m. UTC | #2
On Fri, Nov 06, 2015 at 02:47:12PM +0900, Krzysztof Kozlowski wrote:
> 2015-11-06 14:27 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>:
> > Exynos7 based espresso board uses S2MPS15, a multifunction device.
> > This patch enables S2MPS1X regulator, pmic-clk and rtc drivers utilized by
> > the same.
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > Changes since v1:
> > * updated the comment message to describe which platfrom uses it.
> > * enable COMMON_CLK_S2MPS11 which is needed to enable pmic-clk block.
> >
> >  arch/arm64/configs/defconfig |    4 ++++
> >  1 file changed, 4 insertions(+)
> 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Catalin,
> 
> Are you usually taking such arm64 defconfig changes or should they go
> through arm-soc?

Usually arm-soc but I don't mind either way.
Alim Akhtar Feb. 4, 2016, 4:02 a.m. UTC | #3
On 11/06/2015 10:07 PM, Catalin Marinas wrote:
> On Fri, Nov 06, 2015 at 02:47:12PM +0900, Krzysztof Kozlowski wrote:
>> 2015-11-06 14:27 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>:
>>> Exynos7 based espresso board uses S2MPS15, a multifunction device.
>>> This patch enables S2MPS1X regulator, pmic-clk and rtc drivers utilized by
>>> the same.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> ---
>>> Changes since v1:
>>> * updated the comment message to describe which platfrom uses it.
>>> * enable COMMON_CLK_S2MPS11 which is needed to enable pmic-clk block.
>>>
>>>   arch/arm64/configs/defconfig |    4 ++++
>>>   1 file changed, 4 insertions(+)
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Catalin,
>>
>> Are you usually taking such arm64 defconfig changes or should they go
>> through arm-soc?
>
> Usually arm-soc but I don't mind either way.
>
Looks like this patch is not merged...because of this 4.5-rc1 on 
exynos7-esspreso does not boot to user space.
Do I need to resend this patch?

Regards,
Alim
Krzysztof Kozlowski Feb. 5, 2016, 1:36 a.m. UTC | #4
On 04.02.2016 13:02, Alim Akhtar wrote:
> On 11/06/2015 10:07 PM, Catalin Marinas wrote:
>> On Fri, Nov 06, 2015 at 02:47:12PM +0900, Krzysztof Kozlowski wrote:
>>> 2015-11-06 14:27 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>:
>>>> Exynos7 based espresso board uses S2MPS15, a multifunction device.
>>>> This patch enables S2MPS1X regulator, pmic-clk and rtc drivers
>>>> utilized by
>>>> the same.
>>>>
>>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>>> ---
>>>> Changes since v1:
>>>> * updated the comment message to describe which platfrom uses it.
>>>> * enable COMMON_CLK_S2MPS11 which is needed to enable pmic-clk block.
>>>>
>>>>   arch/arm64/configs/defconfig |    4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>
>>> Catalin,
>>>
>>> Are you usually taking such arm64 defconfig changes or should they go
>>> through arm-soc?
>>
>> Usually arm-soc but I don't mind either way.
>>
> Looks like this patch is not merged...because of this 4.5-rc1 on
> exynos7-esspreso does not boot to user space.
> Do I need to resend this patch?

Yes, please resend.
I reviewed it on the list archives (from different email) but for
applying I need to get the patch delivered to my mail box. Unfortunately
you didn't put Samsung SoC guys on recipients list and at the same time
patchwork does not work in company network.

Best regards,
Krzysztof
diff mbox

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 9492fe7edbbc..2e1f815daa2b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -131,9 +131,11 @@  CONFIG_GPIO_XGENE=y
 CONFIG_POWER_RESET_XGENE=y
 CONFIG_POWER_RESET_SYSCON=y
 # CONFIG_HWMON is not set
+CONFIG_MFD_SEC_CORE=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_REGULATOR_QCOM_SMD_RPM=y
+CONFIG_REGULATOR_S2MPS11=y
 CONFIG_FB=y
 CONFIG_FB_ARMCLCD=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
@@ -162,6 +164,7 @@  CONFIG_LEDS_TRIGGERS=y
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_LEDS_TRIGGER_CPU=y
 CONFIG_RTC_CLASS=y
+CONFIG_RTC_DRV_S5M=y
 CONFIG_RTC_DRV_EFI=y
 CONFIG_RTC_DRV_XGENE=y
 CONFIG_DMADEVICES=y
@@ -169,6 +172,7 @@  CONFIG_QCOM_BAM_DMA=y
 CONFIG_VIRTIO_PCI=y
 CONFIG_VIRTIO_BALLOON=y
 CONFIG_VIRTIO_MMIO=y
+CONFIG_COMMON_CLK_S2MPS11=y
 CONFIG_COMMON_CLK_QCOM=y
 CONFIG_MSM_GCC_8916=y
 CONFIG_HWSPINLOCK_QCOM=y