diff mbox

[2/3] ARM: dts: lpc4337-ciaa: enable SCT-PWM

Message ID 1448282225-2635-3-git-send-email-ariel@vanguardiasur.com.ar (mailing list archive)
State New, archived
Headers show

Commit Message

Ariel D'Alessandro Nov. 23, 2015, 12:37 p.m. UTC
Enable the PWM based on the State Configurable Timer (SCT) included in
the LPC4337 SoC of the CIAA-NXP board.

Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
---
 arch/arm/boot/dts/lpc4337-ciaa.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ariel D'Alessandro Nov. 25, 2015, 12:28 p.m. UTC | #1
(+To: Joachim)

El 23/11/15 a las 09:37, Ariel D'Alessandro escribió:
> Enable the PWM based on the State Configurable Timer (SCT) included in
> the LPC4337 SoC of the CIAA-NXP board.
> 
> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
> ---
>  arch/arm/boot/dts/lpc4337-ciaa.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
> index 03bdf77..1a23589 100644
> --- a/arch/arm/boot/dts/lpc4337-ciaa.dts
> +++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
> @@ -170,6 +170,10 @@
>  	pinctrl-0 = <&enet_rmii_pins>;
>  };
>  
> +&sct_pwm {
> +	status = "okay";
> +};
> +
>  &ssp1 {
>  	status = "okay";
>  	pinctrl-names = "default";
>
Joachim Eastwood Dec. 14, 2015, 10:48 p.m. UTC | #2
Hi Ariel,

Sorry for the late reply. I have just started to put together my DT
for 4.5 branch now.

On 25 November 2015 at 13:28, Ariel D'Alessandro
<ariel@vanguardiasur.com.ar> wrote:
> (+To: Joachim)
>
> El 23/11/15 a las 09:37, Ariel D'Alessandro escribió:
>> Enable the PWM based on the State Configurable Timer (SCT) included in
>> the LPC4337 SoC of the CIAA-NXP board.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>> ---
>>  arch/arm/boot/dts/lpc4337-ciaa.dts | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
>> index 03bdf77..1a23589 100644
>> --- a/arch/arm/boot/dts/lpc4337-ciaa.dts
>> +++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
>> @@ -170,6 +170,10 @@
>>       pinctrl-0 = <&enet_rmii_pins>;
>>  };
>>
>> +&sct_pwm {
>> +     status = "okay";
>> +};
>> +

Isn't this a bit useless without any pinmux setup?


regards,
Joachim Eastwood
Ariel D'Alessandro Dec. 16, 2015, 12:55 p.m. UTC | #3
Joachim,

El 14/12/15 a las 19:48, Joachim Eastwood escribió:
> Hi Ariel,
> 
> Sorry for the late reply. I have just started to put together my DT
> for 4.5 branch now.
> 
> On 25 November 2015 at 13:28, Ariel D'Alessandro
> <ariel@vanguardiasur.com.ar> wrote:
>> (+To: Joachim)
>>
>> El 23/11/15 a las 09:37, Ariel D'Alessandro escribió:
>>> Enable the PWM based on the State Configurable Timer (SCT) included in
>>> the LPC4337 SoC of the CIAA-NXP board.
>>>
>>> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>>> ---
>>>  arch/arm/boot/dts/lpc4337-ciaa.dts | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
>>> index 03bdf77..1a23589 100644
>>> --- a/arch/arm/boot/dts/lpc4337-ciaa.dts
>>> +++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
>>> @@ -170,6 +170,10 @@
>>>       pinctrl-0 = <&enet_rmii_pins>;
>>>  };
>>>
>>> +&sct_pwm {
>>> +     status = "okay";
>>> +};
>>> +
> 
> Isn't this a bit useless without any pinmux setup?

Yes, it might be kind of useless. Do you think it shouldn't be enabled then?
Joachim Eastwood Dec. 17, 2015, 10:55 p.m. UTC | #4
On 16 December 2015 at 13:55, Ariel D'Alessandro
<ariel@vanguardiasur.com.ar> wrote:
> Joachim,
>
> El 14/12/15 a las 19:48, Joachim Eastwood escribió:
>> Hi Ariel,
>>
>> Sorry for the late reply. I have just started to put together my DT
>> for 4.5 branch now.
>>
>> On 25 November 2015 at 13:28, Ariel D'Alessandro
>> <ariel@vanguardiasur.com.ar> wrote:
>>> (+To: Joachim)
>>>
>>> El 23/11/15 a las 09:37, Ariel D'Alessandro escribió:
>>>> Enable the PWM based on the State Configurable Timer (SCT) included in
>>>> the LPC4337 SoC of the CIAA-NXP board.
>>>>
>>>> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
>>>> ---
>>>>  arch/arm/boot/dts/lpc4337-ciaa.dts | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
>>>> index 03bdf77..1a23589 100644
>>>> --- a/arch/arm/boot/dts/lpc4337-ciaa.dts
>>>> +++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
>>>> @@ -170,6 +170,10 @@
>>>>       pinctrl-0 = <&enet_rmii_pins>;
>>>>  };
>>>>
>>>> +&sct_pwm {
>>>> +     status = "okay";
>>>> +};
>>>> +
>>
>> Isn't this a bit useless without any pinmux setup?
>
> Yes, it might be kind of useless. Do you think it shouldn't be enabled then?

It would be nice to have a board with sct-pwm enabled. Would it
possible for you to assign a pin to it?


regards,
Joachim Eastwood
diff mbox

Patch

diff --git a/arch/arm/boot/dts/lpc4337-ciaa.dts b/arch/arm/boot/dts/lpc4337-ciaa.dts
index 03bdf77..1a23589 100644
--- a/arch/arm/boot/dts/lpc4337-ciaa.dts
+++ b/arch/arm/boot/dts/lpc4337-ciaa.dts
@@ -170,6 +170,10 @@ 
 	pinctrl-0 = <&enet_rmii_pins>;
 };
 
+&sct_pwm {
+	status = "okay";
+};
+
 &ssp1 {
 	status = "okay";
 	pinctrl-names = "default";