From patchwork Wed Nov 25 16:17:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 7701181 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 937C6BF90C for ; Wed, 25 Nov 2015 16:19:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CE89320859 for ; Wed, 25 Nov 2015 16:19:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F03820842 for ; Wed, 25 Nov 2015 16:19:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a1cle-0003jW-Fy; Wed, 25 Nov 2015 16:18:02 +0000 Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a1cla-0003Zb-Ua for linux-arm-kernel@lists.infradead.org; Wed, 25 Nov 2015 16:17:59 +0000 Received: by pacdm15 with SMTP id dm15so61592738pac.3 for ; Wed, 25 Nov 2015 08:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=jVvsUqlIVFEeXgZUoMaYZq9a6LKgb4WSfJInmKh7fsY=; b=uaYH60kKVHqe4LTQ0huBWHqO8xjet9l3yAFaqGDbk/DvAHzLNTWb2ex3VFRggEvH5v jVwU6tmpGGNdB7v//QM50T2yRgY03nu7OIT3tnZzXxnB1DI9gwrG/1MeeVB3ZLR5vCsW dXDs2R1GjTgcFi2bouuYeRpBB5MVZk/FR1uUSCEEquMYkM6L7c+/clVRiFx30XelrznT C/N2echLerDiow3LZa7sF03qjBNtmCQ+0WeE6SuYPMVgtoEI1CXiB61xYf2lkWBchhUL QNb7aoUIkSeE1Rk8gij0Jk1Z6W/c1u04FxRZ5Na1XqHKWCptjAA21hgP/QaynSmOIX/F hh9A== X-Received: by 10.98.72.152 with SMTP id q24mr32998928pfi.156.1448468257724; Wed, 25 Nov 2015 08:17:37 -0800 (PST) Received: from [172.26.54.208] ([172.26.54.208]) by smtp.gmail.com with ESMTPSA id y83sm21783088pfi.85.2015.11.25.08.17.36 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 Nov 2015 08:17:36 -0800 (PST) Message-ID: <1448468256.24696.5.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: KASAN failures in X-Gene ethernet driver in v4.4-rc2 From: Eric Dumazet To: Mark Rutland Date: Wed, 25 Nov 2015 08:17:36 -0800 In-Reply-To: <20151125155753.GE12434@leverpostej> References: <20151125155753.GE12434@leverpostej> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151125_081759_116326_FF155BC2 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com, isubramanian@apm.com, kchudgar@apm.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2015-11-25 at 15:59 +0000, Mark Rutland wrote: > xgene_enet_start_xmit Please try following trivial fix diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 1adfe7036843..9147a0107c44 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -450,12 +450,12 @@ static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb, return NETDEV_TX_OK; } - pdata->ring_ops->wr_cmd(tx_ring, count); skb_tx_timestamp(skb); pdata->stats.tx_packets++; pdata->stats.tx_bytes += skb->len; + pdata->ring_ops->wr_cmd(tx_ring, count); return NETDEV_TX_OK; }