| Message ID | 1448561293-16431-7-git-send-email-mw@semihalf.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Marcin, On Thu, 26 Nov 2015 19:08:13 +0100, Marcin Wojtas wrote: > The Ethernet controller found in the Armada 38x SoC's family support > TCP/IP checksumming with frame sizes larger than 1600 bytes, however > only on port 0. > > This commit enables it by setting 'tx-csum-limit' to 9800B in > 'ethernet@70000' node. > > Signed-off-by: Marcin Wojtas <mw@semihalf.com> > Cc: <stable@vger.kernel.org> # v3.18+ This and the previous patch is not a fix, and has no business going in stable. It is enabling a better functionality, but it is clearly not a fix. Thomas
Thomas, 2015-11-26 19:33 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Marcin, > > On Thu, 26 Nov 2015 19:08:13 +0100, Marcin Wojtas wrote: >> The Ethernet controller found in the Armada 38x SoC's family support >> TCP/IP checksumming with frame sizes larger than 1600 bytes, however >> only on port 0. >> >> This commit enables it by setting 'tx-csum-limit' to 9800B in >> 'ethernet@70000' node. >> >> Signed-off-by: Marcin Wojtas <mw@semihalf.com> >> Cc: <stable@vger.kernel.org> # v3.18+ > > This and the previous patch is not a fix, and has no business going in > stable. It is enabling a better functionality, but it is clearly not a > fix. > Ok. I thought that patches enabling tx_csum_limit were adding a sort of regression, but I can agree to your interpretation. In such case I will leave stable notification only for patch #4. Thanks, Marcin
diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi index c6a0e9d..e8b7f67 100644 --- a/arch/arm/boot/dts/armada-38x.dtsi +++ b/arch/arm/boot/dts/armada-38x.dtsi @@ -498,6 +498,7 @@ reg = <0x70000 0x4000>; interrupts-extended = <&mpic 8>; clocks = <&gateclk 4>; + tx-csum-limit = <9800>; status = "disabled"; };
The Ethernet controller found in the Armada 38x SoC's family support TCP/IP checksumming with frame sizes larger than 1600 bytes, however only on port 0. This commit enables it by setting 'tx-csum-limit' to 9800B in 'ethernet@70000' node. Signed-off-by: Marcin Wojtas <mw@semihalf.com> Cc: <stable@vger.kernel.org> # v3.18+ --- arch/arm/boot/dts/armada-38x.dtsi | 1 + 1 file changed, 1 insertion(+)