From patchwork Fri Nov 27 15:44:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 7713881 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1C2B2C01BB for ; Fri, 27 Nov 2015 15:47:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3761D20722 for ; Fri, 27 Nov 2015 15:47:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 626F9206C3 for ; Fri, 27 Nov 2015 15:47:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a2LDN-0006bI-MR; Fri, 27 Nov 2015 15:45:37 +0000 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a2LCk-0005Bs-PD for linux-arm-kernel@lists.infradead.org; Fri, 27 Nov 2015 15:45:00 +0000 Received: by lfs39 with SMTP id 39so130751616lfs.3 for ; Fri, 27 Nov 2015 07:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ldwirp3J2a1Gd7QokcV3qvkSL/NOiaqMEkdPC/FjDOU=; b=HitO0nji9vIWU6zeJSUzZ4FjUydk5vTQDbIvAMnnCYmd8ciB2BkoZZbTDBz65LeXS7 nBYVGoTXlTUaml2+r+uisJKjYVA0OBISGooXVUYVrSephnfeH9kJ0GcnZk+dpKRVBXRC jb1Yd8avtwJzp/qTA9vZY6LQphNiYz6JvKoHW4s9laNpYgSUa4/Wadw+Dh1dP1RVodoQ a2kGZ6Y6GhFv5+kWvVWkD/IrX+NtWaakaePiaqOfgw0ZKdcZjPIynkwdwIOFv21g9QWv dMyza4TkOwyZ9yVv7Sxt0OvM24HEu1Cp97d9LTQqQpRluG6uhDTPIF8rVqR3CaQyHGD6 zWAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ldwirp3J2a1Gd7QokcV3qvkSL/NOiaqMEkdPC/FjDOU=; b=dDjSoy057Esr53E/4Gnk/winzQBfmAVHhI1bDTQ+MCwH6zpKYStVGwQpiBfoLM/PU+ yB4IIBZxx1ky+RhPB3zZPW0PoevTpcip9fc1FdAYcKWSCbjefNAmXaW/oHlrsNT86KYD weiqvBLUmBBtw8PgHe6BNtKaJ6d+tWCcogM2UjdcTu+GdI/O1Tmv/0HwAPDqxVs41/zc sk3O3i4vXALug+BJKXvHaJU7d5YqN+NKnRP3pvvVdsf8CET+5VT5IP/gEBDixhsK0Zgx mOqYeYZsoNQVI4EFI0JC9D+FYWQVAWAYr3k0TIYC5CT3WLWCHhq3wpohuh+nzXT0a4eQ 5zfA== X-Gm-Message-State: ALoCoQkcfUQiaoFoUy3+Vce9p2XfW0G8/dakcI5W4yi3rE+WeQt20535xYP837p9ur9Vdqx7g1/3 X-Received: by 10.112.170.167 with SMTP id an7mr19444617lbc.37.1448639076979; Fri, 27 Nov 2015 07:44:36 -0800 (PST) Received: from enkidu.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id k189sm5096651lfd.12.2015.11.27.07.44.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Nov 2015 07:44:36 -0800 (PST) From: Marcin Wojtas To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH v3 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable Date: Fri, 27 Nov 2015 16:44:23 +0100 Message-Id: <1448639066-13074-4-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1448639066-13074-1-git-send-email-mw@semihalf.com> References: <1448639066-13074-1-git-send-email-mw@semihalf.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151127_074459_173140_E1FF3B20 X-CRM114-Status: GOOD ( 10.15 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thomas.petazzoni@free-electrons.com, andrew@lunn.ch, linux@arm.linux.org.uk, jason@lakedaemon.net, myair@marvell.com, jaz@semihalf.com, simon.guinot@sequanux.org, xswang@marvell.com, nadavh@marvell.com, alior@marvell.com, tn@semihalf.com, gregory.clement@free-electrons.com, nitroshift@yahoo.com, mw@semihalf.com, davem@davemloft.net, sebastian.hesselbarth@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A value originally defined in the driver was inappropriate. Even though the ingress was somehow working, writing MVNETA_RXQ_INTR_ENABLE_ALL_MASK to MVNETA_INTR_ENABLE didn't make any effect, because the bits [31:16] are reserved and read-only. This commit updates MVNETA_RXQ_INTR_ENABLE_ALL_MASK to be compliant with the controller's documentation. Signed-off-by: Marcin Wojtas Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit") --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 64c46f0..5dffb68 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -160,7 +160,7 @@ #define MVNETA_INTR_ENABLE 0x25b8 #define MVNETA_TXQ_INTR_ENABLE_ALL_MASK 0x0000ff00 -#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0xff000000 // note: neta says it's 0x000000FF +#define MVNETA_RXQ_INTR_ENABLE_ALL_MASK 0x000000ff #define MVNETA_RXQ_CMD 0x2680 #define MVNETA_RXQ_DISABLE_SHIFT 8