diff mbox

[1/6] net: thunderx: Force to load octeon-mdio before bgx driver.

Message ID 1448961223-41888-2-git-send-email-sunil.kovvuri@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sunil Kovvuri Dec. 1, 2015, 9:13 a.m. UTC
From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>

Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
---
 drivers/net/ethernet/cavium/thunder/thunder_bgx.c |    3 +++
 drivers/net/ethernet/cavium/thunder/thunder_bgx.h |    1 +
 2 files changed, 4 insertions(+), 0 deletions(-)

Comments

Sergei Shtylyov Dec. 1, 2015, 1:17 p.m. UTC | #1
Hello.

On 12/1/2015 12:13 PM, Sunil Goutham wrote:

> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>
> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.c |    3 +++
>   drivers/net/ethernet/cavium/thunder/thunder_bgx.h |    1 +
>   2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 180aa9f..1fb72dd 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	struct bgx *bgx = NULL;
>   	u8 lmac;
>
> +	/*Load octeon mdio driver*/

    Please insert spaces after /* and before */ (unless it's a common comment 
style in this driver).

[...]

MBR, Sergei
Sunil Kovvuri Dec. 1, 2015, 4:24 p.m. UTC | #2
Thanks a lot, will fix and repost the patch.

On Tue, Dec 1, 2015 at 6:47 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 12/1/2015 12:13 PM, Sunil Goutham wrote:
>
>> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>>
>> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
>> ---
>>   drivers/net/ethernet/cavium/thunder/thunder_bgx.c |    3 +++
>>   drivers/net/ethernet/cavium/thunder/thunder_bgx.h |    1 +
>>   2 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> index 180aa9f..1fb72dd 100644
>> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const
>> struct pci_device_id *ent)
>>         struct bgx *bgx = NULL;
>>         u8 lmac;
>>
>> +       /*Load octeon mdio driver*/
>
>
>    Please insert spaces after /* and before */ (unless it's a common comment
> style in this driver).
>
> [...]
>
> MBR, Sergei
>
diff mbox

Patch

diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 180aa9f..1fb72dd 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1009,6 +1009,9 @@  static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	struct bgx *bgx = NULL;
 	u8 lmac;
 
+	/*Load octeon mdio driver*/
+	octeon_mdiobus_force_mod_depencency();
+
 	bgx = devm_kzalloc(dev, sizeof(*bgx), GFP_KERNEL);
 	if (!bgx)
 		return -ENOMEM;
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
index 07b7ec6..89a02fa 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
@@ -182,6 +182,7 @@  enum MCAST_MODE {
 #define BCAST_ACCEPT	1
 #define CAM_ACCEPT	1
 
+void octeon_mdiobus_force_mod_depencency(void);
 void bgx_add_dmac_addr(u64 dmac, int node, int bgx_idx, int lmac);
 unsigned bgx_get_map(int node);
 int bgx_get_lmac_count(int node, int bgx);