diff mbox

[v2] multi_v7_defconfig: Remove CONFIG_SOC_LS1021A

Message ID 1448969745-19743-1-git-send-email-fabio.estevam@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Dec. 1, 2015, 11:35 a.m. UTC
multi_v7_defconfig is not suitable for booting LS1021 as it needs
LPAE.
    
Remove this option.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Improve commit log

 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Arnd Bergmann Dec. 1, 2015, 11:47 a.m. UTC | #1
On Tuesday 01 December 2015 09:35:45 Fabio Estevam wrote:
> multi_v7_defconfig is not suitable for booting LS1021 as it needs
> LPAE.
>     
> Remove this option.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

This needs a better explanation. Why do we need LPAE for this
platform?

	Arnd
Alison Wang Dec. 2, 2015, 2:12 a.m. UTC | #2
> On Tuesday 01 December 2015 09:35:45 Fabio Estevam wrote:
> > multi_v7_defconfig is not suitable for booting LS1021 as it needs
> > LPAE.
> >
> > Remove this option.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> This needs a better explanation. Why do we need LPAE for this platform?
> 
>
[Alison Wang] Because PCIE, IFC region 2, DRAM2 and other IPs on LS1021A
are in the 40-bit address space, so we need to enable LPAE to access those
memory beyond the 4GB limit.

Let me summarize the current status. I have made multi_v7_lpae_defconfig to
support LS1021A according to the suggestion from Russell King. Olof Johansson
said they have discussed it before and they have chosen to just have a
multi_v7_defconfig. Attached is the discussion. There is not further
solution about the discussion.

So now, I suggest to remain LS1021A in multi_v7_defconfig at least.

Best Regards,
Alison Wang
Hi, Olof,
 
> On Mon, Nov 9, 2015 at 6:53 PM, Alison Wang <b18965@freescale.com> wrote:

> > v7 LPAE multi-platform defconfig is based on v7 multi-platform

> > defconfig and adds LPAE support.

> >

> > The platforms based on Cortex-A7/A12/A15/A17, PJ4B, Krait are also

> > enabled in this defconfig. But Cortex-A5/A8/A9, Scorpion and PJ4 are

> > removed.

> >

> > This defconfig is verified on LS1021A which enables GIANFAR, I2C,

> > WATCHDOG, AUDIO, EDMA and DSPI drivers, etc.

> >

> > The other platforms need to be verified by the platform maintainers

> > too.

> >

> > Signed-off-by: Alison Wang <alison.wang@freescale.com>

> 

> This has been discussed before, and what we have chosen to do is to just

> have a multi_v7_defconfig that all these platforms are enabled on but

> with LPAE off.

> 

> Instead, what we do when building (and on our build/boot builders) is to

> take multi_v7 and provide the snippet that turns on ARM_LPAE at that

> time.

> 

> 

[Alison Wang] Thanks for your reply. I tried to make this multi_v7_lpae_defconfig
according to the discussion with Russell King. He suggested to make a multi_v7_lpae_defconfig
rather than creating a new load of platform specific defconfigs. Attached is his original email.

King, do you have any comment about Olof's reply?


Best Regards,
Alison Wang
On Thu, Sep 17, 2015 at 05:03:34PM +0800, Alison Wang wrote:
> Add Freescale LS1021A initial defconfig file.
> The LS1021A SoC is a dual-core Cortex-A7 based processor.
> 
> LS1021A has some special configurations against imx_v6_v7_defconfig and
> multi_v7_defconfig, such as CONFIG_ARM_LPAE, CONFIG_ARM_PSCI...
> LPAE needs to be supported to access memory beyond the 4GB limit for
> LS1021A. PSCI needs to be supported for LS1021A too. But CONFIG_ARM_LPAE
> and CONFIG_ARM_PSCI are disabled in imx_v6_v7_defconfig and
> multi_v7_defconfig, so a separate LS1021A defconfig is needed.

Sounds like a need for multi_v7_lpae_defconfig rather than creating
a new load of platform specific defconfigs.
Arnd Bergmann Dec. 2, 2015, 3:58 p.m. UTC | #3
On Wednesday 02 December 2015 02:12:18 Huan Wang wrote:
> > On Tuesday 01 December 2015 09:35:45 Fabio Estevam wrote:
> > > multi_v7_defconfig is not suitable for booting LS1021 as it needs
> > > LPAE.
> > >
> > > Remove this option.
> > >
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > This needs a better explanation. Why do we need LPAE for this platform?
> > 
> >
> [Alison Wang] Because PCIE, IFC region 2, DRAM2 and other IPs on LS1021A
> are in the 40-bit address space, so we need to enable LPAE to access those
> memory beyond the 4GB limit.
> 
> Let me summarize the current status. I have made multi_v7_lpae_defconfig to
> support LS1021A according to the suggestion from Russell King. Olof Johansson
> said they have discussed it before and they have chosen to just have a
> multi_v7_defconfig. Attached is the discussion. There is not further
> solution about the discussion.
> 
> So now, I suggest to remain LS1021A in multi_v7_defconfig at least.

I think that's fine for the time being. We are still looking for
a good way to deal with LPAE configurations in general.

	Arnd
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index fa7ba92..410a699 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -54,7 +54,6 @@  CONFIG_SOC_IMX6SX=y
 CONFIG_SOC_IMX6UL=y
 CONFIG_SOC_IMX7D=y
 CONFIG_SOC_VF610=y
-CONFIG_SOC_LS1021A=y
 CONFIG_ARCH_OMAP3=y
 CONFIG_ARCH_OMAP4=y
 CONFIG_SOC_OMAP5=y