diff mbox

[2/6] arm64: dts: r8a7795: Add SATA controller node

Message ID 1450107758-2544-3-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ulrich Hecht Dec. 14, 2015, 3:42 p.m. UTC 
From: Kouei Abe <kouei.abe.cp@renesas.com>

This adds SATA device node to r8a7795.dtsi.

Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
[uli: adjusted for new MSTP clock scheme]
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Geert Uytterhoeven Dec. 15, 2015, 10:44 a.m. UTC | #1 
On Mon, Dec 14, 2015 at 4:42 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index c018423..7d4707e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -972,5 +972,13 @@
>                                 };
>                         };
>                 };
> +
> +               sata: sata@ee300000 {
> +                       compatible = "renesas,sata-r8a7795";
> +                       reg = <0 0xee300000 0 0x1fff>;
> +                       interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 915>;

My datasheet says 815.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Ulrich Hecht Dec. 15, 2015, 11:21 a.m. UTC | #2 
On Tue, Dec 15, 2015 at 11:44 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, Dec 14, 2015 at 4:42 PM, Ulrich Hecht
> <ulrich.hecht+renesas@gmail.com> wrote:
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index c018423..7d4707e 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -972,5 +972,13 @@
>>                                 };
>>                         };
>>                 };
>> +
>> +               sata: sata@ee300000 {
>> +                       compatible = "renesas,sata-r8a7795";
>> +                       reg = <0 0xee300000 0 0x1fff>;
>> +                       interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&cpg CPG_MOD 915>;
>
> My datasheet says 815.

So does the BSP, I must have misread that.

Simon, should I send an incremental patch for this one with v2?

CU
Uli
Simon Horman Dec. 16, 2015, 4:39 a.m. UTC | #3 
On Tue, Dec 15, 2015 at 12:21:16PM +0100, Ulrich Hecht wrote:
> On Tue, Dec 15, 2015 at 11:44 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Mon, Dec 14, 2015 at 4:42 PM, Ulrich Hecht
> > <ulrich.hecht+renesas@gmail.com> wrote:
> >> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >> index c018423..7d4707e 100644
> >> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> >> @@ -972,5 +972,13 @@
> >>                                 };
> >>                         };
> >>                 };
> >> +
> >> +               sata: sata@ee300000 {
> >> +                       compatible = "renesas,sata-r8a7795";
> >> +                       reg = <0 0xee300000 0 0x1fff>;
> >> +                       interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> >> +                       clocks = <&cpg CPG_MOD 915>;
> >
> > My datasheet says 815.
> 
> So does the BSP, I must have misread that.
> 
> Simon, should I send an incremental patch for this one with v2?

Please send an incremental patch, though I may well squash it into
what I already have queued up depending on when it arrives.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index c018423..7d4707e 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -972,5 +972,13 @@ 
 				};
 			};
 		};
+
+		sata: sata@ee300000 {
+			compatible = "renesas,sata-r8a7795";
+			reg = <0 0xee300000 0 0x1fff>;
+			interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 915>;
+			status = "disabled";
+		};
 	};
 };