From patchwork Thu Dec 17 15:47:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 7874061 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A4D82BEEE5 for ; Thu, 17 Dec 2015 15:49:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C06C920434 for ; Thu, 17 Dec 2015 15:49:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06A812026F for ; Thu, 17 Dec 2015 15:49:04 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9amX-0003Kt-M9; Thu, 17 Dec 2015 15:47:53 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a9amD-0003AC-T6 for linux-arm-kernel@lists.infradead.org; Thu, 17 Dec 2015 15:47:35 +0000 Received: by mail-io0-x22d.google.com with SMTP id o67so59030258iof.3 for ; Thu, 17 Dec 2015 07:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=G00gicNS9dBQVgAc2SUxmI3Bv9wHUyu31QE8HkXSJxY=; b=iTU2vgK5KSI4rSR7A9e+9kJjhfqKvDxJOu2ZAmSoi1ZAGdQHUEbw7FQ2H0IWdmfCt1 qmLmuoF1fpZa8aH/BXwSrZt2jS/7PQ7bCBf9BuT9j6RTmGFzOKkOMV2sS7h3KHVSePpl ZumVcIGU+j1ew5fBvOZSB5cCcMADZmrWingt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=G00gicNS9dBQVgAc2SUxmI3Bv9wHUyu31QE8HkXSJxY=; b=PrZewTeCWVTOSTi/MQyFx17JIBJBmtSCOFezmTw7tEQoKRXKaeyVIJoAdMILlqUXJ6 4ThuyQ1mlGrynDDLtHZlMU6OAYuTFmAneT+pNv94b/aBTxu2Mezly83O0pc74khvyzK1 TP3kB5malAOqPSqTz8S/lhTY3gS8Pu9UnFqnQKyazJ/W0os1PXX93WbWSNu6fQTc08Qo gsuHz+Q4dUkuEZp3LO8k+EXxVveiMFLu0IDv/2jaaJx4AGG0h0i+bKHJzVrAA7x6mNIL KjoL2M6gBsp9rM/TbotF1EkZv/J8p1WwLg/CRmyE93PHCTbaVBxWoxRoI6YPRmTCkveE y7TA== X-Gm-Message-State: ALoCoQnydFMYPrvOctyFlZWcT+yypCz72kmw4uXTVNjVDKwEdzbVqSFBwzCQV+grCLL3acGAjFyZUGQuRc2BnE+pk5MOvQgmMQ== X-Received: by 10.107.17.160 with SMTP id 32mr51874547ior.28.1450367231931; Thu, 17 Dec 2015 07:47:11 -0800 (PST) Received: from t430.cg.shawcable.net ([184.64.168.246]) by smtp.gmail.com with ESMTPSA id i69sm4758510iod.27.2015.12.17.07.47.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Dec 2015 07:47:11 -0800 (PST) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 1/2] coresight: checking for NULL string in coresight_name_match() Date: Thu, 17 Dec 2015 08:47:02 -0700 Message-Id: <1450367223-21068-2-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1450367223-21068-1-git-send-email-mathieu.poirier@linaro.org> References: <1450367223-21068-1-git-send-email-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151217_074734_110083_3547CC1B X-CRM114-Status: GOOD ( 12.83 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Connection child names associated to ports can sometimes be NULL, which is the case when booting a system on QEMU or when the Coresight power domain isn't switched on. This patch is adding a check to make sure a NULL string isn't fed to strcmp(), something that avoid crashing the system. Cc: # v3.18+ Reported-by: Tyler Baker Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index e25492137d8b..93738dfbf631 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -548,7 +548,7 @@ static int coresight_name_match(struct device *dev, void *data) to_match = data; i_csdev = to_coresight_device(dev); - if (!strcmp(to_match, dev_name(&i_csdev->dev))) + if (to_match && !strcmp(to_match, dev_name(&i_csdev->dev))) return 1; return 0;