| Message ID | 1450430173-26992-3-git-send-email-marc.zyngier@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 18, 2015 at 09:16:13AM +0000, Marc Zyngier wrote: > Having IPI_CPU_BACKTRACE as SGI15 may not work if the kernel is > running in non-secure mode and that the secure firmware has > decided to follow ARM's recommendations that SGI8-15 should > be reserved for secure purpose. > > Now that we are "only" using SGI0-6, change IPI_CPU_BACKTRACE > to use SGI7, which makes it more likely to work. We should add a comment to the enum explaining this, so it's obvious for the future - best place is after the IPI_CPU_BACKTRACE entry. Not everyone checks the git logs for these kinds of details.
On 18/12/15 09:16, Marc Zyngier wrote: > Having IPI_CPU_BACKTRACE as SGI15 may not work if the kernel is > running in non-secure mode and that the secure firmware has > decided to follow ARM's recommendations that SGI8-15 should > be reserved for secure purpose. > > Now that we are "only" using SGI0-6, change IPI_CPU_BACKTRACE > to use SGI7, which makes it more likely to work. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Tested-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > arch/arm/kernel/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c > index d50a77d..fe517f1 100644 > --- a/arch/arm/kernel/smp.c > +++ b/arch/arm/kernel/smp.c > @@ -72,7 +72,7 @@ enum ipi_msg_type { > IPI_CPU_STOP, > IPI_IRQ_WORK, > IPI_COMPLETION, > - IPI_CPU_BACKTRACE = 15, > + IPI_CPU_BACKTRACE, > }; > > static DECLARE_COMPLETION(cpu_running); >
On 18/12/15 11:20, Daniel Thompson wrote: > On 18/12/15 09:16, Marc Zyngier wrote: >> Having IPI_CPU_BACKTRACE as SGI15 may not work if the kernel is >> running in non-secure mode and that the secure firmware has >> decided to follow ARM's recommendations that SGI8-15 should >> be reserved for secure purpose. >> >> Now that we are "only" using SGI0-6, change IPI_CPU_BACKTRACE >> to use SGI7, which makes it more likely to work. >> >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > Tested-by: Daniel Thompson <daniel.thompson@linaro.org> Thanks Daniel, much appreciated. M.
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index d50a77d..fe517f1 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -72,7 +72,7 @@ enum ipi_msg_type { IPI_CPU_STOP, IPI_IRQ_WORK, IPI_COMPLETION, - IPI_CPU_BACKTRACE = 15, + IPI_CPU_BACKTRACE, }; static DECLARE_COMPLETION(cpu_running);
Having IPI_CPU_BACKTRACE as SGI15 may not work if the kernel is running in non-secure mode and that the secure firmware has decided to follow ARM's recommendations that SGI8-15 should be reserved for secure purpose. Now that we are "only" using SGI0-6, change IPI_CPU_BACKTRACE to use SGI7, which makes it more likely to work. Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> --- arch/arm/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)