From patchwork Wed Dec 23 10:59:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 7910351 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 960299F349 for ; Wed, 23 Dec 2015 11:07:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CDC1E203AB for ; Wed, 23 Dec 2015 11:07:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DA3520394 for ; Wed, 23 Dec 2015 11:07:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aBhEw-0003P3-QD; Wed, 23 Dec 2015 11:05:54 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aBhAK-0006bn-SU for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2015 11:01:13 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NZT008EM5998NC0@mailout1.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2015 11:00:45 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-21-567a7edd250b Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id AE.63.16778.DDE7A765; Wed, 23 Dec 2015 11:00:45 +0000 (GMT) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NZT004GC5932LA0@eusync3.samsung.com>; Wed, 23 Dec 2015 11:00:45 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/5] ARM: sa1111: ensure no negative value gets returned on positive match Date: Wed, 23 Dec 2015 11:59:25 +0100 Message-id: <1450868368-5650-3-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1450868368-5650-1-git-send-email-m.szyprowski@samsung.com> References: <1450868368-5650-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t/xq7p366rCDB594LTYOGM9q8X0qRcY LZoXr2ezeP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBa3L/NarD1yl92ib+0lNovja8MdeDxa mnvYPHbcXcLosXjPSyaPTas62TzuXNvD5rF/7hp2j81L6j36tqxi9Pi8SS6AM4rLJiU1J7Ms tUjfLoEr4/yf04wFF9gqurYtYm1gPM7axcjJISFgInH14kI2CFtM4sK99UA2F4eQwFJGiTu3 NzNBOE1MEo0rT4FVsQkYSnS97QKzRQSyJebv7WYHKWIWmM8s8XBVP9hYYYF4iUc3D7OA2CwC qhJzNx1mBrF5Bdwl3p5eywyxTk7i/8sVTCA2p4CHxJ3lr8DiQkA1bQffME9g5F3AyLCKUTS1 NLmgOCk911CvODG3uDQvXS85P3cTIyRUv+xgXHzM6hCjAAejEg+vQ1tlmBBrYllxZe4hRgkO ZiUR3vR3QCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFwSjUw xsQdSxf5F1es1Zb0an36sZ3r30Sy/FFJDItqfyBmf36qeLTbAu9tyzia9yzLvl4+TzdqP2vh mqeiPzX+Pcj1jpxWzbIlTEtx8fGlHd73fEq8O71nKwW1B+mW32/OWBAYwX2X7yZjZjPT16vf jLWarmwok7dR9G1+8GVN///Fn8+t3d672+CaEktxRqKhFnNRcSIALZILoFECAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151223_030109_369634_25DD3DD7 X-CRM114-Status: GOOD ( 14.22 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Russell King - ARM Linux , Tomeu Vizoso , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Krzysztof Kozlowski , Kukjin Kim , Dan Williams , Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch ensures that existing bus match callbacks don't return negative values (which might be interpreted as potential errors in the future) in case of positive match. Signed-off-by: Marek Szyprowski Acked-by: Russell King --- arch/arm/common/sa1111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 3d22494..fb0a0a4 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -1290,7 +1290,7 @@ static int sa1111_match(struct device *_dev, struct device_driver *_drv) struct sa1111_dev *dev = SA1111_DEV(_dev); struct sa1111_driver *drv = SA1111_DRV(_drv); - return dev->devid & drv->devid; + return !!(dev->devid & drv->devid); } static int sa1111_bus_suspend(struct device *dev, pm_message_t state)