From patchwork Wed Dec 23 10:59:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 7910431 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 51116BEEE5 for ; Wed, 23 Dec 2015 11:08:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 88261203F3 for ; Wed, 23 Dec 2015 11:08:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABF5A20394 for ; Wed, 23 Dec 2015 11:08:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aBhFv-000485-68; Wed, 23 Dec 2015 11:06:55 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aBhAt-00072y-Bq for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2015 11:01:47 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NZT009FR59AKCC0@mailout2.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2015 11:00:46 +0000 (GMT) X-AuditID: cbfec7f5-f79b16d000005389-4e-567a7ededabd Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id AA.85.21385.EDE7A765; Wed, 23 Dec 2015 11:00:46 +0000 (GMT) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NZT004GC5932LA0@eusync3.samsung.com>; Wed, 23 Dec 2015 11:00:46 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 5/5] ARM: amba: Properly handle devices with power domains Date: Wed, 23 Dec 2015 11:59:28 +0100 Message-id: <1450868368-5650-6-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1450868368-5650-1-git-send-email-m.szyprowski@samsung.com> References: <1450868368-5650-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLLMWRmVeSWpSXmKPExsVy+t/xq7r36qrCDHo3GVtsnLGe1WL61AuM Fs2L17NZvH5haNH/+DWzxabH11gtLu+aw2Yx4/w+Jovbl3kt1h65y27Rt/YSm8XxteEOPB4t zT1sHjvuLmH0WLznJZPHplWdbB53ru1h89g/dw27x+Yl9R59W1YxenzeJBfAGcVlk5Kak1mW WqRvl8CVsbK3kbGgh6Pi28WrjA2MR9m6GDk5JARMJCZO+AFli0lcuLceyObiEBJYyijxf+Un FginiUni+NwXLCBVbAKGEl1vu8A6RASyJebv7WYHKWIWmM8s8XBVPytIQljAV6J/+T12EJtF QFXi797jQHEODl4Bd4m7J2wgtslJ/H+5ggnE5hTwkLiz/BUziC0EVNJ28A3zBEbeBYwMqxhF U0uTC4qT0nON9IoTc4tL89L1kvNzNzFCAvXrDsalx6wOMQpwMCrx8L5orgwTYk0sK67MPcQo wcGsJMKb/g4oxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6p BsZCg7vnJgc47GNeyfTK2vc5u+VGsUsrUq59c/z8K/5IdBtH6b4PJlm+B8XNNywM3XjixVXW Essz1lVneCbtPPc/bs4bLS7ZOv99qx0Vd23MEc+wkXXucxXsu9I4VztQeb5N6+0XveKdEkdv OjHLnlA/c+8U871ErU+XX/WuquK5vvh3JLNBQLwSS3FGoqEWc1FxIgDTkGowUAIAAA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151223_030144_110861_FF93A8BE X-CRM114-Status: GOOD ( 17.08 ) X-Spam-Score: -6.9 (------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Russell King - ARM Linux , Tomeu Vizoso , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Krzysztof Kozlowski , Kukjin Kim , Dan Williams , Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP To read pid/cid registers, the probed device need to be properly turned on. When it is inside a power domain, the bus code should ensure that the given power domain is enabled before trying to access device's registers. Signed-off-by: Marek Szyprowski Reviewed-by: Ulf Hansson --- drivers/amba/bus.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 643127f..570033b 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -60,6 +60,10 @@ static int amba_read_periphid(struct amba_device *dev) if (!tmp) return -ENOMEM; + ret = dev_pm_domain_attach(&dev->dev, true); + if (ret == -EPROBE_DEFER) + goto err_unmap; + ret = amba_get_enable_pclk(dev); if (ret == 0) { u32 pid, cid; @@ -84,6 +88,8 @@ static int amba_read_periphid(struct amba_device *dev) ret = -ENODEV; } + dev_pm_domain_detach(&dev->dev, true); +err_unmap: iounmap(tmp); return ret;