| Message ID | 1452429613-28783-1-git-send-email-mans@mansr.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mans, > Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben: > > > Add pinmux setting for USB1 overcurrent on pwm2 pad. could you please change your patch to describe why you need to add this pinmux? > > Signed-off-by: Mans Rullgard <mans@mansr.com> Thanks Stefan
Stefan Wahren <stefan.wahren@i2se.com> writes: > Hi Mans, > >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben: >> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad. > > could you please change your patch to describe why you need to add > this pinmux? I'm working on a board that is wired that way. I can of course put this in the board-specific dts if that's preferable.
> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben: > > > Stefan Wahren <stefan.wahren@i2se.com> writes: > > > Hi Mans, > > > >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben: > >> > >> > >> Add pinmux setting for USB1 overcurrent on pwm2 pad. > > > > could you please change your patch to describe why you need to add > > this pinmux? > > I'm working on a board that is wired that way. I can of course put this > in the board-specific dts if that's preferable. So the board isn't submitted to mainline? IMHO the change is okay, but the description doesn't explain why is it needed. So a suitable description would be that it's needed for board xy. > > -- > Måns Rullgård
Stefan Wahren <stefan.wahren@i2se.com> writes: >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben: >> >> >> Stefan Wahren <stefan.wahren@i2se.com> writes: >> >> > Hi Mans, >> > >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben: >> >> >> >> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad. >> > >> > could you please change your patch to describe why you need to add >> > this pinmux? >> >> I'm working on a board that is wired that way. I can of course put this >> in the board-specific dts if that's preferable. > > So the board isn't submitted to mainline? Not yet anyway. > IMHO the change is okay, but the description doesn't explain why is it needed. > > So a suitable description would be that it's needed for board xy. Would it be better to send this patch in a series along with the full board support?
> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben: > > > Stefan Wahren <stefan.wahren@i2se.com> writes: > > >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben: > >> > >> > >> Stefan Wahren <stefan.wahren@i2se.com> writes: > >> > >> > Hi Mans, > >> > > >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 > >> >> geschrieben: > >> >> > >> >> > >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad. > >> > > >> > could you please change your patch to describe why you need to add > >> > this pinmux? > >> > >> I'm working on a board that is wired that way. I can of course put this > >> in the board-specific dts if that's preferable. > > > > So the board isn't submitted to mainline? > > Not yet anyway. > > > IMHO the change is okay, but the description doesn't explain why is it > > needed. > > > > So a suitable description would be that it's needed for board xy. > > Would it be better to send this patch in a series along with the full > board support? > Yes, it would be nice to have a dts file which reference the new pinmux. > -- > Måns Rullgård > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes: >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben: >> >> >> Stefan Wahren <stefan.wahren@i2se.com> writes: >> >> >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben: >> >> >> >> >> >> Stefan Wahren <stefan.wahren@i2se.com> writes: >> >> >> >> > Hi Mans, >> >> > >> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 >> >> >> geschrieben: >> >> >> >> >> >> >> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad. >> >> > >> >> > could you please change your patch to describe why you need to add >> >> > this pinmux? >> >> >> >> I'm working on a board that is wired that way. I can of course put this >> >> in the board-specific dts if that's preferable. >> > >> > So the board isn't submitted to mainline? >> >> Not yet anyway. >> >> > IMHO the change is okay, but the description doesn't explain why is it >> > needed. >> > >> > So a suitable description would be that it's needed for board xy. >> >> Would it be better to send this patch in a series along with the full >> board support? >> > > Yes, it would be nice to have a dts file which reference the new pinmux. OK, I'll sit on it for a while longer then.
Hello, On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote: > > Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben: > > Stefan Wahren <stefan.wahren@i2se.com> writes: > > > > > Hi Mans, > > > > > >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben: > > >> > > >> > > >> Add pinmux setting for USB1 overcurrent on pwm2 pad. > > > > > > could you please change your patch to describe why you need to add > > > this pinmux? > > > > I'm working on a board that is wired that way. I can of course put this > > in the board-specific dts if that's preferable. > > So the board isn't submitted to mainline? > > IMHO the change is okay, but the description doesn't explain why is it needed. > > So a suitable description would be that it's needed for board xy. The problem with pinmuxing on i.MX23/28 is that the order of pinmux groups is to a certain degree important. So not everything is possible in the machine specific dts. (I didn't have an eye on this issue, maybe it's fixed in the meantime?) Best regards Uwe
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index fae7b9069fc4..2f5cbf7d09f2 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -883,6 +883,16 @@ fsl,pull-up = <MXS_PULL_DISABLE>; }; + usb1_pins_b: usb1@1 { + reg = <1>; + fsl,pinmux-ids = < + MX28_PAD_PWM2__USB1_OVERCURRENT + >; + fsl,drive-strength = <MXS_DRIVE_12mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + usb0_id_pins_a: usb0id@0 { reg = <0>; fsl,pinmux-ids = <
Add pinmux setting for USB1 overcurrent on pwm2 pad. Signed-off-by: Mans Rullgard <mans@mansr.com> --- arch/arm/boot/dts/imx28.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)