From patchwork Mon Jan 11 19:10:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 8008651 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E6F3C9F744 for ; Mon, 11 Jan 2016 19:12:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1A61820279 for ; Mon, 11 Jan 2016 19:12:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10A822027D for ; Mon, 11 Jan 2016 19:12:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIhrl-0005EM-Mg; Mon, 11 Jan 2016 19:10:57 +0000 Received: from mail-qg0-x244.google.com ([2607:f8b0:400d:c04::244]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIhri-00052o-AM for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2016 19:10:55 +0000 Received: by mail-qg0-x244.google.com with SMTP id 6so44026246qgy.3 for ; Mon, 11 Jan 2016 11:10:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=+GrVM1txwt+1+cGA5fqwlRIBfEsvQd+D/UvGl6AfMXI=; b=BlLeqkHJpeVbEGfSAWDFXPT6ccpyCwxnY5Ok43r/2BFdaUjnaHy85lRr6rkj4sHqt0 3hwPGzvBMdymOJgEoVzu8dKAdZToz0eWwnPaXMOO5K2sDSC7LpNGr/zkt3MG7eVH/f2i hTL3cHzxJoT0w2HVTxdH2GnhTRN4EdYm2bokici7syr4GAorfANT+yYIT1rz/zCu+cUh CAO2dilolVSOMhel09LXecm38tl7t8mhg7gND6cMgKb2vrvH3QJVkOeG4VeF6Re8/K/y E+AH414b/ycF14Y3yxEq71uZc2gHcaqWOFnKvq0QSRG4R7eoSWI6dpLwXBxjcN7HLFGQ EO5A== X-Received: by 10.140.94.20 with SMTP id f20mr139575452qge.95.1452539432275; Mon, 11 Jan 2016 11:10:32 -0800 (PST) Received: from nick-System-Product-Name.hitronhub.home (CPEbc4dfb2691f3-CMbc4dfb2691f0.cpe.net.cable.rogers.com. [99.231.110.121]) by smtp.googlemail.com with ESMTPSA id 31sm13161491qgz.8.2016.01.11.11.10.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 11 Jan 2016 11:10:31 -0800 (PST) From: Nicholas Krause To: nagalakshmi.nandigama@avagotech.com Subject: [PATCH RESEND] mpt3sas:Fix missing error checks for calls to _transport_phy_reset in mpt3sas_transport.c Date: Mon, 11 Jan 2016 14:10:24 -0500 Message-Id: <1452539424-22916-1-git-send-email-xerofoify@gmail.com> X-Mailer: git-send-email 2.5.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160111_111054_464109_078E122C X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: abhijit.mahajan@avagotech.com, sbranden@broadcom.com, martin.petersen@oracle.com, jonmason@broadcom.com, rjui@broadcom.com, JBottomley@odin.com, linux-kernel@vger.kernel.org, sreekanth.reddy@avagotech.com, praveen.krishnamoorthy@avagotech.com, bcm-kernel-feedback-list@broadcom.com, linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@avagotech.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This adds the missing error checks and paths for functions that call _transport_phy_reset and do not correctly check that the call to this particular function has succeeded by returning zero in the file, mpt3sas_transport.c. Signed-off-by: Nicholas Krause --- drivers/scsi/mpt3sas/mpt3sas_transport.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c index ca36d7e..bff5a11 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c @@ -1766,7 +1766,7 @@ _transport_phy_enable(struct sas_phy *phy, int enable) /* link reset */ if (enable) - _transport_phy_reset(phy, 0); + rc = _transport_phy_reset(phy, 0); out: kfree(sas_iounit_pg1); @@ -1870,7 +1870,9 @@ _transport_phy_speed(struct sas_phy *phy, struct sas_phy_linkrates *rates) } /* link reset */ - _transport_phy_reset(phy, 0); + rc = _transport_phy_reset(phy, 0); + if (rc) + goto out; /* read phy page 0, then update the rates in the sas transport phy */ if (!mpt3sas_config_get_phy_pg0(ioc, &mpi_reply, &phy_pg0,