From patchwork Tue Jan 12 12:46:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 8016881 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1DEEE9F1CC for ; Tue, 12 Jan 2016 12:49:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 45B17203B4 for ; Tue, 12 Jan 2016 12:49:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8166220154 for ; Tue, 12 Jan 2016 12:49:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIyMn-0002X7-NJ; Tue, 12 Jan 2016 12:48:05 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aIyMb-0002Qp-0K for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2016 12:47:53 +0000 Received: by mail-wm0-x231.google.com with SMTP id b14so318276923wmb.1 for ; Tue, 12 Jan 2016 04:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6mNeXzkaqz201OSlTJ3Re5SkEuYRaEYyYUTtgfdeHks=; b=DeZyNC5anLsyjHZDQ6v4Q+3fwbTj4KhVeLicAPur3phbHicRb4aGohsQH63OuYGFHi 7LM8/51Z5+Mkz8aO4xIE9KN9kMHwrOkoJNZF1qB6wGg9TS+kiMjNp/bQiUbnrJWRu0tK yGdx9y4IYkjEeXAsBAqfO9EsWUfmVq2+FF+U0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6mNeXzkaqz201OSlTJ3Re5SkEuYRaEYyYUTtgfdeHks=; b=GskmKV+8VeBtEfYQVzI8MBHpziOuBdG4OtWxo6bVgRy/rdg70K8SK1hZ3YSYUAoCZ5 QufiNvLw7I9KI6/StrObEL2dttPj++y/gkTgs+Kun0eL8GKuS9i1q42T7VSZkELTP5/j iHLf3ysV1uqjLheFPK5NSHh06DgffO/a5rB0s6wgQEi6kQC9eD7IoO75h+n+Zz6POVUd 9eWHHmSYR8klCz/IYS+OD2yBOf6ryMP/BHU8Aux5NyUZe70WYdNupUkGw9Maykgr34dw 5JqkCQmVooEIyVn9EPRGSq50aiW+OMF/D1T/ZJnMivm6TziUmZncjolA2JNh7DyNF+nL ygTA== X-Gm-Message-State: ALoCoQnbqOIGCjE5dAKDr9AHajunLotEkyhZFkYiQj12RgFB/2PEat2ZRSullvSb49q6BMEDa6CSKWNm6VHFItqbT7jA0IG47w== X-Received: by 10.194.184.210 with SMTP id ew18mr124218805wjc.79.1452602851496; Tue, 12 Jan 2016 04:47:31 -0800 (PST) Received: from localhost.localdomain ([217.46.108.250]) by smtp.gmail.com with ESMTPSA id uo9sm30240142wjc.49.2016.01.12.04.47.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jan 2016 04:47:30 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/7] remoteproc: debugfs: Check of invalid 'count' value Date: Tue, 12 Jan 2016 12:46:15 +0000 Message-Id: <1452602781-22424-2-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1452602781-22424-1-git-send-email-lee.jones@linaro.org> References: <1452602781-22424-1-git-send-email-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160112_044753_216560_5CD257E4 X-CRM114-Status: GOOD ( 12.62 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, devicetree@vger.kernel.org, f.fainelli@gmail.com, kernel@stlinux.com, Nathan_Lynch@mentor.com, Lee Jones , ludovic.barre@st.com, maxime.coquelin@st.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If 'count' value is invalid, return early with an error. Signed-off-by: Lee Jones --- drivers/remoteproc/remoteproc_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index 9d30809..f63464c 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -156,8 +156,8 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf, char buf[10]; int ret; - if (count > sizeof(buf)) - return count; + if (count > sizeof(buf) || count <= 0) + return -EINVAL; ret = copy_from_user(buf, user_buf, count); if (ret)