From patchwork Thu Jan 14 18:57:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 8035011 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CE11E9F744 for ; Thu, 14 Jan 2016 19:00:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F3CE020439 for ; Thu, 14 Jan 2016 19:00:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6A6A203DF for ; Thu, 14 Jan 2016 19:00:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aJn71-0002tF-Sr; Thu, 14 Jan 2016 18:59:11 +0000 Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aJn6a-0002aK-GE for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2016 18:58:45 +0000 Received: by mail-pa0-x22e.google.com with SMTP id ho8so120337609pac.2 for ; Thu, 14 Jan 2016 10:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YgMHPooNTEEgV/AGMSCehNecAIJr93AK9JuYNjD4EMM=; b=E86anBWs3c9go3roP15o6FC50/14llLTCMPyWCrRWSY1G/IbIGPlNBZLut9wqMmelQ FkMVIy0sOlmvFTa6DYw7oD4d9t/4udQ9ixWLdcpsveHHWG5rr+I/0zt8FhsyzDGFru0i Gh1Lxm3ixZclEQl6qneODZ6ubXeBs2L39eNjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YgMHPooNTEEgV/AGMSCehNecAIJr93AK9JuYNjD4EMM=; b=fx9T1IHzRrD8bTI8snR25LvJRReZ4PgpqoCFE7yMsUSm9CZGOxU9CJSj4NnKMrFa/N MMYZpmRjvoKJzvnDRgUy/g2abXqo2zMniKijrWGwiJpa14pkb4BjhHjzqlEcsWI4ahj5 VzYPfFXzConEPKrCwQQLVKj0DBX11AXffrjL1sDBgYahGvTvdC+1pCL/Ohpn3SD/yXWe rEboatEJLmxmXj2JBHobCAvgcBlyAadaWFoh2xr5ZmmY0fUjz8FweKSAaVLzYTVwlw+8 nh2EJwcWS7C2nHDwhkP6GDGwlxKT0XX//FcEceqaKmiE8H/vIPPk1ACDluG7iRBGBPdG qkSQ== X-Gm-Message-State: ALoCoQn6g/uZrI1NQabvI4+4hmDZCHHdpt4iogZZy9sePgRKTw/A0H3TP6Q/1+n5YwSo5gbSczMdwv7wNz/La5dzjbmIqUOhZg== X-Received: by 10.66.158.169 with SMTP id wv9mr8343611pab.138.1452797904921; Thu, 14 Jan 2016 10:58:24 -0800 (PST) Received: from t430.cg.shawcable.net ([184.64.168.246]) by smtp.gmail.com with ESMTPSA id p87sm10854256pfi.94.2016.01.14.10.58.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Jan 2016 10:58:24 -0800 (PST) From: Mathieu Poirier To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] coresight: coresight_unregister() function cleanup Date: Thu, 14 Jan 2016 11:57:58 -0700 Message-Id: <1452797880-4365-4-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1452797880-4365-1-git-send-email-mathieu.poirier@linaro.org> References: <1452797880-4365-1-git-send-email-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160114_105844_609688_941F4090 X-CRM114-Status: GOOD ( 12.87 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In its current form the code never frees csdev->refcnt allocated in coresight_register(). There is also a problem with csdev->conns that is freed before device_unregister() rather than in the device release function. This patch addresses both issues by moving kfree(csdev->conns) to coresight_device_release() and freeing csdev->refcnt, also in the same function. Reported-by: Rabin Vincent Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index 41b42018b660..8872db4410eb 100644 --- a/drivers/hwtracing/coresight/coresight.c +++ b/drivers/hwtracing/coresight/coresight.c @@ -481,6 +481,8 @@ static void coresight_device_release(struct device *dev) { struct coresight_device *csdev = to_coresight_device(dev); + kfree(csdev->conns); + kfree(csdev->refcnt); kfree(csdev); } @@ -713,7 +715,6 @@ EXPORT_SYMBOL_GPL(coresight_register); void coresight_unregister(struct coresight_device *csdev) { - kfree(csdev->conns); device_unregister(&csdev->dev); } EXPORT_SYMBOL_GPL(coresight_unregister);