From patchwork Mon Jan 18 12:21:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Wu X-Patchwork-Id: 8054411 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9DC6A9FC36 for ; Mon, 18 Jan 2016 12:24:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C80BD2049C for ; Mon, 18 Jan 2016 12:24:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED442203AC for ; Mon, 18 Jan 2016 12:24:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aL8q4-00029o-Q0; Mon, 18 Jan 2016 12:23:16 +0000 Received: from mail-pa0-x243.google.com ([2607:f8b0:400e:c03::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aL8pr-00025k-Gh for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2016 12:23:04 +0000 Received: by mail-pa0-x243.google.com with SMTP id gi1so39916396pac.2 for ; Mon, 18 Jan 2016 04:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+3XQO9ukWFKzLm5WT3lqDIZ2QG4gLqBdKpn44QTc7r4=; b=Wrdjm9sWdIj2GCP1RniKavY/K4GcjBtJV3eSrtcc+AceZbvnOEwP6/9wW3j0ws374/ l+XTdrbKlY49OtZosX9tyFDrEFwuR6Pb/TJFRBPhsrNoJI9o3uFDAkU5CJSguw6Hd+DF ehSV+8Jvq5mvmmSfYDaZjaplx+dlzDkhSdta4uWUVM60zH7y31L3ZQ5bod7mFGZssOf0 Vyvg456DG0DpCNQXNXPAbAe1QPreipb7rFWioB4YOh1B2HJaPZdhp75Tnuqhsp3HoBp2 Yk40Dj8ZVrV3AVD95wtwjGJSqgJwxQfl5W0awHxT0kFOWuZnCdnCBwyNyV8d6BYy2J// 5lKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+3XQO9ukWFKzLm5WT3lqDIZ2QG4gLqBdKpn44QTc7r4=; b=ModzjN+KFTvnk7KWaHjfq6bvbp3PU6hWtIxJ/PBy1ptUS2N85NvPvmB7NJI5GGfDLl Oxhcr1AiTvaYJTd0A57O+Tanx/Efcvc/LOFlwS2cs+iY/V3UVPKV2z0I79L+MgpUW+rq eINAEgAZ4y6etmKpJNg3cIAcOvh3AQdhxpjW0a+T9ed2WCIlMBpugqYIMOQQrljQlf5Q 7C77wMgvEq8kEdjM7OYmn0IjDmphZ8vzmw/kFj/5Pkp6GUao8HDsS1OntqejUj4j/53l 8tWzf/bjmP3r2LSrSvEV2Sd9H30jT5YXEhv4myxOHrHZaIclils/6cOGSNgMvkKtTFh7 QmVg== X-Gm-Message-State: ALoCoQkU8Kf/AjJOx4lOJvDM++LHsyXUbx3RR+Mm1NOUtYgnRiPX/Nubyg+FTC8weuDF23LcNxpgPaOPxKtL8U0Qwq1tVKirng== X-Received: by 10.66.218.225 with SMTP id pj1mr35280462pac.40.1453119762859; Mon, 18 Jan 2016 04:22:42 -0800 (PST) Received: from ubuntu.ubuntu-domain ([101.224.101.57]) by smtp.gmail.com with ESMTPSA id v2sm33683856pfi.93.2016.01.18.04.22.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jan 2016 04:22:41 -0800 (PST) From: Josh Wu To: Guennadi Liakhovetski , Linux Media Mailing List Subject: [PATCH 02/13] atmel-isi: move the is_support() close to try/set format function Date: Mon, 18 Jan 2016 20:21:38 +0800 Message-Id: <1453119709-20940-3-git-send-email-rainyfeeling@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1453119709-20940-1-git-send-email-rainyfeeling@gmail.com> References: <1453119709-20940-1-git-send-email-rainyfeeling@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160118_042303_749698_35503F0A X-CRM114-Status: GOOD ( 11.90 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Josh Wu , Ludovic Desroches , Nicolas Ferre , Songjun Wu , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As is_support() only used by try/set format function so put them together. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 36 +++++++++++++-------------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index dc81df3..3793b68 100644 --- a/drivers/media/platform/soc_camera/atmel-isi.c +++ b/drivers/media/platform/soc_camera/atmel-isi.c @@ -189,24 +189,6 @@ static void configure_geometry(struct atmel_isi *isi, u32 width, return; } -static bool is_supported(struct soc_camera_device *icd, - const u32 pixformat) -{ - switch (pixformat) { - /* YUV, including grey */ - case V4L2_PIX_FMT_GREY: - case V4L2_PIX_FMT_YUYV: - case V4L2_PIX_FMT_UYVY: - case V4L2_PIX_FMT_YVYU: - case V4L2_PIX_FMT_VYUY: - /* RGB */ - case V4L2_PIX_FMT_RGB565: - return true; - default: - return false; - } -} - static irqreturn_t atmel_isi_handle_streaming(struct atmel_isi *isi) { if (isi->active) { @@ -571,6 +553,24 @@ static int isi_camera_init_videobuf(struct vb2_queue *q, return vb2_queue_init(q); } +static bool is_supported(struct soc_camera_device *icd, + const u32 pixformat) +{ + switch (pixformat) { + /* YUV, including grey */ + case V4L2_PIX_FMT_GREY: + case V4L2_PIX_FMT_YUYV: + case V4L2_PIX_FMT_UYVY: + case V4L2_PIX_FMT_YVYU: + case V4L2_PIX_FMT_VYUY: + /* RGB */ + case V4L2_PIX_FMT_RGB565: + return true; + default: + return false; + } +} + static int try_or_set_fmt(struct soc_camera_device *icd, struct v4l2_format *f, struct v4l2_subdev_format *format)