| Message ID | 1453827558-10954-2-git-send-email-ralf@ramses-pyramidenbau.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hey Ralf, thanks for following up with patches as we discussed in private!
Small nit: you will want to use the active form ("Fix typo" instead of
"Fixed typo") in your commit messages.
It would also be nice if the commit title was a little more precise
about where the typo has been corrected.
On Wed, Jan 27, 2016 at 1:59 AM, Ralf Ramsauer
<ralf@ramses-pyramidenbau.de> wrote:
> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
> ---
> arch/arm/boot/dts/tegra114.dtsi | 2 +-
> arch/arm/boot/dts/tegra124.dtsi | 2 +-
> arch/arm/boot/dts/tegra20.dtsi | 2 +-
> arch/arm/boot/dts/tegra30.dtsi | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index d845bd1..5017ed8 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -256,7 +256,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable
> - * the APB DMA based serial driver, the comptible is
> + * the APB DMA based serial driver, the compatible is
> * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
> */
> uarta: serial@70006000 {
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index 68669f7..995289b 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -322,7 +322,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable
> - * the APB DMA based serial driver, the comptible is
> + * the APB DMA based serial driver, the compatible is
> * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart".
> */
> uarta: serial@0,70006000 {
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> index 33173e1..8fb61b9 100644
> --- a/arch/arm/boot/dts/tegra20.dtsi
> +++ b/arch/arm/boot/dts/tegra20.dtsi
> @@ -309,7 +309,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra20-uart" and to enable the APB DMA based serial
> - * driver, the comptible is "nvidia,tegra20-hsuart".
> + * driver, the compatible is "nvidia,tegra20-hsuart".
> */
> uarta: serial@70006000 {
> compatible = "nvidia,tegra20-uart";
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index 313e260..c6edc8c 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -371,7 +371,7 @@
> * driver and APB DMA based serial driver for higher baudrate
> * and performace. To enable the 8250 based driver, the compatible
> * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable
> - * the APB DMA based serial driver, the comptible is
> + * the APB DMA based serial driver, the compatible is
> * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart".
> */
> uarta: serial@70006000 {
> --
> 2.4.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/27/2016 08:59 AM, Alexandre Courbot wrote: > Hey Ralf, thanks for following up with patches as we discussed in private! > > Small nit: you will want to use the active form ("Fix typo" instead of > "Fixed typo") in your commit messages. So even my language skills got improved ;-) > > It would also be nice if the commit title was a little more precise > about where the typo has been corrected. Uhm - as this is be pretty small non-diff-related change... Is it necessary to send a v3 or would it also be okay to let the maintainer amend the subject? (to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes") Ralf > > On Wed, Jan 27, 2016 at 1:59 AM, Ralf Ramsauer > <ralf@ramses-pyramidenbau.de> wrote: >> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de> >> --- >> arch/arm/boot/dts/tegra114.dtsi | 2 +- >> arch/arm/boot/dts/tegra124.dtsi | 2 +- >> arch/arm/boot/dts/tegra20.dtsi | 2 +- >> arch/arm/boot/dts/tegra30.dtsi | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi >> index d845bd1..5017ed8 100644 >> --- a/arch/arm/boot/dts/tegra114.dtsi >> +++ b/arch/arm/boot/dts/tegra114.dtsi >> @@ -256,7 +256,7 @@ >> * driver and APB DMA based serial driver for higher baudrate >> * and performace. To enable the 8250 based driver, the compatible >> * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable >> - * the APB DMA based serial driver, the comptible is >> + * the APB DMA based serial driver, the compatible is >> * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". >> */ >> uarta: serial@70006000 { >> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi >> index 68669f7..995289b 100644 >> --- a/arch/arm/boot/dts/tegra124.dtsi >> +++ b/arch/arm/boot/dts/tegra124.dtsi >> @@ -322,7 +322,7 @@ >> * driver and APB DMA based serial driver for higher baudrate >> * and performace. To enable the 8250 based driver, the compatible >> * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable >> - * the APB DMA based serial driver, the comptible is >> + * the APB DMA based serial driver, the compatible is >> * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart". >> */ >> uarta: serial@0,70006000 { >> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> index 33173e1..8fb61b9 100644 >> --- a/arch/arm/boot/dts/tegra20.dtsi >> +++ b/arch/arm/boot/dts/tegra20.dtsi >> @@ -309,7 +309,7 @@ >> * driver and APB DMA based serial driver for higher baudrate >> * and performace. To enable the 8250 based driver, the compatible >> * is "nvidia,tegra20-uart" and to enable the APB DMA based serial >> - * driver, the comptible is "nvidia,tegra20-hsuart". >> + * driver, the compatible is "nvidia,tegra20-hsuart". >> */ >> uarta: serial@70006000 { >> compatible = "nvidia,tegra20-uart"; >> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi >> index 313e260..c6edc8c 100644 >> --- a/arch/arm/boot/dts/tegra30.dtsi >> +++ b/arch/arm/boot/dts/tegra30.dtsi >> @@ -371,7 +371,7 @@ >> * driver and APB DMA based serial driver for higher baudrate >> * and performace. To enable the 8250 based driver, the compatible >> * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable >> - * the APB DMA based serial driver, the comptible is >> + * the APB DMA based serial driver, the compatible is >> * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". >> */ >> uarta: serial@70006000 { >> -- >> 2.4.10 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/27/16 17:45, Ralf Ramsauer wrote: > On 01/27/2016 08:59 AM, Alexandre Courbot wrote: >> Hey Ralf, thanks for following up with patches as we discussed in private! >> >> Small nit: you will want to use the active form ("Fix typo" instead of >> "Fixed typo") in your commit messages. > So even my language skills got improved ;-) This is grammatically correct, but using imperative form is the convention in the kernel. As per Documentation/SubmittingPatches: Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. >> It would also be nice if the commit title was a little more precise >> about where the typo has been corrected. > Uhm - as this is be pretty small non-diff-related change... Is it > necessary to send a v3 or would it also be okay to let the maintainer > amend the subject? > (to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes") Let's see what Thierry says about this.
On Wed, Jan 27, 2016 at 06:15:50PM +0900, Alexandre Courbot wrote: > On 01/27/16 17:45, Ralf Ramsauer wrote: > >On 01/27/2016 08:59 AM, Alexandre Courbot wrote: > >>Hey Ralf, thanks for following up with patches as we discussed in private! > >> > >>Small nit: you will want to use the active form ("Fix typo" instead of > >>"Fixed typo") in your commit messages. > >So even my language skills got improved ;-) > > This is grammatically correct, but using imperative form is the convention > in the kernel. As per Documentation/SubmittingPatches: > > Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > to do frotz", as if you are giving orders to the codebase to change > its behaviour. > > >>It would also be nice if the commit title was a little more precise > >>about where the typo has been corrected. > >Uhm - as this is be pretty small non-diff-related change... Is it > >necessary to send a v3 or would it also be okay to let the maintainer > >amend the subject? > >(to sth.: like "ARM: tegra: Fix the same C&P typo in several dts includes") > > Let's see what Thierry says about this. I've changed this when applying and also added a full commit message. Doing so might arguably be a little overkill, but in doing so I realized that the same typo was there in the Tegra132 and Tegra210 DTS includes, so I fixed those up in a separate patch while at it. I made it a separate patch because the arm-soc maintainers want arch/arm and arch/arm64 changes to come in via separate branches. I did add a Suggested-by for Ralf since he spotted the original typo, I hope that's okay with everyone. Thierry
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index d845bd1..5017ed8 100644 --- a/arch/arm/boot/dts/tegra114.dtsi +++ b/arch/arm/boot/dts/tegra114.dtsi @@ -256,7 +256,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial@70006000 { diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index 68669f7..995289b 100644 --- a/arch/arm/boot/dts/tegra124.dtsi +++ b/arch/arm/boot/dts/tegra124.dtsi @@ -322,7 +322,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra124-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart". */ uarta: serial@0,70006000 { diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 33173e1..8fb61b9 100644 --- a/arch/arm/boot/dts/tegra20.dtsi +++ b/arch/arm/boot/dts/tegra20.dtsi @@ -309,7 +309,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra20-uart" and to enable the APB DMA based serial - * driver, the comptible is "nvidia,tegra20-hsuart". + * driver, the compatible is "nvidia,tegra20-hsuart". */ uarta: serial@70006000 { compatible = "nvidia,tegra20-uart"; diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index 313e260..c6edc8c 100644 --- a/arch/arm/boot/dts/tegra30.dtsi +++ b/arch/arm/boot/dts/tegra30.dtsi @@ -371,7 +371,7 @@ * driver and APB DMA based serial driver for higher baudrate * and performace. To enable the 8250 based driver, the compatible * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable - * the APB DMA based serial driver, the comptible is + * the APB DMA based serial driver, the compatible is * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". */ uarta: serial@70006000 {
Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de> --- arch/arm/boot/dts/tegra114.dtsi | 2 +- arch/arm/boot/dts/tegra124.dtsi | 2 +- arch/arm/boot/dts/tegra20.dtsi | 2 +- arch/arm/boot/dts/tegra30.dtsi | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)