| Message ID | 1453902670-32294-1-git-send-email-ao2@ao2.it (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 27, 2016 at 02:51:10PM +0100, Antonio Ospite wrote: > While at it also fix some other typos in the affected lines: > s/reminder/remainder/ > s/comparison/comparisons/ > > Signed-off-by: Antonio Ospite <ao2@ao2.it> Acked-by: Russell King <rmk+kernel@Arm.linux.org.uk> Thanks. I assume the trivial tree will be picking this up?
On Wed, 27 Jan 2016 19:27:12 +0000 Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Wed, Jan 27, 2016 at 02:51:10PM +0100, Antonio Ospite wrote: > > While at it also fix some other typos in the affected lines: > > s/reminder/remainder/ > > s/comparison/comparisons/ > > > > Signed-off-by: Antonio Ospite <ao2@ao2.it> > > Acked-by: Russell King <rmk+kernel@Arm.linux.org.uk> > > Thanks. I assume the trivial tree will be picking this up? Hi Russel, can't you pick it up in the ARM tree? I had sent this change to the trivial tree last April, and you ACKed it back then as well, but it was not merged. Maybe Jiri, who maintains the trivial tree, thought that you were picking it up. I have been told, by Mark Brown IIRC, that (I'm paraphrasing) subsystem maintainers should be the preferred recipients, and that "all-over" maintainers are only for when the same change applies to multiple subsystems and it does not make sense to split the patch. Thanks, Antonio
diff --git a/arch/arm/lib/lib1funcs.S b/arch/arm/lib/lib1funcs.S index 9397b2e..8e89c20 100644 --- a/arch/arm/lib/lib1funcs.S +++ b/arch/arm/lib/lib1funcs.S @@ -167,7 +167,7 @@ Boston, MA 02111-1307, USA. */ #endif - @ Perform all needed subtractions to keep only the reminder. + @ Perform all needed subtractions to keep only the remainder. @ Do comparisons in batch of 4 first. subs \order, \order, #3 @ yes, 3 is intended here blt 2f @@ -189,7 +189,7 @@ Boston, MA 02111-1307, USA. */ teqne \dividend, #0 beq 5f - @ Either 1, 2 or 3 comparison/subtractions are left. + @ Either 1, 2 or 3 comparisons/subtractions are left. 2: cmn \order, #2 blt 4f beq 3f
While at it also fix some other typos in the affected lines: s/reminder/remainder/ s/comparison/comparisons/ Signed-off-by: Antonio Ospite <ao2@ao2.it> Cc: Russell King <linux@arm.linux.org.uk> Cc: Christoffer Dall <christoffer.dall@linaro.org> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- arch/arm/lib/lib1funcs.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)