diff mbox

[01/11] irqchip: sun4i: fix compilation outside of arch/arm

Message ID 1454348370-3816-2-git-send-email-andre.przywara@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andre Przywara Feb. 1, 2016, 5:39 p.m. UTC 
The Allwinner sunxi specific interrupt controller cannot be compiled
for any architecture except arm:

drivers/irqchip/irq-sun4i.c:25:26: fatal error: asm/mach/irq.h: No such file or directory
compilation terminated.

It turns out that this header is actually not needed for the driver,
so remove it and allow compilation for other architectures like
arm64.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/irqchip/irq-sun4i.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Matthias Brugger Feb. 2, 2016, 3:12 p.m. UTC | #1 
On 01/02/16 18:39, Andre Przywara wrote:
> The Allwinner sunxi specific interrupt controller cannot be compiled
> for any architecture except arm:

s/arm/arm64
Andre Przywara Feb. 2, 2016, 3:32 p.m. UTC | #2 
Hi,

On 02/02/16 15:12, Matthias Brugger wrote:
> On 01/02/16 18:39, Andre Przywara wrote:
>> The Allwinner sunxi specific interrupt controller cannot be compiled
>> for any architecture except arm:
> 
> s/arm/arm64

???

As it stands it only compiles for arm, and not arm64, so "cannot be
compile for any architecture except arm" is the right thing to say, no?

Or did I get confused by my own double negation?

Cheers,
Andre.
Matthias Brugger Feb. 2, 2016, 4:50 p.m. UTC | #3 
On 02/02/16 16:32, Andre Przywara wrote:
> Hi,
>
> On 02/02/16 15:12, Matthias Brugger wrote:
>> On 01/02/16 18:39, Andre Przywara wrote:
>>> The Allwinner sunxi specific interrupt controller cannot be compiled
>>> for any architecture except arm:
>>
>> s/arm/arm64
>
> ???
>
> As it stands it only compiles for arm, and not arm64, so "cannot be
> compile for any architecture except arm" is the right thing to say, no?
>
> Or did I get confused by my own double negation?
>

No, it's just me who get confused. ;)
Sorry for the noise.
diff mbox

Patch

diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c
index 0704362..376b280 100644
--- a/drivers/irqchip/irq-sun4i.c
+++ b/drivers/irqchip/irq-sun4i.c
@@ -22,7 +22,6 @@ 
 #include <linux/of_irq.h>
 
 #include <asm/exception.h>
-#include <asm/mach/irq.h>
 
 #define SUN4I_IRQ_VECTOR_REG		0x00
 #define SUN4I_IRQ_PROTECTION_REG	0x08