From patchwork Mon Feb 8 12:51:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8249541 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B9117BEEE5 for ; Mon, 8 Feb 2016 12:55:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DAF2B2013A for ; Mon, 8 Feb 2016 12:55:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EF0E200C1 for ; Mon, 8 Feb 2016 12:55:09 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aSlKB-0002te-4V; Mon, 08 Feb 2016 12:53:51 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aSlK6-0002gr-BL for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2016 12:53:48 +0000 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue103) with ESMTPA (Nemesis) id 0MWPgw-1aVcbU00xm-00Xg0Y; Mon, 08 Feb 2016 13:53:02 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman Subject: [PATCH 2/2] serial: 8250: fix building Ingenic with SERIAL_8250=m Date: Mon, 8 Feb 2016 13:51:43 +0100 Message-Id: <1454935947-2743255-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454935947-2743255-1-git-send-email-arnd@arndb.de> References: <1454935947-2743255-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:OsiPyREPSJdAALh6DuBHE7O2bt6fT7F4muqYcvrbbMqOBUXU+PR s5DcBXZuMYB32JkhtY+3K28Lu4vVebYm2S2Efev3VzXI+lFAMT0b8v/fPazI9dpLXR8Jwp4 M07NIxGcD14Z6sDVeIP5pc3+r6FnsFqbVG6wwaCM2HCVAb+Sd/Ah4PUsT2UjNEdP9whlV0z fIN8KGH+BQ8m9M9MLDDNg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Wr3rFAIYlpQ=:X3vqhhk5TtzMvbusZad2Ln midNMU2R1ndiRQ57EI5c60UVDUS4u+tgL0AAIqiaMHzim2MZk+RWcAUFNZgkqrK4kEpvJpCGk vYGjLglU2b7GxXdFZFEBhyLCVUj8xhumJ8kBQishV5T9CmVhuuLRtJVrE/b2mMowFUHV3V1Pp pCPmpwcfXDqLPaFcI0z3/WcBeNarMJjcEVxdsIhR6iiasDfg3RnjzpBbzmdHje+g5pLBeEZHg t9K2HNNgcNFPQAun28TYK/SNkD9xF1L3jjKpiJg3HEvPukjiZd/NOFabcTM9ZSspxJBNzZXNy jGLsLeJfe2Sjz6bm9q7jxMBrxdNiXnw94dAvGT2/lQIzkz4fAZknORBwmgG/NXIb05/Pf7Fic qJ72bsDiRBEju4d6DD9+Okx0MwOnJEtONjkIoOBUVVBanYV52V4k9yoPRUPOYs+i4nOlpJm0J 3rRRHuEEJRwMNnvZhpc1/PKctGJUHdoBeVdn52TcazpFgJqfrNuPEYUbV7x4/SfGSUZp1r399 GhWyMSpdGkV20K4OCZo5cTM/c0VYjOyoKqJvBgPUGmTEZJ90WAob3u/qM6X9A2Q9AgU7/jtEO gr96SBHB5lLudGcmJazpMbXUUiq4d9qMdsvtHX/FQFBkGSWoHImESmWvSCxdqjWXO2Q3I4q4y +Yc1HJTcxkuWe56zNadtdrq7Bm4K60r0yi98SOYEXOtJx/O4mjGIrpUSbTU+zPooPaYo= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160208_045346_964080_160C4DB4 X-CRM114-Status: GOOD ( 14.38 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matt Redfearn , Paul Burton , Arnd Bergmann , Sascha Hauer , linux-kernel@vger.kernel.org, Paul Gortmaker , linux-serial@vger.kernel.org, Jiri Slaby , Matthias Brugger , Eddie Huang , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Ingenic 8250 driver has a 'bool' Kconfig symbol, but that breaks when SERIAL_8250 is a loadable module: drivers/tty/built-in.o: In function `ingenic_uart_probe': 8250_ingenic.c:(.text+0x1c1a0): undefined reference to `serial8250_register_8250_port' This changes the symbol to a 'tristate', plus a dependency on SERIAL_8250, which makes it work again. Unlike the other soc-specific backends, this one has no dependency on an architecture or a platform. I'm adding a dependency on MIPS || COMPILE_TEST as well here, to avoid showing the driver on architectures that are not interested in it. Signed-off-by: Arnd Bergmann --- drivers/tty/serial/8250/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 6ae0fae4f796..13c63b14179f 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -384,8 +384,8 @@ config SERIAL_8250_UNIPHIER serial ports, say Y to this option. If unsure, say N. config SERIAL_8250_INGENIC - bool "Support for Ingenic SoC serial ports" - depends on OF_FLATTREE + tristate "Support for Ingenic SoC serial ports" + depends on SERIAL_8250 && OF_FLATTREE && (MIPS || COMPILE_TEST) select LIBFDT help If you have a system using an Ingenic SoC and wish to make use of