From patchwork Fri Feb 12 04:08:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaun Ren X-Patchwork-Id: 8287571 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AEAD99F6DA for ; Fri, 12 Feb 2016 04:21:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D5DBA20397 for ; Fri, 12 Feb 2016 04:21:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08AA7202D1 for ; Fri, 12 Feb 2016 04:21:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aU5Bh-0006WE-Cm; Fri, 12 Feb 2016 04:18:33 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aU59z-000594-0P for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2016 04:16:48 +0000 Received: by mail-io0-x22b.google.com with SMTP id l127so79868961iof.3 for ; Thu, 11 Feb 2016 20:16:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=xRshRlbHWAsydROr8N7x21guVejFoSGMCGWm9uLpQM4=; b=lSCj3yS5gdETEUSD05tCZ+wHBqHgqR4uEB7lNv4PplQeAUBFU+SDnz1pY2DqejGhpb xOQvYcFjx28dfvkxJRq/GYiouY6rJxFYKxmHoNRH/uXU4Ug0Tbhgw0dDxZFFYopQlpI7 xgmW72O89S89mxmmr3t618Arn7S1OxsYSjsswtKXw/0TxqKs5No9SSoMlJ/kc7QtJEat RvchxbwTSAPb/RxIw2Ef0SIQpaQ7LFcchYEt5gQ2+iVqihsRVcDEl9NTGgxBkzc3Rrn3 Ijm+ua7fP+MBqXPTY0K5JNEzazTqyG2fKPycGOr2UnE1YaN1mb8hM3wl1465ZjhuWpr7 EeJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=xRshRlbHWAsydROr8N7x21guVejFoSGMCGWm9uLpQM4=; b=HKOR9oSNbYOr/0PGDxT78SphECuvGaZpdgiQayXMEjEie9YYP3g1RU7x18rmXC5g0B 5LdQCk6JVcPvwyo5yglet3qEpSu1UdUWTxI242BBy5aLbrpJoBBL9+kz4Ck/HFv3daHe tXIJd6yTkdT+lpkX3AUVHMOabwhwhg7kIWoSCsI2VXpS+1XriYxGBDuete5bBbM3ZTDX tEol8Ftw7WV7tUbdhzbgIAIIVY/vR27oDje3G6mse6ffnK5FTqt2Q/0RfQOtKLrVY4If EUdtJzJGKn2cW+7kmWarkiOz5oc5zjz7npRx/ECgZAgyekUVKI30Vs733KP59Y1k9H6Z XXag== X-Gm-Message-State: AG10YORZJJHmUucELE1cNDi5IQeQYHI7yTi9TW0GSjw8X53G2s24RzBCxQa77Nt5zjKINQ== X-Received: by 10.107.36.5 with SMTP id k5mr705274iok.137.1455250586310; Thu, 11 Feb 2016 20:16:26 -0800 (PST) Received: from shaun-mbpr.localdomain ([199.19.94.135]) by smtp.gmail.com with ESMTPSA id 77sm5553527ioh.21.2016.02.11.20.16.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 11 Feb 2016 20:16:25 -0800 (PST) From: Shaun Ren To: gregkh@linuxfoundation.org, rjui@broadcom.com Subject: [PATCH v4 8/8] Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL Date: Thu, 11 Feb 2016 20:08:00 -0800 Message-Id: <1455250080-9897-9-git-send-email-shaun.ren@linux.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1455250080-9897-1-git-send-email-shaun.ren@linux.com> References: <1455072328-7033-1-git-send-email-shaun.ren@linux.com> <1455250080-9897-1-git-send-email-shaun.ren@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160211_201647_463915_636595C5 X-CRM114-Status: UNSURE ( 8.42 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, sbranden@broadcom.com, jonmason@broadcom.com, linux-kernel@vger.kernel.org, Shaun Ren , bcm-kernel-feedback-list@broadcom.com, joe@perches.com, mahfouz.saif.elyazal@gmail.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch changes all comparsions to NULL with !..., as reported by checkpatch.pl. Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c index be3423a..73e50ec 100644 --- a/drivers/staging/rts5208/rtsx_transport.c +++ b/drivers/staging/rts5208/rtsx_transport.c @@ -338,7 +338,7 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card, struct scatterlist *sg_ptr; u32 val = TRIG_DMA; - if ((sg == NULL) || (num_sg <= 0) || !offset || !index) + if (!sg || (num_sg <= 0) || !offset || !index) return -EIO; if (dma_dir == DMA_TO_DEVICE) @@ -502,7 +502,7 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card, long timeleft; struct scatterlist *sg_ptr; - if ((sg == NULL) || (num_sg <= 0)) + if (!sg || (num_sg <= 0)) return -EIO; if (dma_dir == DMA_TO_DEVICE) @@ -649,7 +649,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf, u32 val = 1 << 31; long timeleft; - if ((buf == NULL) || (len <= 0)) + if (!buf || (len <= 0)) return -EIO; if (dma_dir == DMA_TO_DEVICE)