| Message ID | 1455273762-161477-1-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 12 Feb 2016 11:42:34 +0100 > The ks8995 phy driver just started using gpiod_* functions, which are > declared in linux/gpio/consumer.h, not linux/gpio.h, resulting in a > build failure in randconfig builds that do not have CONFIG_GPIOLIB > enabled: > > drivers/net/phy/spi_ks8995.c: In function 'ks8995_probe': > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] > > This changes the header inclusion so it builds in all configurations. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") Applied, thanks Arnd.
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index 5e7340f6b37c..b5d50d458728 100644 --- a/drivers/net/phy/spi_ks8995.c +++ b/drivers/net/phy/spi_ks8995.c @@ -18,8 +18,8 @@ #include <linux/module.h> #include <linux/delay.h> #include <linux/device.h> +#include <linux/gpio/consumer.h> #include <linux/of.h> -#include <linux/gpio.h> #include <linux/of_gpio.h> #include <linux/spi/spi.h>
The ks8995 phy driver just started using gpiod_* functions, which are declared in linux/gpio/consumer.h, not linux/gpio.h, resulting in a build failure in randconfig builds that do not have CONFIG_GPIOLIB enabled: drivers/net/phy/spi_ks8995.c: In function 'ks8995_probe': drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] This changes the header inclusion so it builds in all configurations. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") --- drivers/net/phy/spi_ks8995.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)