diff mbox

[v3,4/4] Documentation: atmel-pmc: add DT bindings for fast startup

Message ID 1455507630-29592-5-git-send-email-wenyou.yang@atmel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wenyou Yang Feb. 15, 2016, 3:40 a.m. UTC 
Add DT bindings to configurate the PMC_FSMR and PMC_FSPR registers
to trigger a fast restart signal to PMC.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Document: binding

---

Changes in v3:
 - update the property description.

Changes in v2:
 - change the property name and property description.

 .../devicetree/bindings/arm/atmel-pmc.txt          |   63 ++++++++++++++++++++
 1 file changed, 63 insertions(+)

Comments

Rob Herring Feb. 22, 2016, 2:54 a.m. UTC | #1 
On Mon, Feb 15, 2016 at 11:40:30AM +0800, Wenyou Yang wrote:
> Add DT bindings to configurate the PMC_FSMR and PMC_FSPR registers
> to trigger a fast restart signal to PMC.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Document: binding
> 
> ---
> 
> Changes in v3:
>  - update the property description.

This is not helpful. Assume I don't remember what I told you and you 
need to jog my memory what exactly changed so I don't have to go look it 
up.

> 
> Changes in v2:
>  - change the property name and property description.
> 
>  .../devicetree/bindings/arm/atmel-pmc.txt          |   63 ++++++++++++++++++++
>  1 file changed, 63 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>
Wenyou Yang Feb. 22, 2016, 3:03 a.m. UTC | #2 
> -----Original Message-----

> From: Rob Herring [mailto:robh@kernel.org]

> Sent: 2016?2?22? 10:54

> To: Yang, Wenyou <Wenyou.Yang@atmel.com>

> Cc: Ferre, Nicolas <Nicolas.FERRE@atmel.com>; Alexandre Belloni

> <alexandre.belloni@free-electrons.com>; Jean-Christophe Plagniol-Villard

> <plagnioj@jcrosoft.com>; Russell King <linux@arm.linux.org.uk>; linux-

> clk@vger.kernel.org; Pawel Moll <pawel.moll@arm.com>; Mark Brown

> <broonie@kernel.org>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar

> Gala <galak@codeaurora.org>; linux-arm-kernel@lists.infradead.org; linux-

> kernel@vger.kernel.org; devicetree@vger.kernel.org

> Subject: Re: [PATCH v3 4/4] Documentation: atmel-pmc: add DT bindings for fast

> startup

> 

> On Mon, Feb 15, 2016 at 11:40:30AM +0800, Wenyou Yang wrote:

> > Add DT bindings to configurate the PMC_FSMR and PMC_FSPR registers to

> > trigger a fast restart signal to PMC.

> >

> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

> > Document: binding

> >

> > ---

> >

> > Changes in v3:

> >  - update the property description.

> 

> This is not helpful. Assume I don't remember what I told you and you need to jog

> my memory what exactly changed so I don't have to go look it up.


Thank you for your instruction, I will keep it in mind.

> 

> >

> > Changes in v2:

> >  - change the property name and property description.

> >

> >  .../devicetree/bindings/arm/atmel-pmc.txt          |   63

> ++++++++++++++++++++

> >  1 file changed, 63 insertions(+)

> 

> Acked-by: Rob Herring <robh@kernel.org>


Thank you for your Acked.


Best Regards,
Wenyou Yang
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/atmel-pmc.txt b/Documentation/devicetree/bindings/arm/atmel-pmc.txt
index 795cc78..0d2481c 100644
--- a/Documentation/devicetree/bindings/arm/atmel-pmc.txt
+++ b/Documentation/devicetree/bindings/arm/atmel-pmc.txt
@@ -12,3 +12,66 @@  Examples:
 		compatible = "atmel,at91rm9200-pmc";
 		reg = <0xfffffc00 0x100>;
 	};
+
+PMC Fast Startup Signals
+
+The PMC Fast Start Signals are used as the wake up source to trigger the PMC
+to wake up the system from the ULP1 mode.
+
+required properties:
+- compatible: Should be "atmel,sama5d2-pmc-fast-startup".
+
+optional properties:
+- atmel,wkup-trigger: boolean, WKUP input can trigger a fast restart signal.
+- atmel,secumod-trigger: boolean, SECUMOD can trigger a fast restart signal.
+- atmel,piobu0-trigger: boolean, PIOBU0 input can trigger a fast restart signal.
+- atmel,piobu1-trigger: boolean, PIOBU1 input can trigger a fast restart signal.
+- atmel,piobu2-trigger: boolean, PIOBU2 input can trigger a fast restart signal.
+- atmel,piobu3-trigger: boolean, PIOBU3 input can trigger a fast restart signal.
+- atmel,piobu4-trigger: boolean, PIOBU4 input can trigger a fast restart signal.
+- atmel,piobu5-trigger: boolean, PIOBU5 input can trigger a fast restart signal.
+- atmel,piobu6-trigger: boolean, PIOBU6 input can trigger a fast restart signal.
+- atmel,piobu7-trigger: boolean, PIOBU7 input can trigger a fast restart signal.
+- atmel,gmac-wol-trigger: boolean, GMAC_WOL can trigger a fast restart signal.
+- atmel,rtc-alarm-trigger: boolean, RTC alarm can trigger a fast restart signal.
+- atmel,usb-resume-trigger: boolean, USB resume can trigger a fast restart
+  signal.
+- atmel,sdmmc-cd-trigger: boolean, SDMMC card detect can trigger a fast
+  restart signal.
+- atmel,rxlp-match-trigger: boolean, Matching condition on RXLP can trigger
+  a fast restart signal.
+- atmel,acc-comparison-trigger: boolean, ACC comparison can trigger a fast
+  restart signal.
+
+- atmel,wkup-trigger-level: int, defines the active polarity of the wake-up
+  input. Supported values are: 1 or 0.
+- atmel,piobu0-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU0 input. Supported values are: 1 or 0.
+- atmel,piobu1-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU1 input. Supported values are: 1 or 0.
+- atmel,piobu2-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU2 input. Supported values are: 1 or 0".
+- atmel,piobu3-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU3 input. Supported values are: 1 or 0.
+- atmel,piobu4-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU4 input. Supported values are: 1 or 0.
+- atmel,piobu5-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU5 input. Supported values are: 1 or 0.
+- atmel,piobu6-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU6 input. Supported values are: 1 or 0.
+- atmel,piobu7-trigger-level: int, defines the active polarity of
+  the corresponding PIOBU7 input. Supported values are: 1 or 0.
+
+Example:
+
+	pmc: pmc@f0014000 {
+		compatible = "atmel,sama5d2-pmc";
+		reg = <0xf0014000 0x160>;
+
+		pmc_fast_restart {
+			compatible = "atmel,sama5d2-pmc-fast-startup";
+			atmel,wkup-trigger;
+			atmel,rtc-alarm-trigger;
+			atmel,wkup-trigger-level = <0>;
+		};
+	};