| Message ID | 1455521698-7905-2-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Thomas, 2016-02-15 8:34 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > The drivers/clk/mvebu directory is only being built when > CONFIG_PLAT_ORION=y. As we are going to support additional mvebu > platforms in drivers/clk/mvebu, which don't have CONFIG_PLAT_ORION=y, > we need to recurse into this directory regardless of the value of > CONFIG_PLAT_ORION. > > Since all files in drivers/clk/mvebu/ are already conditionally > compiled depending on various Kconfig options, we can recurse > unconditionally into drivers/clk/mvebu without any other change. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > drivers/clk/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index b038e36..e08bb0e 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -61,7 +61,7 @@ obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ > ifeq ($(CONFIG_COMMON_CLK), y) > obj-$(CONFIG_ARCH_MMP) += mmp/ > endif > -obj-$(CONFIG_PLAT_ORION) += mvebu/ > +obj-y += mvebu/ I know it works with obj-y, but how about using obj-$(CONFIG_ARCH_MVEBU)? A person editing this Kconfig in future wouldn't have to run git blame in order to ensure with your commit log, that he doesn't compile anything more than planned. Best regards, Marcin
Hi Marcin, On lun., févr. 15 2016, Marcin Wojtas <mw@semihalf.com> wrote: > Hi Thomas, > > > > 2016-02-15 8:34 GMT+01:00 Thomas Petazzoni > <thomas.petazzoni@free-electrons.com>: >> The drivers/clk/mvebu directory is only being built when >> CONFIG_PLAT_ORION=y. As we are going to support additional mvebu >> platforms in drivers/clk/mvebu, which don't have CONFIG_PLAT_ORION=y, >> we need to recurse into this directory regardless of the value of >> CONFIG_PLAT_ORION. >> >> Since all files in drivers/clk/mvebu/ are already conditionally >> compiled depending on various Kconfig options, we can recurse >> unconditionally into drivers/clk/mvebu without any other change. >> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> --- >> drivers/clk/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile >> index b038e36..e08bb0e 100644 >> --- a/drivers/clk/Makefile >> +++ b/drivers/clk/Makefile >> @@ -61,7 +61,7 @@ obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ >> ifeq ($(CONFIG_COMMON_CLK), y) >> obj-$(CONFIG_ARCH_MMP) += mmp/ >> endif >> -obj-$(CONFIG_PLAT_ORION) += mvebu/ >> +obj-y += mvebu/ > > I know it works with obj-y, but how about using > obj-$(CONFIG_ARCH_MVEBU)? A person editing this Kconfig in future > wouldn't have to run git blame in order to ensure with your commit > log, that he doesn't compile anything more than planned. I think it is still possible to have CONFIG_PLAT_ORION selected without having CONFIG_ARCH_MVEBU. So for your concern, adding a comment would be enough. Gregory > > Best regards, > Marcin
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index b038e36..e08bb0e 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile @@ -61,7 +61,7 @@ obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ ifeq ($(CONFIG_COMMON_CLK), y) obj-$(CONFIG_ARCH_MMP) += mmp/ endif -obj-$(CONFIG_PLAT_ORION) += mvebu/ +obj-y += mvebu/ obj-$(CONFIG_ARCH_MESON) += meson/ obj-$(CONFIG_ARCH_MXS) += mxs/ obj-$(CONFIG_MACH_PISTACHIO) += pistachio/
The drivers/clk/mvebu directory is only being built when CONFIG_PLAT_ORION=y. As we are going to support additional mvebu platforms in drivers/clk/mvebu, which don't have CONFIG_PLAT_ORION=y, we need to recurse into this directory regardless of the value of CONFIG_PLAT_ORION. Since all files in drivers/clk/mvebu/ are already conditionally compiled depending on various Kconfig options, we can recurse unconditionally into drivers/clk/mvebu without any other change. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- drivers/clk/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)