| Message ID | 1455799149-19590-3-git-send-email-rrichter@caviumnetworks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
From: Robert Richter <rrichter@caviumnetworks.com> Date: Thu, 18 Feb 2016 13:39:09 +0100 > From: Robert Richter <rrichter@cavium.com> > > Looks like the :1 notation was accidentally introduced (this still > uses 1 byte per flag). Using bool instead, which is the common use. > > Signed-off-by: Robert Richter <rrichter@cavium.com> Such cleanups are not appropriate for 'net'. Only real bug fixes should be targetted that. Respin these patches targetting the correct tree(s).
On 18.02.16 11:05:14, David Miller wrote: > From: Robert Richter <rrichter@caviumnetworks.com> > Date: Thu, 18 Feb 2016 13:39:09 +0100 > > > From: Robert Richter <rrichter@cavium.com> > > > > Looks like the :1 notation was accidentally introduced (this still > > uses 1 byte per flag). Using bool instead, which is the common use. > > > > Signed-off-by: Robert Richter <rrichter@cavium.com> > > Such cleanups are not appropriate for 'net'. Only real bug fixes should > be targetted that. > > Respin these patches targetting the correct tree(s). Do you mean posting the two as "trivial" patches? Thanks, -Robert
From: Robert Richter <robert.richter@caviumnetworks.com> Date: Thu, 18 Feb 2016 17:42:17 +0100 > On 18.02.16 11:05:14, David Miller wrote: >> From: Robert Richter <rrichter@caviumnetworks.com> >> Date: Thu, 18 Feb 2016 13:39:09 +0100 >> >> > From: Robert Richter <rrichter@cavium.com> >> > >> > Looks like the :1 notation was accidentally introduced (this still >> > uses 1 byte per flag). Using bool instead, which is the common use. >> > >> > Signed-off-by: Robert Richter <rrichter@cavium.com> >> >> Such cleanups are not appropriate for 'net'. Only real bug fixes should >> be targetted that. >> >> Respin these patches targetting the correct tree(s). > > Do you mean posting the two as "trivial" patches? No I mean posting #1 targetted at my 'net' GIT tree as a bug fix, and posting #2 targetted separately at my 'net-next' GIT tree as a cleanup. This is how we've been doing things for more than a decade.
From: Robert Richter > Sent: 18 February 2016 12:39 > From: Robert Richter <rrichter@cavium.com> > > Looks like the :1 notation was accidentally introduced (this still > uses 1 byte per flag). Using bool instead, which is the common use. > > Signed-off-by: Robert Richter <rrichter@cavium.com> > --- > drivers/net/ethernet/cavium/thunder/nic.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h > index 688828865c48..fa5b1d2d8e23 100644 > --- a/drivers/net/ethernet/cavium/thunder/nic.h > +++ b/drivers/net/ethernet/cavium/thunder/nic.h > @@ -262,9 +262,9 @@ struct nicvf { > struct pci_dev *pdev; > u8 vf_id; > u8 node; > - u8 tns_mode:1; > - u8 sqs_mode:1; > - u8 loopback_supported:1; > + bool tns_mode; > + bool sqs_mode; > + bool loopback_supported; > bool hw_tso; > u16 mtu; > struct queue_set *qs; If the size of the structure matters, you've just made it two bytes larger. (Although it looks like there is some padding). David
diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h index 688828865c48..fa5b1d2d8e23 100644 --- a/drivers/net/ethernet/cavium/thunder/nic.h +++ b/drivers/net/ethernet/cavium/thunder/nic.h @@ -262,9 +262,9 @@ struct nicvf { struct pci_dev *pdev; u8 vf_id; u8 node; - u8 tns_mode:1; - u8 sqs_mode:1; - u8 loopback_supported:1; + bool tns_mode; + bool sqs_mode; + bool loopback_supported; bool hw_tso; u16 mtu; struct queue_set *qs; @@ -353,9 +353,9 @@ struct nic_cfg_msg { u8 msg; u8 vf_id; u8 node_id; - u8 tns_mode:1; - u8 sqs_mode:1; - u8 loopback_supported:1; + bool tns_mode; + bool sqs_mode; + bool loopback_supported; u8 mac_addr[ETH_ALEN]; };