diff mbox

[2/5] all: introduce COMPAT_WRAPPER option and enable it for s390

Message ID 1456338854-14901-3-git-send-email-ynorov@caviumnetworks.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yury Norov Feb. 24, 2016, 6:34 p.m. UTC
Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
 arch/Kconfig      | 4 ++++
 arch/s390/Kconfig | 1 +
 2 files changed, 5 insertions(+)

Comments

Heiko Carstens Feb. 25, 2016, 8:49 a.m. UTC | #1
On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote:
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
>  arch/Kconfig      | 4 ++++
>  arch/s390/Kconfig | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/Kconfig b/arch/Kconfig
> index f6b649d..6393093 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -583,6 +583,10 @@ config HAVE_COPY_THREAD_TLS
>  	  normal C parameter passing, rather than extracting the syscall
>  	  argument from pt_regs.
> 
> +config COMPAT_WRAPPER
> +	bool
> +	depends on COMPAT
> +
>  #
>  # ABI hall of shame
>  #
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 3be9c83..082b861 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -333,6 +333,7 @@ config COMPAT
>  	select COMPAT_BINFMT_ELF if BINFMT_ELF
>  	select ARCH_WANT_OLD_COMPAT_IPC
>  	select COMPAT_OLD_SIGACTION
> +	select COMPAT_WRAPPER
>  	depends on MULTIUSER
>  	help
>  	  Select this option if you want to enable your system kernel to

Maybe merge this into patch 4/5?
Yury Norov Feb. 25, 2016, 8:19 p.m. UTC | #2
On Thu, Feb 25, 2016 at 09:49:43AM +0100, Heiko Carstens wrote:
> On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote:
> > Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> > ---
> >  arch/Kconfig      | 4 ++++
> >  arch/s390/Kconfig | 1 +
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index f6b649d..6393093 100644
> > --- a/arch/Kconfig
> > +++ b/arch/Kconfig
> > @@ -583,6 +583,10 @@ config HAVE_COPY_THREAD_TLS
> >  	  normal C parameter passing, rather than extracting the syscall
> >  	  argument from pt_regs.
> > 
> > +config COMPAT_WRAPPER
> > +	bool
> > +	depends on COMPAT
> > +
> >  #
> >  # ABI hall of shame
> >  #
> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > index 3be9c83..082b861 100644
> > --- a/arch/s390/Kconfig
> > +++ b/arch/s390/Kconfig
> > @@ -333,6 +333,7 @@ config COMPAT
> >  	select COMPAT_BINFMT_ELF if BINFMT_ELF
> >  	select ARCH_WANT_OLD_COMPAT_IPC
> >  	select COMPAT_OLD_SIGACTION
> > +	select COMPAT_WRAPPER
> >  	depends on MULTIUSER
> >  	help
> >  	  Select this option if you want to enable your system kernel to
> 
> Maybe merge this into patch 4/5?

Then bisectability will suffer, as next patch needs COMPAT_WRAPPER
enabled.

> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Heiko Carstens Feb. 25, 2016, 10:10 p.m. UTC | #3
On Thu, Feb 25, 2016 at 11:19:26PM +0300, Yury Norov wrote:
> On Thu, Feb 25, 2016 at 09:49:43AM +0100, Heiko Carstens wrote:
> > On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote:
> > > Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> > > ---
> > >  arch/Kconfig      | 4 ++++
> > >  arch/s390/Kconfig | 1 +
> > >  2 files changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/Kconfig b/arch/Kconfig
> > > index f6b649d..6393093 100644
> > > --- a/arch/Kconfig
> > > +++ b/arch/Kconfig
> > > @@ -583,6 +583,10 @@ config HAVE_COPY_THREAD_TLS
> > >  	  normal C parameter passing, rather than extracting the syscall
> > >  	  argument from pt_regs.
> > > 
> > > +config COMPAT_WRAPPER
> > > +	bool
> > > +	depends on COMPAT
> > > +
> > >  #
> > >  # ABI hall of shame
> > >  #
> > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > > index 3be9c83..082b861 100644
> > > --- a/arch/s390/Kconfig
> > > +++ b/arch/s390/Kconfig
> > > @@ -333,6 +333,7 @@ config COMPAT
> > >  	select COMPAT_BINFMT_ELF if BINFMT_ELF
> > >  	select ARCH_WANT_OLD_COMPAT_IPC
> > >  	select COMPAT_OLD_SIGACTION
> > > +	select COMPAT_WRAPPER
> > >  	depends on MULTIUSER
> > >  	help
> > >  	  Select this option if you want to enable your system kernel to
> > 
> > Maybe merge this into patch 4/5?
> 
> Then bisectability will suffer, as next patch needs COMPAT_WRAPPER
> enabled.

Oh, right. I didn't realize that you put the macros between an
#ifdef CONFIG_COMPAT_WRAPPER . It's not strictly needed, but it
doesn't hurt as well.
diff mbox

Patch

diff --git a/arch/Kconfig b/arch/Kconfig
index f6b649d..6393093 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -583,6 +583,10 @@  config HAVE_COPY_THREAD_TLS
 	  normal C parameter passing, rather than extracting the syscall
 	  argument from pt_regs.
 
+config COMPAT_WRAPPER
+	bool
+	depends on COMPAT
+
 #
 # ABI hall of shame
 #
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 3be9c83..082b861 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -333,6 +333,7 @@  config COMPAT
 	select COMPAT_BINFMT_ELF if BINFMT_ELF
 	select ARCH_WANT_OLD_COMPAT_IPC
 	select COMPAT_OLD_SIGACTION
+	select COMPAT_WRAPPER
 	depends on MULTIUSER
 	help
 	  Select this option if you want to enable your system kernel to