diff mbox

arm: mvebu: Add SPI1 pinctrl defines for Armada XP

Message ID 1456739914-12096-1-git-send-email-sr@denx.de (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Roese Feb. 29, 2016, 9:58 a.m. UTC
This patch defines and uses common Armada XP pinctrl settings in
armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Thomas Petazzoni Feb. 29, 2016, 10:42 a.m. UTC | #1
Dear Stefan Roese,

On Mon, 29 Feb 2016 10:58:34 +0100, Stefan Roese wrote:
> This patch defines and uses common Armada XP pinctrl settings in
> armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks!

Thomas
Stefan Roese July 13, 2016, 9:38 a.m. UTC | #2
Hi Gregory,

On 29.02.2016 11:42, Thomas Petazzoni wrote:
> On Mon, 29 Feb 2016 10:58:34 +0100, Stefan Roese wrote:
>> This patch defines and uses common Armada XP pinctrl settings in
>> armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>>   arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I'm currently rebasing my SPI dts patches and noticed that this
patch is not in mailine yet. Should I perhaps send it again with
the SPI dts move patches?

Thanks,
Stefan
Gregory CLEMENT July 13, 2016, 9:43 a.m. UTC | #3
Hi Stefan,
 
 On mer., juil. 13 2016, Stefan Roese <sr@denx.de> wrote:

> Hi Gregory,
>
> On 29.02.2016 11:42, Thomas Petazzoni wrote:
>> On Mon, 29 Feb 2016 10:58:34 +0100, Stefan Roese wrote:
>>> This patch defines and uses common Armada XP pinctrl settings in
>>> armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
>>> ---
>>>   arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>
>> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I'm currently rebasing my SPI dts patches and noticed that this
> patch is not in mailine yet. Should I perhaps send it again with
> the SPI dts move patches?

Yes sure, there was no reason to not having merging it at this time, I
think I've just missed it.

Gregory

>
> Thanks,
> Stefan
diff mbox

Patch

diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
index be23196..c779e31 100644
--- a/arch/arm/boot/dts/armada-xp.dtsi
+++ b/arch/arm/boot/dts/armada-xp.dtsi
@@ -94,6 +94,8 @@ 
 			spi1: spi@10680 {
 				compatible = "marvell,armada-xp-spi",
 						"marvell,orion-spi";
+				pinctrl-0 = <&spi1_pins>;
+				pinctrl-names = "default";
 			};
 
 
@@ -343,6 +345,12 @@ 
 		marvell,function = "spi0";
 	};
 
+	spi1_pins: spi1-pins {
+		marvell,pins = "mpp13", "mpp14",
+			       "mpp16", "mpp17";
+		marvell,function = "spi1";
+	};
+
 	uart2_pins: uart2-pins {
 		marvell,pins = "mpp42", "mpp43";
 		marvell,function = "uart2";